This is an archive of the discontinued LLVM Phabricator instance.

Differential D152922

[lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def
ClosedPublic

Authored by eopXD on Jun 14 2023, 7:41 AM.

Details

Reviewers
DavidSpickett
Commits
rG3f9f9e0d9273: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to…
Summary

This approach prevents us from adding new lines into the switch case
when new types are introduced.

Diff Detail

Event Timeline

eopXD created this revision.Jun 14 2023, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 7:41 AM
Herald added subscribers: jobnoorman, VincentWu, vkmr and 12 others. · View Herald Transcript
eopXD requested review of this revision.Jun 14 2023, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 7:41 AM
Herald added subscribers: lldb-commits, • pcwang-thead. · View Herald Transcript
DavidSpickett accepted this revision.Jun 14 2023, 8:02 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 14 2023, 8:02 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptJun 14 2023, 8:02 AM
eopXD edited the summary of this revision. (Show Details)Jun 14 2023, 9:08 AM
eopXD updated this revision to Diff 531616.Jun 14 2023, 11:02 PM

Rebase to latest main.

This revision was landed with ongoing or failed builds.Jun 14 2023, 11:03 PM
Closed by commit rG3f9f9e0d9273: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to… (authored by eopXD). · Explain Why
This revision was automatically updated to reflect the committed changes.
eopXD added a commit: rG3f9f9e0d9273: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to….
Harbormaster completed remote builds in B239033: Diff 531616.Jun 14 2023, 11:06 PM
eopXD mentioned this in D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types.Jun 15 2023, 9:56 AM

Revision Contents

PathSize
lldb/
source/
Plugins/
TypeSystem/
Clang/
294 lines

Diff 531617

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,035 Lines • ▼ Show 20 Lines case clang::Type::Builtin:
case clang::BuiltinType::SveFloat32x4: case clang::BuiltinType::SveFloat32x4:
case clang::BuiltinType::SveFloat64: case clang::BuiltinType::SveFloat64:
case clang::BuiltinType::SveFloat64x2: case clang::BuiltinType::SveFloat64x2:
case clang::BuiltinType::SveFloat64x3: case clang::BuiltinType::SveFloat64x3:
case clang::BuiltinType::SveFloat64x4: case clang::BuiltinType::SveFloat64x4:
break; break;
// RISC-V V builtin types. // RISC-V V builtin types.
case clang::BuiltinType::RvvInt8mf8: #define RVV_TYPE(Name, Id, SingletonId) case clang::BuiltinType::Id:
case clang::BuiltinType::RvvInt8mf4: #include "clang/Basic/RISCVVTypes.def"
case clang::BuiltinType::RvvInt8mf2:
case clang::BuiltinType::RvvInt8m1:
case clang::BuiltinType::RvvInt8m2:
case clang::BuiltinType::RvvInt8m4:
case clang::BuiltinType::RvvInt8m8:
case clang::BuiltinType::RvvUint8mf8:
case clang::BuiltinType::RvvUint8mf4:
case clang::BuiltinType::RvvUint8mf2:
case clang::BuiltinType::RvvUint8m1:
case clang::BuiltinType::RvvUint8m2:
case clang::BuiltinType::RvvUint8m4:
case clang::BuiltinType::RvvUint8m8:
case clang::BuiltinType::RvvInt16mf4:
case clang::BuiltinType::RvvInt16mf2:
case clang::BuiltinType::RvvInt16m1:
case clang::BuiltinType::RvvInt16m2:
case clang::BuiltinType::RvvInt16m4:
case clang::BuiltinType::RvvInt16m8:
case clang::BuiltinType::RvvUint16mf4:
case clang::BuiltinType::RvvUint16mf2:
case clang::BuiltinType::RvvUint16m1:
case clang::BuiltinType::RvvUint16m2:
case clang::BuiltinType::RvvUint16m4:
case clang::BuiltinType::RvvUint16m8:
case clang::BuiltinType::RvvInt32mf2:
case clang::BuiltinType::RvvInt32m1:
case clang::BuiltinType::RvvInt32m2:
case clang::BuiltinType::RvvInt32m4:
case clang::BuiltinType::RvvInt32m8:
case clang::BuiltinType::RvvUint32mf2:
case clang::BuiltinType::RvvUint32m1:
case clang::BuiltinType::RvvUint32m2:
case clang::BuiltinType::RvvUint32m4:
case clang::BuiltinType::RvvUint32m8:
case clang::BuiltinType::RvvInt64m1:
case clang::BuiltinType::RvvInt64m2:
case clang::BuiltinType::RvvInt64m4:
case clang::BuiltinType::RvvInt64m8:
case clang::BuiltinType::RvvUint64m1:
case clang::BuiltinType::RvvUint64m2:
case clang::BuiltinType::RvvUint64m4:
case clang::BuiltinType::RvvUint64m8:
case clang::BuiltinType::RvvFloat16mf4:
case clang::BuiltinType::RvvFloat16mf2:
case clang::BuiltinType::RvvFloat16m1:
case clang::BuiltinType::RvvFloat16m2:
case clang::BuiltinType::RvvFloat16m4:
case clang::BuiltinType::RvvFloat16m8:
case clang::BuiltinType::RvvFloat32mf2:
case clang::BuiltinType::RvvFloat32m1:
case clang::BuiltinType::RvvFloat32m2:
case clang::BuiltinType::RvvFloat32m4:
case clang::BuiltinType::RvvFloat32m8:
case clang::BuiltinType::RvvFloat64m1:
case clang::BuiltinType::RvvFloat64m2:
case clang::BuiltinType::RvvFloat64m4:
case clang::BuiltinType::RvvFloat64m8:
case clang::BuiltinType::RvvBool1:
case clang::BuiltinType::RvvBool2:
case clang::BuiltinType::RvvBool4:
case clang::BuiltinType::RvvBool8:
case clang::BuiltinType::RvvBool16:
case clang::BuiltinType::RvvBool32:
case clang::BuiltinType::RvvBool64:
case clang::BuiltinType::RvvInt8mf8x2:
case clang::BuiltinType::RvvInt8mf8x3:
case clang::BuiltinType::RvvInt8mf8x4:
case clang::BuiltinType::RvvInt8mf8x5:
case clang::BuiltinType::RvvInt8mf8x6:
case clang::BuiltinType::RvvInt8mf8x7:
case clang::BuiltinType::RvvInt8mf8x8:
case clang::BuiltinType::RvvInt8mf4x2:
case clang::BuiltinType::RvvInt8mf4x3:
case clang::BuiltinType::RvvInt8mf4x4:
case clang::BuiltinType::RvvInt8mf4x5:
case clang::BuiltinType::RvvInt8mf4x6:
case clang::BuiltinType::RvvInt8mf4x7:
case clang::BuiltinType::RvvInt8mf4x8:
case clang::BuiltinType::RvvInt8mf2x2:
case clang::BuiltinType::RvvInt8mf2x3:
case clang::BuiltinType::RvvInt8mf2x4:
case clang::BuiltinType::RvvInt8mf2x5:
case clang::BuiltinType::RvvInt8mf2x6:
case clang::BuiltinType::RvvInt8mf2x7:
case clang::BuiltinType::RvvInt8mf2x8:
case clang::BuiltinType::RvvInt8m1x2:
case clang::BuiltinType::RvvInt8m1x3:
case clang::BuiltinType::RvvInt8m1x4:
case clang::BuiltinType::RvvInt8m1x5:
case clang::BuiltinType::RvvInt8m1x6:
case clang::BuiltinType::RvvInt8m1x7:
case clang::BuiltinType::RvvInt8m1x8:
case clang::BuiltinType::RvvInt8m2x2:
case clang::BuiltinType::RvvInt8m2x3:
case clang::BuiltinType::RvvInt8m2x4:
case clang::BuiltinType::RvvInt8m4x2:
case clang::BuiltinType::RvvUint8mf8x2:
case clang::BuiltinType::RvvUint8mf8x3:
case clang::BuiltinType::RvvUint8mf8x4:
case clang::BuiltinType::RvvUint8mf8x5:
case clang::BuiltinType::RvvUint8mf8x6:
case clang::BuiltinType::RvvUint8mf8x7:
case clang::BuiltinType::RvvUint8mf8x8:
case clang::BuiltinType::RvvUint8mf4x2:
case clang::BuiltinType::RvvUint8mf4x3:
case clang::BuiltinType::RvvUint8mf4x4:
case clang::BuiltinType::RvvUint8mf4x5:
case clang::BuiltinType::RvvUint8mf4x6:
case clang::BuiltinType::RvvUint8mf4x7:
case clang::BuiltinType::RvvUint8mf4x8:
case clang::BuiltinType::RvvUint8mf2x2:
case clang::BuiltinType::RvvUint8mf2x3:
case clang::BuiltinType::RvvUint8mf2x4:
case clang::BuiltinType::RvvUint8mf2x5:
case clang::BuiltinType::RvvUint8mf2x6:
case clang::BuiltinType::RvvUint8mf2x7:
case clang::BuiltinType::RvvUint8mf2x8:
case clang::BuiltinType::RvvUint8m1x2:
case clang::BuiltinType::RvvUint8m1x3:
case clang::BuiltinType::RvvUint8m1x4:
case clang::BuiltinType::RvvUint8m1x5:
case clang::BuiltinType::RvvUint8m1x6:
case clang::BuiltinType::RvvUint8m1x7:
case clang::BuiltinType::RvvUint8m1x8:
case clang::BuiltinType::RvvUint8m2x2:
case clang::BuiltinType::RvvUint8m2x3:
case clang::BuiltinType::RvvUint8m2x4:
case clang::BuiltinType::RvvUint8m4x2:
case clang::BuiltinType::RvvInt16mf4x2:
case clang::BuiltinType::RvvInt16mf4x3:
case clang::BuiltinType::RvvInt16mf4x4:
case clang::BuiltinType::RvvInt16mf4x5:
case clang::BuiltinType::RvvInt16mf4x6:
case clang::BuiltinType::RvvInt16mf4x7:
case clang::BuiltinType::RvvInt16mf4x8:
case clang::BuiltinType::RvvInt16mf2x2:
case clang::BuiltinType::RvvInt16mf2x3:
case clang::BuiltinType::RvvInt16mf2x4:
case clang::BuiltinType::RvvInt16mf2x5:
case clang::BuiltinType::RvvInt16mf2x6:
case clang::BuiltinType::RvvInt16mf2x7:
case clang::BuiltinType::RvvInt16mf2x8:
case clang::BuiltinType::RvvInt16m1x2:
case clang::BuiltinType::RvvInt16m1x3:
case clang::BuiltinType::RvvInt16m1x4:
case clang::BuiltinType::RvvInt16m1x5:
case clang::BuiltinType::RvvInt16m1x6:
case clang::BuiltinType::RvvInt16m1x7:
case clang::BuiltinType::RvvInt16m1x8:
case clang::BuiltinType::RvvInt16m2x2:
case clang::BuiltinType::RvvInt16m2x3:
case clang::BuiltinType::RvvInt16m2x4:
case clang::BuiltinType::RvvInt16m4x2:
case clang::BuiltinType::RvvUint16mf4x2:
case clang::BuiltinType::RvvUint16mf4x3:
case clang::BuiltinType::RvvUint16mf4x4:
case clang::BuiltinType::RvvUint16mf4x5:
case clang::BuiltinType::RvvUint16mf4x6:
case clang::BuiltinType::RvvUint16mf4x7:
case clang::BuiltinType::RvvUint16mf4x8:
case clang::BuiltinType::RvvUint16mf2x2:
case clang::BuiltinType::RvvUint16mf2x3:
case clang::BuiltinType::RvvUint16mf2x4:
case clang::BuiltinType::RvvUint16mf2x5:
case clang::BuiltinType::RvvUint16mf2x6:
case clang::BuiltinType::RvvUint16mf2x7:
case clang::BuiltinType::RvvUint16mf2x8:
case clang::BuiltinType::RvvUint16m1x2:
case clang::BuiltinType::RvvUint16m1x3:
case clang::BuiltinType::RvvUint16m1x4:
case clang::BuiltinType::RvvUint16m1x5:
case clang::BuiltinType::RvvUint16m1x6:
case clang::BuiltinType::RvvUint16m1x7:
case clang::BuiltinType::RvvUint16m1x8:
case clang::BuiltinType::RvvUint16m2x2:
case clang::BuiltinType::RvvUint16m2x3:
case clang::BuiltinType::RvvUint16m2x4:
case clang::BuiltinType::RvvUint16m4x2:
case clang::BuiltinType::RvvInt32mf2x2:
case clang::BuiltinType::RvvInt32mf2x3:
case clang::BuiltinType::RvvInt32mf2x4:
case clang::BuiltinType::RvvInt32mf2x5:
case clang::BuiltinType::RvvInt32mf2x6:
case clang::BuiltinType::RvvInt32mf2x7:
case clang::BuiltinType::RvvInt32mf2x8:
case clang::BuiltinType::RvvInt32m1x2:
case clang::BuiltinType::RvvInt32m1x3:
case clang::BuiltinType::RvvInt32m1x4:
case clang::BuiltinType::RvvInt32m1x5:
case clang::BuiltinType::RvvInt32m1x6:
case clang::BuiltinType::RvvInt32m1x7:
case clang::BuiltinType::RvvInt32m1x8:
case clang::BuiltinType::RvvInt32m2x2:
case clang::BuiltinType::RvvInt32m2x3:
case clang::BuiltinType::RvvInt32m2x4:
case clang::BuiltinType::RvvInt32m4x2:
case clang::BuiltinType::RvvUint32mf2x2:
case clang::BuiltinType::RvvUint32mf2x3:
case clang::BuiltinType::RvvUint32mf2x4:
case clang::BuiltinType::RvvUint32mf2x5:
case clang::BuiltinType::RvvUint32mf2x6:
case clang::BuiltinType::RvvUint32mf2x7:
case clang::BuiltinType::RvvUint32mf2x8:
case clang::BuiltinType::RvvUint32m1x2:
case clang::BuiltinType::RvvUint32m1x3:
case clang::BuiltinType::RvvUint32m1x4:
case clang::BuiltinType::RvvUint32m1x5:
case clang::BuiltinType::RvvUint32m1x6:
case clang::BuiltinType::RvvUint32m1x7:
case clang::BuiltinType::RvvUint32m1x8:
case clang::BuiltinType::RvvUint32m2x2:
case clang::BuiltinType::RvvUint32m2x3:
case clang::BuiltinType::RvvUint32m2x4:
case clang::BuiltinType::RvvUint32m4x2:
case clang::BuiltinType::RvvInt64m1x2:
case clang::BuiltinType::RvvInt64m1x3:
case clang::BuiltinType::RvvInt64m1x4:
case clang::BuiltinType::RvvInt64m1x5:
case clang::BuiltinType::RvvInt64m1x6:
case clang::BuiltinType::RvvInt64m1x7:
case clang::BuiltinType::RvvInt64m1x8:
case clang::BuiltinType::RvvInt64m2x2:
case clang::BuiltinType::RvvInt64m2x3:
case clang::BuiltinType::RvvInt64m2x4:
case clang::BuiltinType::RvvInt64m4x2:
case clang::BuiltinType::RvvUint64m1x2:
case clang::BuiltinType::RvvUint64m1x3:
case clang::BuiltinType::RvvUint64m1x4:
case clang::BuiltinType::RvvUint64m1x5:
case clang::BuiltinType::RvvUint64m1x6:
case clang::BuiltinType::RvvUint64m1x7:
case clang::BuiltinType::RvvUint64m1x8:
case clang::BuiltinType::RvvUint64m2x2:
case clang::BuiltinType::RvvUint64m2x3:
case clang::BuiltinType::RvvUint64m2x4:
case clang::BuiltinType::RvvUint64m4x2:
case clang::BuiltinType::RvvFloat16mf4x2:
case clang::BuiltinType::RvvFloat16mf4x3:
case clang::BuiltinType::RvvFloat16mf4x4:
case clang::BuiltinType::RvvFloat16mf4x5:
case clang::BuiltinType::RvvFloat16mf4x6:
case clang::BuiltinType::RvvFloat16mf4x7:
case clang::BuiltinType::RvvFloat16mf4x8:
case clang::BuiltinType::RvvFloat16mf2x2:
case clang::BuiltinType::RvvFloat16mf2x3:
case clang::BuiltinType::RvvFloat16mf2x4:
case clang::BuiltinType::RvvFloat16mf2x5:
case clang::BuiltinType::RvvFloat16mf2x6:
case clang::BuiltinType::RvvFloat16mf2x7:
case clang::BuiltinType::RvvFloat16mf2x8:
case clang::BuiltinType::RvvFloat16m1x2:
case clang::BuiltinType::RvvFloat16m1x3:
case clang::BuiltinType::RvvFloat16m1x4:
case clang::BuiltinType::RvvFloat16m1x5:
case clang::BuiltinType::RvvFloat16m1x6:
case clang::BuiltinType::RvvFloat16m1x7:
case clang::BuiltinType::RvvFloat16m1x8:
case clang::BuiltinType::RvvFloat16m2x2:
case clang::BuiltinType::RvvFloat16m2x3:
case clang::BuiltinType::RvvFloat16m2x4:
case clang::BuiltinType::RvvFloat16m4x2:
case clang::BuiltinType::RvvFloat32mf2x2:
case clang::BuiltinType::RvvFloat32mf2x3:
case clang::BuiltinType::RvvFloat32mf2x4:
case clang::BuiltinType::RvvFloat32mf2x5:
case clang::BuiltinType::RvvFloat32mf2x6:
case clang::BuiltinType::RvvFloat32mf2x7:
case clang::BuiltinType::RvvFloat32mf2x8:
case clang::BuiltinType::RvvFloat32m1x2:
case clang::BuiltinType::RvvFloat32m1x3:
case clang::BuiltinType::RvvFloat32m1x4:
case clang::BuiltinType::RvvFloat32m1x5:
case clang::BuiltinType::RvvFloat32m1x6:
case clang::BuiltinType::RvvFloat32m1x7:
case clang::BuiltinType::RvvFloat32m1x8:
case clang::BuiltinType::RvvFloat32m2x2:
case clang::BuiltinType::RvvFloat32m2x3:
case clang::BuiltinType::RvvFloat32m2x4:
case clang::BuiltinType::RvvFloat32m4x2:
case clang::BuiltinType::RvvFloat64m1x2:
case clang::BuiltinType::RvvFloat64m1x3:
case clang::BuiltinType::RvvFloat64m1x4:
case clang::BuiltinType::RvvFloat64m1x5:
case clang::BuiltinType::RvvFloat64m1x6:
case clang::BuiltinType::RvvFloat64m1x7:
case clang::BuiltinType::RvvFloat64m1x8:
case clang::BuiltinType::RvvFloat64m2x2:
case clang::BuiltinType::RvvFloat64m2x3:
case clang::BuiltinType::RvvFloat64m2x4:
case clang::BuiltinType::RvvFloat64m4x2:
break; break;
// WebAssembly builtin types. // WebAssembly builtin types.
case clang::BuiltinType::WasmExternRef: case clang::BuiltinType::WasmExternRef:
break; break;
case clang::BuiltinType::IncompleteMatrixIdx: case clang::BuiltinType::IncompleteMatrixIdx:
break; break;
▲ Show 20 Lines • Show All 4,984 Lines • Show Last 20 Lines