[clang-tidy] Fix false positive in `readability-named-parameter` for defaulted out-of-line special member functions

[AMS21]

Summary

This fixes llvm#63056

[PiotrZSL]

LGTM

[AMS21]

Great, would someone be so kind and push this on my behalf :)

clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp

void NamedParameterCheck::check(const MatchFinder::MatchResult &Result) {
   const SourceManager &SM = *Result.SourceManager;
   const auto *Function = Result.Nodes.getNodeAs<FunctionDecl>("decl");
   SmallVector<std::pair<const FunctionDecl *, unsigned>, 4> UnnamedParams;
 
   // Ignore declarations without a definition if we're not dealing with an
   // overriden method.
   const FunctionDecl *Definition = nullptr;
   if ((!Function->isDefined(Definition) || Function->isDefaulted() ||
-       Function->isDeleted()) &&
+       Definition->isDefaulted() || Function->isDeleted()) &&
       (!isa<CXXMethodDecl>(Function) ||
        cast<CXXMethodDecl>(Function)->size_overridden_methods() == 0))
     return;
 
   // TODO: Handle overloads.
   // TODO: We could check that all redeclarations use the same name for
   //       arguments in the same position.
   for (unsigned I = 0, E = Function->getNumParams(); I != E; ++I) {

clang-tools-extra/docs/ReleaseNotes.rst

- Improved :doc:`readability-magic-numbers
   <clang-tidy/checks/readability/magic-numbers>` check, now allows for
   magic numbers in type aliases such as ``using`` and ``typedef`` declarations if
   the new ``IgnoreTypeAliases`` option is set to true.
 
 - Fixed a false positive in :doc:`readability-misleading-indentation
   <clang-tidy/checks/readability/misleading-indentation>` check when warning would
   be unnecessarily emitted for template dependent ``if constexpr``.
 
+- Fixed a false positive in :doc:`readability-named-parameter
+  <clang-tidy/checks/readability/named-parameter>` for defaulted out-of-line
+  special member functions.
+
 - Fixed incorrect fixes in :doc:`readability-redundant-declaration
   <clang-tidy/checks/readability/redundant-declaration>` check when linkage
   (like ``extern "C"``) is explicitly specified.
 
 - Improved :doc:`readability-redundant-string-cstr
   <clang-tidy/checks/readability/redundant-string-cstr>` check to recognise
   unnecessary ``std::string::c_str()`` and ``std::string::data()`` calls in
   arguments to ``std::print``, ``std::format`` or other functions listed in

clang-tools-extra/test/clang-tidy/checkers/readability/named-parameter.cpp

 typedef decltype(nullptr) nullptr_t;
 }
 
 void f(std::nullptr_t) {}
 
 typedef void (F)(int);
 F f;
 void f(int x) {}
+
+namespace issue_63056
+{
+  struct S {
+    S(const S&);
+    S(S&&);
+
+    S& operator=(const S&);
+    S& operator=(S&&);
+  };
+
+  S::S(const S&) = default;
+  S::S(S&&) = default;
+
+  S& S::operator=(const S&) = default;
+  S& S::operator=(S&&) = default;
+} // namespace issue_63056