Page MenuHomePhabricator

AMS21 (André Schackier)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 26 2023, 8:08 AM (10 w, 5 d)

Recent Activity

Sun, May 28

AMS21 updated the diff for D148697: [clang-tidy] Add more checks for functions which should be noexcept.

Removed unrelated change

Sun, May 28, 7:04 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D148697: [clang-tidy] Add more checks for functions which should be noexcept.

Rename cppcoreguidelines-noexcept-move-constructor to cppcoreguidelines-noexcept-move-operations

Sun, May 28, 7:02 AM · Restricted Project, Restricted Project
AMS21 added a comment to D148697: [clang-tidy] Add more checks for functions which should be noexcept.

Bumping to ask for reviews

Sun, May 28, 5:57 AM · Restricted Project, Restricted Project

Apr 30 2023

AMS21 retitled D148697: [clang-tidy] Add more checks for functions which should be noexcept from [clang-tidy] Handle more cases of functions which should always be noexcept to [clang-tidy] Add more checks for functions which should be noexcept.
Apr 30 2023, 12:56 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D148697: [clang-tidy] Add more checks for functions which should be noexcept.

Split the changes into 2 new checks and added cppcoreguidelines aliases for all of them.

Apr 30 2023, 12:50 AM · Restricted Project, Restricted Project

Apr 22 2023

AMS21 added a comment to D148318: [clang-tidy] Add `performance-avoid-endl` check.

If someone could be so kind as to push this on my behalf, it would be greatly appreciated

Apr 22 2023, 12:18 AM · Restricted Project, Restricted Project

Apr 20 2023

AMS21 added inline comments to D148318: [clang-tidy] Add `performance-avoid-endl` check.
Apr 20 2023, 4:44 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Implement suggested changes.

Apr 20 2023, 4:43 AM · Restricted Project, Restricted Project

Apr 19 2023

AMS21 added a comment to D148697: [clang-tidy] Add more checks for functions which should be noexcept.

Well first of all thanks for the feedback. I agree not renaming a check which is already used and splitting each special case into it's own check seems like the easier and better way to go.

Apr 19 2023, 12:12 PM · Restricted Project, Restricted Project
AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Minor code cleanup

Apr 19 2023, 4:51 AM · Restricted Project, Restricted Project
AMS21 requested review of D148697: [clang-tidy] Add more checks for functions which should be noexcept.
Apr 19 2023, 3:00 AM · Restricted Project, Restricted Project

Apr 17 2023

AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Fix docs

Apr 17 2023, 12:42 PM · Restricted Project, Restricted Project
AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Handle the function calling case

Apr 17 2023, 12:41 PM · Restricted Project, Restricted Project
AMS21 updated the summary of D148318: [clang-tidy] Add `performance-avoid-endl` check.
Apr 17 2023, 12:35 AM · Restricted Project, Restricted Project
AMS21 added a comment to D148318: [clang-tidy] Add `performance-avoid-endl` check.

I've also notices that we don't handle this case

std::endl(std::cout);
Apr 17 2023, 12:22 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Remove std::ends from the check

Apr 17 2023, 12:20 AM · Restricted Project, Restricted Project

Apr 15 2023

AMS21 added inline comments to D148318: [clang-tidy] Add `performance-avoid-endl` check.
Apr 15 2023, 3:11 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Implement suggested fixes

Apr 15 2023, 3:10 AM · Restricted Project, Restricted Project

Apr 14 2023

AMS21 retitled D148318: [clang-tidy] Add `performance-avoid-endl` check from [clang-tidy] Add `performance-dont-use-endl` check to [clang-tidy] Add `performance-avoid-endl` check.
Apr 14 2023, 7:18 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D148318: [clang-tidy] Add `performance-avoid-endl` check.

Rename to performance-avoid-endl

Apr 14 2023, 7:18 AM · Restricted Project, Restricted Project
AMS21 added a comment to D148318: [clang-tidy] Add `performance-avoid-endl` check.

This check is mostly working. Added notes about problems I know about.

Apr 14 2023, 3:19 AM · Restricted Project, Restricted Project
AMS21 requested review of D148318: [clang-tidy] Add `performance-avoid-endl` check.
Apr 14 2023, 3:14 AM · Restricted Project, Restricted Project

Apr 11 2023

AMS21 added a comment to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

I'm fine with pushing this change, but since I don't have commit access someone would need to commit this for me

Apr 11 2023, 11:12 PM · Restricted Project, Restricted Project

Apr 3 2023

AMS21 added a comment to D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`.

Now I would kindly as for someone to commit this on my behalf.

Apr 3 2023, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
AMS21 updated the diff for D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`.

Remove unneccesary braces

Apr 3 2023, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
AMS21 added a comment to D147376: [clang-tidy] Small refactor for ExceptionAnalyzer.

LGTM.

Apr 3 2023, 11:14 PM · Restricted Project, Restricted Project
AMS21 added a comment to D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs.

LGTM, will you commit this or want someone else to commit this ?

Apr 3 2023, 11:13 PM · Restricted Project, Restricted Project
AMS21 updated the diff for D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs.

Implement suggested way of checking for anonymous structs
Add a new more tests

Apr 3 2023, 9:39 AM · Restricted Project, Restricted Project

Apr 2 2023

AMS21 added inline comments to D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs.
Apr 2 2023, 4:11 AM · Restricted Project, Restricted Project
AMS21 requested review of D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs.
Apr 2 2023, 4:08 AM · Restricted Project, Restricted Project

Apr 1 2023

AMS21 requested review of D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`.
Apr 1 2023, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
AMS21 requested review of D147376: [clang-tidy] Small refactor for ExceptionAnalyzer.
Apr 1 2023, 5:11 AM · Restricted Project, Restricted Project

Mar 30 2023

AMS21 updated the summary of D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 30 2023, 11:14 PM · Restricted Project, Restricted Project
AMS21 added inline comments to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 30 2023, 11:13 PM · Restricted Project, Restricted Project
AMS21 updated the diff for D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Fixed docs and cleanup tests a bit

Mar 30 2023, 11:13 PM · Restricted Project, Restricted Project
AMS21 added inline comments to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 30 2023, 9:18 AM · Restricted Project, Restricted Project
AMS21 added inline comments to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 30 2023, 9:04 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Implement review suggestions

Mar 30 2023, 9:03 AM · Restricted Project, Restricted Project

Mar 29 2023

AMS21 updated the summary of D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 29 2023, 10:54 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Use llvm::DenseMap instead of std::map
Add some more test cases

Mar 29 2023, 10:46 AM · Restricted Project, Restricted Project
AMS21 added inline comments to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 29 2023, 10:14 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Sprinkle some more const

Mar 29 2023, 10:11 AM · Restricted Project, Restricted Project
AMS21 added a comment to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Try refactoring code a lite bit, check suggestions, add tests for typedefs, and inheritance from template type.

Mar 29 2023, 9:55 AM · Restricted Project, Restricted Project
AMS21 updated the diff for D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Move functionality to a seperate file
Also the noexcept move constrcutor check now only runs with exceptions enabled like other checks.

Mar 29 2023, 9:54 AM · Restricted Project, Restricted Project

Mar 28 2023

AMS21 updated the diff for D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

Implemented suggested fixes from reviews

Mar 28 2023, 7:50 AM · Restricted Project, Restricted Project

Mar 27 2023

AMS21 added a comment to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.

@PiotrZSL thanks for the quick response.

Mar 27 2023, 5:07 AM · Restricted Project, Restricted Project

Mar 26 2023

AMS21 requested review of D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Mar 26 2023, 11:08 AM · Restricted Project, Restricted Project