Page MenuHomePhabricator
People eugene

eugene (Eugene Zemtsov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2017, 2:00 PM (135 w, 3 d)

Recent Activity
View All

May 21 2019

eugene accepted D62168: [DynamicLoader] Make sure we always set the rendezvous breakpoint.

Makes sense to me.

May 21 2019, 10:45 AM · Restricted Project, Restricted Project
eugene added a reviewer for D62168: [DynamicLoader] Make sure we always set the rendezvous breakpoint: labath.
May 21 2019, 10:45 AM · Restricted Project, Restricted Project

Apr 30 2018

eugene committed rL331242: Fix type_lookup test to make buildbots happy.
Fix type_lookup test to make buildbots happy
Apr 30 2018, 8:09 PM

Apr 16 2018

eugene committed rL330163: Make sure deleting all breakpoints clears their sites first.
Make sure deleting all breakpoints clears their sites first
Apr 16 2018, 3:30 PM
eugene closed D45554: Make sure deleting all breakpoints clears their sites first.
Apr 16 2018, 3:30 PM
eugene added a comment to D45554: Make sure deleting all breakpoints clears their sites first.

If nobody minds, I'd appreciate if somebody would accept this patch.

Apr 16 2018, 12:04 PM

Apr 13 2018

eugene added a comment to D45554: Make sure deleting all breakpoints clears their sites first.

Well, I agree that breakpoints, locations and sites could benefit from ownership refactoring.
shared_ptr cycles are bad.
Let's discuss it at lldb-dev.
Meanwhile I think it's still ok to fix this bug right now, by doing what has already been done in other places.

Apr 13 2018, 2:17 PM

Apr 12 2018

eugene added a comment to D45554: Make sure deleting all breakpoints clears their sites first.

There is an ownership cycle between BreakpointSite::m_owners and BreakpointLocation::m_bp_site_sp.
We should probably make m_owners a collection of weak references.
But currently most of the code just works it around by calling Breakpoint::ClearAllBreakpointSites() before deleting a breakpoint.

Apr 12 2018, 8:00 PM
eugene updated the diff for D45554: Make sure deleting all breakpoints clears their sites first.

Got rid of the printf in the test

Apr 12 2018, 8:00 PM
eugene added inline comments to D45554: Make sure deleting all breakpoints clears their sites first.
Apr 12 2018, 10:21 AM
eugene updated the diff for D45554: Make sure deleting all breakpoints clears their sites first.

add comment to the test

Apr 12 2018, 10:21 AM

Apr 11 2018

eugene created D45554: Make sure deleting all breakpoints clears their sites first.
Apr 11 2018, 8:28 PM

Mar 13 2018

eugene committed rL327472: Disable test debuglineinfo-path on powerpc.
Disable test debuglineinfo-path on powerpc
Mar 13 2018, 7:12 PM
eugene committed rL327469: grep for global functions only.
grep for global functions only
Mar 13 2018, 6:09 PM
eugene committed rL327466: Add extra output/check to debug clang-ppc64be-linux test failure.
Add extra output/check to debug clang-ppc64be-linux test failure
Mar 13 2018, 5:17 PM
eugene committed rL327458: Disable optimizations in debuglineinfo-path test.
Disable optimizations in debuglineinfo-path test
Mar 13 2018, 3:52 PM
eugene committed rL327449: Remove explicit triple and data layout from the test.
Remove explicit triple and data layout from the test
Mar 13 2018, 2:12 PM
eugene committed rL327443: Fix debuglineinfo-path.ll.
Fix debuglineinfo-path.ll
Mar 13 2018, 1:12 PM
eugene committed rL327441: Temporary disable debuglineinfo-path.ll to fix build.
Temporary disable debuglineinfo-path.ll to fix build
Mar 13 2018, 12:51 PM
eugene committed rL327430: Handle mixed-OS paths in DWARF reader.
Handle mixed-OS paths in DWARF reader
Mar 13 2018, 10:57 AM
eugene closed D44290: Handle mixed-OS paths in DWARF reader.
Mar 13 2018, 10:57 AM

Mar 11 2018

eugene added a comment to D44290: Handle mixed-OS paths in DWARF reader.
In D44290#1034041, @zturner wrote:

Is there some kind of field we can write inside the DWARF that can tell us what path syntax to assume?

As far as I know DWARF doesn't have a field like this.

Mar 11 2018, 7:56 PM

Mar 10 2018

eugene added a reviewer for D44290: Handle mixed-OS paths in DWARF reader: aprantl.
Mar 10 2018, 2:53 AM
eugene updated the diff for D44290: Handle mixed-OS paths in DWARF reader.

Added a test

Mar 10 2018, 2:52 AM

Mar 9 2018

eugene updated the diff for D44290: Handle mixed-OS paths in DWARF reader.

clang-format

Mar 9 2018, 1:31 AM

Mar 8 2018

eugene created D44290: Handle mixed-OS paths in DWARF reader.
Mar 8 2018, 11:58 PM

Mar 7 2018

eugene committed rL326987: Build LLVMDemangle from build_symbolizer.sh.
Build LLVMDemangle from build_symbolizer.sh
Mar 7 2018, 8:37 PM
eugene committed rCRT326987: Build LLVMDemangle from build_symbolizer.sh.
Build LLVMDemangle from build_symbolizer.sh
Mar 7 2018, 8:37 PM
eugene committed rCRT326983: Add Demangle lib into internalization list.
Add Demangle lib into internalization list
Mar 7 2018, 7:01 PM
eugene committed rL326983: Add Demangle lib into internalization list.
Add Demangle lib into internalization list
Mar 7 2018, 7:01 PM
eugene committed rL326964: Fix build broken by r326959.
Fix build broken by r326959
Mar 7 2018, 4:09 PM
eugene committed rL326959: Use itaniumDemangle in llvm-symbolizer.
Use itaniumDemangle in llvm-symbolizer
Mar 7 2018, 3:10 PM
eugene closed D44192: Proper handling of Itanium mangled names in LLVMSymbolizer on Windows.
Mar 7 2018, 3:10 PM
eugene updated the diff for D44192: Proper handling of Itanium mangled names in LLVMSymbolizer on Windows.

Always using itaniumDemangle

Mar 7 2018, 11:51 AM
eugene created D44192: Proper handling of Itanium mangled names in LLVMSymbolizer on Windows.
Mar 7 2018, 1:32 AM

Feb 8 2018

eugene accepted D43076: llgs-test: Parse and store register info recieved from lldb-server.
Feb 8 2018, 10:50 AM

Feb 7 2018

eugene committed rL324558: Deactivate TestTargetSymbolsBuildidCase if host is windows.
Deactivate TestTargetSymbolsBuildidCase if host is windows
Feb 7 2018, 7:09 PM

Feb 6 2018

eugene committed rL324380: More correct handling of error cases C++ name parser.
More correct handling of error cases C++ name parser
Feb 6 2018, 11:06 AM
eugene closed D42939: More correct handling of error cases C++ name parser.
Feb 6 2018, 11:06 AM
eugene added inline comments to D42939: More correct handling of error cases C++ name parser.
Feb 6 2018, 11:06 AM

Feb 5 2018

eugene updated the diff for D42939: More correct handling of error cases C++ name parser.

fix formating

Feb 5 2018, 4:50 PM
eugene created D42939: More correct handling of error cases C++ name parser.
Feb 5 2018, 4:49 PM
eugene committed rL324288: Disable test_restart_bug failing on Android.
Disable test_restart_bug failing on Android
Feb 5 2018, 3:34 PM

Jan 25 2018

eugene accepted D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo.
Jan 25 2018, 9:39 AM

Jan 24 2018

eugene added a comment to D31451: New C++ function name parsing logic.

Greg, this name is amazing. My c++filt refuses to demangle it. We can probably give up on parsing C++ names if they're longer than 1000 characters or something.

Jan 24 2018, 4:37 PM
eugene added inline comments to D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo.
Jan 24 2018, 11:19 AM

Jan 10 2018

eugene committed rL322251: Advanced guessing of rendezvous breakpoint (resubmit).
Advanced guessing of rendezvous breakpoint (resubmit)
Jan 10 2018, 7:47 PM
eugene committed rL322229: Revert "Advanced guessing of rendezvous breakpoint".
Revert "Advanced guessing of rendezvous breakpoint"
Jan 10 2018, 2:27 PM
eugene committed rL322209: Advanced guessing of rendezvous breakpoint.
Advanced guessing of rendezvous breakpoint
Jan 10 2018, 11:06 AM
eugene closed D41533: Advanced guessing of rendezvous breakpoint.
Jan 10 2018, 11:06 AM · Restricted Project

Jan 9 2018

eugene updated the diff for D41533: Advanced guessing of rendezvous breakpoint.

Addressing code review comments. Switching from manual symbol resolution to the appropriate overload of CreateBreakpoint.

Jan 9 2018, 8:05 PM · Restricted Project
eugene added inline comments to D41533: Advanced guessing of rendezvous breakpoint.
Jan 9 2018, 8:04 PM · Restricted Project

Jan 8 2018

eugene updated the diff for D41533: Advanced guessing of rendezvous breakpoint.

Fix tests.

Jan 8 2018, 4:49 PM · Restricted Project

Dec 22 2017

eugene updated the diff for D41533: Advanced guessing of rendezvous breakpoint.

Don't set entry breakpoint if rendezvous breakpoint was set right after launch.

Dec 22 2017, 6:57 PM · Restricted Project
eugene added inline comments to D41533: Advanced guessing of rendezvous breakpoint.
Dec 22 2017, 6:37 PM · Restricted Project
eugene updated the diff for D41533: Advanced guessing of rendezvous breakpoint.
  • Addressing review comments
  • Making sure all tests pass on Linux
  • Reformating
Dec 22 2017, 6:31 PM · Restricted Project

Dec 21 2017

eugene updated the diff for D41533: Advanced guessing of rendezvous breakpoint.
Dec 21 2017, 7:31 PM · Restricted Project
eugene updated the diff for D41533: Advanced guessing of rendezvous breakpoint.
Dec 21 2017, 7:25 PM · Restricted Project
eugene created D41533: Advanced guessing of rendezvous breakpoint.
Dec 21 2017, 7:07 PM · Restricted Project

Dec 14 2017

eugene accepted D41066: llgs-tests: Make addition of new tests easier.
Dec 14 2017, 10:19 AM

Dec 11 2017

eugene accepted D41067: llgs-tests: Add support for "exit" stop-reply packets.
Dec 11 2017, 8:27 PM
eugene accepted D41069: NPL: Clean up handling of inferior exit.
Dec 11 2017, 1:40 PM

Dec 8 2017

eugene accepted D41008: MainLoop: avoid infinite loop when pty slave gets closed.
Dec 8 2017, 1:25 PM

Nov 16 2017

eugene committed rL318504: Fix LLDB build..
Fix LLDB build.
Nov 16 2017, 7:29 PM

Nov 8 2017

eugene accepted D39790: llgs-tests: Replace the "log+return false" pattern with llvm::Error.
Nov 8 2017, 11:25 AM

Nov 7 2017

eugene added inline comments to D39733: Simplify NativeProcessProtocol::GetArchitecture/GetByteOrder.
Nov 7 2017, 5:07 PM
eugene added inline comments to D39733: Simplify NativeProcessProtocol::GetArchitecture/GetByteOrder.
Nov 7 2017, 12:12 PM

Oct 23 2017

eugene accepted D38938: Logging: provide a way to safely disable logging in a forked process.
Oct 23 2017, 10:08 AM

Oct 17 2017

eugene accepted D38938: Logging: provide a way to safely disable logging in a forked process.
Oct 17 2017, 9:21 PM
eugene accepted D39010: lldb-server tests: Propagate environment variables (pr34192).
Oct 17 2017, 9:20 PM

Oct 16 2017

eugene added a comment to D38938: Logging: provide a way to safely disable logging in a forked process.

DisableUnlocked methods makes me uneasy.
Maybe we can take a log lock before forking and then properly release it in both parent and child processes?

Oct 16 2017, 1:48 PM

Oct 9 2017

eugene committed rL315246: Fix LLDB build for Android..
Fix LLDB build for Android.
Oct 9 2017, 3:43 PM
eugene closed D38701: Fix LLDB build for Android. by committing rL315246: Fix LLDB build for Android..
Oct 9 2017, 3:43 PM
eugene created D38701: Fix LLDB build for Android..
Oct 9 2017, 12:01 PM

Oct 5 2017

eugene committed rL315008: Enable breakpoints and read/write GPRs for ppc64le.
Enable breakpoints and read/write GPRs for ppc64le
Oct 5 2017, 12:45 PM
eugene closed D38323: Enable breakpoints and read/write GPRs for ppc64le by committing rL315008: Enable breakpoints and read/write GPRs for ppc64le.
Oct 5 2017, 12:45 PM

Sep 28 2017

eugene committed rL314488: Fix Android remote debugging tests running on Windows.
Fix Android remote debugging tests running on Windows
Sep 28 2017, 8:27 PM
eugene committed rL314487: Fix compilation error.
Fix compilation error
Sep 28 2017, 8:16 PM

Sep 25 2017

eugene committed rL314127: Use socketpair on all Unix platforms.
Use socketpair on all Unix platforms
Sep 25 2017, 10:42 AM
eugene closed D33213: Use socketpair on all Unix platforms by committing rL314127: Use socketpair on all Unix platforms.
Sep 25 2017, 10:42 AM

Sep 19 2017

eugene committed rL313726: Signal polling is supported with pselect (re-land r313704 without a Windows….
Signal polling is supported with pselect (re-land r313704 without a Windows…
Sep 19 2017, 11:58 PM
eugene committed rL313707: Rollback r313704 because of the Windows build break.
Rollback r313704 because of the Windows build break
Sep 19 2017, 6:59 PM
eugene committed rL313704: Signal polling is supported with pselect.
Signal polling is supported with pselect
Sep 19 2017, 5:41 PM

Sep 18 2017

eugene accepted D33213: Use socketpair on all Unix platforms.

I did mark it Accepted.

Sep 18 2017, 11:06 AM

Sep 15 2017

eugene committed rL313437: Check availability of accept4 in C++ instad of C code..
Check availability of accept4 in C++ instad of C code.
Sep 15 2017, 8:00 PM
eugene committed rL313436: More precise c library feature detection for Android..
More precise c library feature detection for Android.
Sep 15 2017, 7:22 PM

Sep 12 2017

eugene committed rL313113: Fix test_attach_to_process_from_different_dir_by_id test on Windows.
Fix test_attach_to_process_from_different_dir_by_id test on Windows
Sep 12 2017, 7:45 PM

Sep 1 2017

eugene committed rL312389: Disable 64bit file position on old 32 bit Androids..
Disable 64bit file position on old 32 bit Androids.
Sep 1 2017, 4:14 PM
eugene closed D37314: [CMake] Disable 64bit file position on old 32 bit Androids by committing rL312389: Disable 64bit file position on old 32 bit Androids..
Sep 1 2017, 4:14 PM
eugene added a comment to D37314: [CMake] Disable 64bit file position on old 32 bit Androids.

Could somebody please take another look at this change? It would help us fix an internal build with the latest NDK.

Sep 1 2017, 12:04 PM

Aug 31 2017

eugene retitled D37314: [CMake] Disable 64bit file position on old 32 bit Androids from Disable 64bit file position on old 32 bit Androids to [CMake] Disable 64bit file position on old 32 bit Androids.
Aug 31 2017, 1:43 PM

Aug 30 2017

eugene updated the diff for D37314: [CMake] Disable 64bit file position on old 32 bit Androids.
Aug 30 2017, 4:27 PM
eugene added a comment to D37314: [CMake] Disable 64bit file position on old 32 bit Androids.

Aah, ok. So https://reviews.llvm.org/D35648 doesn't cover your use case. Can we just say "AND (NOT ANDROID)" instead of a new CMake option?

Sure we can. I just wanted it to be a bit more flexible.

Aug 30 2017, 3:32 PM
eugene added a comment to D37314: [CMake] Disable 64bit file position on old 32 bit Androids.
In D37314#857186, @pirama wrote:

https://reviews.llvm.org/D35648 does something similar. If this is just for building compiler-rt runtimes, we can defer to that patch. This way we can just remove the exception for Android once the NDK defaults to something past API level 24, rather than support a build configuration for ever.

Aug 30 2017, 3:16 PM
eugene updated the diff for D37314: [CMake] Disable 64bit file position on old 32 bit Androids.

Added comment

Aug 30 2017, 3:10 PM
eugene added reviewers for D37314: [CMake] Disable 64bit file position on old 32 bit Androids: chapuni, beanz, pirama.
Aug 30 2017, 2:56 PM
eugene created D37314: [CMake] Disable 64bit file position on old 32 bit Androids.
Aug 30 2017, 2:55 PM
eugene committed rL312151: Now a ppc64le binary is correctly detected:.
Now a ppc64le binary is correctly detected:
Aug 30 2017, 11:38 AM
eugene closed D36804: Add initial support to PowerPC64 little endian (POWER8) by committing rL312151: Now a ppc64le binary is correctly detected:.
Aug 30 2017, 11:38 AM

Jul 31 2017

eugene accepted D33213: Use socketpair on all Unix platforms.

LGTM. Test run on Linux is clear. I also see a bit of perf bump.

Jul 31 2017, 9:32 PM