User Details
- User Since
- Feb 15 2017, 2:00 PM (210 w, 18 h)
May 21 2019
Makes sense to me.
Apr 30 2018
Apr 16 2018
If nobody minds, I'd appreciate if somebody would accept this patch.
Apr 13 2018
Well, I agree that breakpoints, locations and sites could benefit from ownership refactoring.
shared_ptr cycles are bad.
Let's discuss it at lldb-dev.
Meanwhile I think it's still ok to fix this bug right now, by doing what has already been done in other places.
Apr 12 2018
There is an ownership cycle between BreakpointSite::m_owners and BreakpointLocation::m_bp_site_sp.
We should probably make m_owners a collection of weak references.
But currently most of the code just works it around by calling Breakpoint::ClearAllBreakpointSites() before deleting a breakpoint.
Got rid of the printf in the test
add comment to the test
Apr 11 2018
Mar 13 2018
Mar 11 2018
As far as I know DWARF doesn't have a field like this.
Mar 10 2018
Added a test
Mar 9 2018
clang-format
Mar 8 2018
Mar 7 2018
Always using itaniumDemangle
Feb 8 2018
Feb 7 2018
Feb 6 2018
Feb 5 2018
fix formating
Jan 25 2018
Jan 24 2018
Greg, this name is amazing. My c++filt refuses to demangle it. We can probably give up on parsing C++ names if they're longer than 1000 characters or something.
Jan 10 2018
Jan 9 2018
Addressing code review comments. Switching from manual symbol resolution to the appropriate overload of CreateBreakpoint.
Jan 8 2018
Fix tests.
Dec 22 2017
Don't set entry breakpoint if rendezvous breakpoint was set right after launch.
- Addressing review comments
- Making sure all tests pass on Linux
- Reformating
Dec 21 2017
Dec 14 2017
Dec 11 2017
Dec 8 2017
Nov 16 2017
Nov 8 2017
Nov 7 2017
Oct 23 2017
Oct 17 2017
Oct 16 2017
DisableUnlocked methods makes me uneasy.
Maybe we can take a log lock before forking and then properly release it in both parent and child processes?
Oct 9 2017
Oct 5 2017
Sep 28 2017
Sep 25 2017
Sep 19 2017
Sep 18 2017
I did mark it Accepted.
Sep 15 2017
Sep 12 2017
Sep 1 2017
Could somebody please take another look at this change? It would help us fix an internal build with the latest NDK.
Aug 31 2017
Aug 30 2017
Aah, ok. So https://reviews.llvm.org/D35648 doesn't cover your use case. Can we just say "AND (NOT ANDROID)" instead of a new CMake option?
Sure we can. I just wanted it to be a bit more flexible.
Added comment
Jul 31 2017
LGTM. Test run on Linux is clear. I also see a bit of perf bump.