Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152069

[1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits
ClosedPublic
Actions

Authored by eopXD on Jun 3 2023, 10:49 AM.

Details

Reviewers
craig.topper
kito-cheng
rogfer01
frasercrmck
aaron.ballman
erichkeane
Commits
rGbf87fcb799aa: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits
Summary

This patch-set aims to expand all variants of the RVV segment
load/store intrinsics. The first commit expands the limitation of
builtin types from 256 to 512. The following patches expands the
full variants one-by-one.

The next patch introduces a number of new RVV tuple types and lets the
total of builtin types exceed the current limit (256). This patch
attempts to increase the bits used so we can continue to expand new
builtin types.

Diff Detail

Event Timeline

eopXD created this revision.Jun 3 2023, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 10:49 AM
eopXD requested review of this revision.Jun 3 2023, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 10:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eopXD added a child revision: D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types.Jun 3 2023, 10:56 AM
eopXD edited the summary of this revision. (Show Details)Jun 3 2023, 11:04 AM
eopXD mentioned this in D152071: [3/11][Clang][RISCV] Expand all variants for unit stride segment load.Jun 3 2023, 11:07 AM
eopXD mentioned this in D152072: [4/11][Clang][RISCV] Expand all variants for unit stride segment store.
eopXD mentioned this in D152073: [5/11][Clang][RISCV] Expand all variants for unit stride fault-first segment load.
eopXD mentioned this in D152074: [6/11][Clang][RISCV] Expand all variants for strided segment load.
eopXD mentioned this in D152075: [7/11][Clang][RISCV] Expand all variants for strided segment store.
eopXD mentioned this in D152076: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load.
eopXD mentioned this in D152077: [9/11][Clang][RISCV] Expand all variants for indexed strided segment store.
eopXD mentioned this in D152078: [10/11][Clang][RISCV] Expand all variants for vget on tuple types.
eopXD mentioned this in D152079: [11/11][Clang][RISCV] Expand all variants for vset on tuple types.
Harbormaster completed remote builds in B236385: Diff 528121.Jun 3 2023, 11:49 AM
craig.topper added reviewers: aaron.ballman, erichkeane.Jun 5 2023, 4:34 PM
erichkeane added inline comments.Jun 6 2023, 6:40 AM
clang/include/clang/AST/Type.h
1652–1653

It looks like the largest of the Bitfields in the union uses 32 bits (an unsigned), so this doesn't grow anything as far as I can tell, right?

Based on your requirements, I'd rather we do 1 of 2 things;

1- Make this 9 bits (or 10, or whatever is NECESSARY).
2- Just make this an unsigned, which doesn't grow the size, and put a comment on it that we can steal bits from it if needed.

eopXD updated this revision to Diff 529151.Jun 6 2023, 9:52 PM
eopXD marked an inline comment as done.

Address comment from Erich.

eopXD retitled this revision from [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 16 bits to [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits.Jun 6 2023, 9:52 PM
eopXD edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B237165: Diff 529151.Jun 6 2023, 11:35 PM
erichkeane accepted this revision.Jun 7 2023, 6:44 AM
This revision is now accepted and ready to land.Jun 7 2023, 6:44 AM
eopXD updated this revision to Diff 529640.Jun 8 2023, 9:39 AM

Rebase upon landing of D152429.

This revision was landed with ongoing or failed builds.Jun 8 2023, 9:41 AM
Closed by commit rGbf87fcb799aa: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits (authored by eopXD). · Explain Why
This revision was automatically updated to reflect the committed changes.
eopXD added a commit: rGbf87fcb799aa: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits.
Harbormaster completed remote builds in B237528: Diff 529640.Jun 8 2023, 12:36 PM
eopXD mentioned this in rG0e9548bbc5e5: [3/11][Clang][RISCV] Expand all variants for unit stride segment load.Jun 13 2023, 11:48 PM
eopXD mentioned this in rGb59ca492d98d: [4/11][Clang][RISCV] Expand all variants for unit stride segment store.Jun 13 2023, 11:51 PM
eopXD mentioned this in rGff6f7902f964: [5/11][Clang][RISCV] Expand all variants for unit stride fault-first segment….Jun 14 2023, 12:05 AM
eopXD mentioned this in rG06c0b0ac5a54: [6/11][Clang][RISCV] Expand all variants for strided segment load.
eopXD mentioned this in rG91b90e0ea0ec: [7/11][Clang][RISCV] Expand all variants for strided segment store.
eopXD mentioned this in rG9588b18969a2: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load.Jun 14 2023, 12:07 AM
eopXD mentioned this in rG9828c8959125: [9/11][Clang][RISCV] Expand all variants for indexed strided segment store.
eopXD mentioned this in rGd1b6b893ed57: [10/11][Clang][RISCV] Expand all variants for vget on tuple types.
eopXD mentioned this in rG804306b38215: [11/11][Clang][RISCV] Expand all variants for vset on tuple types.Jun 14 2023, 12:10 AM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
AST/
2 lines

Diff 529642

View Options

clang/include/clang/AST/Type.h

Loading...