This is an archive of the discontinued LLVM Phabricator instance.

[1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits
ClosedPublic

Authored by eopXD on Jun 3 2023, 10:49 AM.

Details

Summary

This patch-set aims to expand all variants of the RVV segment
load/store intrinsics. The first commit expands the limitation of
builtin types from 256 to 512. The following patches expands the
full variants one-by-one.

The next patch introduces a number of new RVV tuple types and lets the
total of builtin types exceed the current limit (256). This patch
attempts to increase the bits used so we can continue to expand new
builtin types.

Diff Detail

Event Timeline

eopXD created this revision.Jun 3 2023, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 10:49 AM
eopXD requested review of this revision.Jun 3 2023, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 10:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eopXD edited the summary of this revision. (Show Details)Jun 3 2023, 11:04 AM
erichkeane added inline comments.Jun 6 2023, 6:40 AM
clang/include/clang/AST/Type.h
1652–1653

It looks like the largest of the Bitfields in the union uses 32 bits (an unsigned), so this doesn't grow anything as far as I can tell, right?

Based on your requirements, I'd rather we do 1 of 2 things;

1- Make this 9 bits (or 10, or whatever is NECESSARY).
2- Just make this an unsigned, which doesn't grow the size, and put a comment on it that we can steal bits from it if needed.

eopXD updated this revision to Diff 529151.Jun 6 2023, 9:52 PM
eopXD marked an inline comment as done.

Address comment from Erich.

eopXD retitled this revision from [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 16 bits to [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits.Jun 6 2023, 9:52 PM
eopXD edited the summary of this revision. (Show Details)
erichkeane accepted this revision.Jun 7 2023, 6:44 AM
This revision is now accepted and ready to land.Jun 7 2023, 6:44 AM
eopXD updated this revision to Diff 529640.Jun 8 2023, 9:39 AM

Rebase upon landing of D152429.

This revision was landed with ongoing or failed builds.Jun 8 2023, 9:41 AM
This revision was automatically updated to reflect the committed changes.