This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][AsmParser][NFC] Get rid of custom default operand handlers.
ClosedPublic

Authored by kosarev on May 29 2023, 11:47 PM.

Details

Summary

Removes the need to add and remove them manually depending on whether
they are used in cvt*() functions. Also removes the compiler warnings
about unused handlers when it happens to be the case.

Part of https://github.com/llvm/llvm-project/issues/62629.

Diff Detail

Event Timeline

kosarev created this revision.May 29 2023, 11:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 11:47 PM
kosarev requested review of this revision.May 29 2023, 11:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 11:47 PM
kosarev updated this revision to Diff 526728.May 30 2023, 11:27 AM

Remove a now-unused comment.

@dp Ping for this patch and the rest of the chain.

kosarev edited reviewers, added: mbrkusanin; removed: dp.Jun 14 2023, 2:44 AM
arsenm accepted this revision.Jun 14 2023, 3:20 AM
This revision is now accepted and ready to land.Jun 14 2023, 3:20 AM