Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D151684

[AMDGPU][AsmParser][NFC] Immediate operand classes to derive from custom operands.
ClosedPublic
Actions

Authored by kosarev on May 29 2023, 11:40 PM.

Tags

Subscribers

View All 12 Subscribers

Details

Reviewers

dp
rampitec
arsenm
foad

Commits

rG9ad1a48ad77b: [AMDGPU][AsmParser][NFC] Immediate operand classes to derive from custom…

Summary

Removes unnecessary duplication in TableGen definitions.

Part of https://github.com/llvm/llvm-project/issues/62629.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kosarev created this revision.May 29 2023, 11:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 11:40 PM

Herald added subscribers: foad, kerbowa, hiraditya and 6 others. · View Herald Transcript

kosarev requested review of this revision.May 29 2023, 11:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 11:40 PM

Herald added subscribers: llvm-commits, wdng. · View Herald Transcript

kosarev added reviewers: dp, rampitec, arsenm, foad.May 29 2023, 11:50 PM

Herald added a subscriber: StephenFan. · View Herald TranscriptMay 29 2023, 11:50 PM

kosarev added a child revision: D151685: [AMDGPU][AsmParser][NFC] Specify parser methods directly in operand classes..May 29 2023, 11:50 PM

Harbormaster completed remote builds in B235219: Diff 526521.May 30 2023, 12:27 AM

LGTM.

This revision is now accepted and ready to land.Jun 4 2023, 9:04 AM

Closed by commit rG9ad1a48ad77b: [AMDGPU][AsmParser][NFC] Immediate operand classes to derive from custom… (authored by kosarev). · Explain WhyJun 5 2023, 4:56 AM

This revision was automatically updated to reflect the committed changes.

kosarev added a commit: rG9ad1a48ad77b: [AMDGPU][AsmParser][NFC] Immediate operand classes to derive from custom….

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

AMDGPU/

AMDGPUInstructions.td

25 lines

20 lines

Diff 528377

llvm/lib/Target/AMDGPU/AMDGPUInstructions.td

Loading...

llvm/lib/Target/AMDGPU/SIInstrInfo.td

Loading...