Page MenuHomePhabricator

mbrkusanin (Mirko Brkusanin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2019, 1:58 AM (175 w, 3 d)

Recent Activity

Today

mbrkusanin committed rG2208342c9bd8: [AMDGPU][GlobalISel] Always use VGPR bank for G_FCMP (authored by mbrkusanin).
[AMDGPU][GlobalISel] Always use VGPR bank for G_FCMP
Fri, Jul 1, 6:20 AM · Restricted Project, Restricted Project
mbrkusanin closed D128980: [AMDGPU][GlobalISel] Always use VGPR bank for G_FCMP.
Fri, Jul 1, 6:20 AM · Restricted Project, Restricted Project
mbrkusanin requested review of D128980: [AMDGPU][GlobalISel] Always use VGPR bank for G_FCMP.
Fri, Jul 1, 3:54 AM · Restricted Project, Restricted Project

Mon, Jun 20

mbrkusanin committed rG6cae753bf4ee: [AMDGPU][GlobalISel] Legalize G_FSUB for s16 (authored by mbrkusanin).
[AMDGPU][GlobalISel] Legalize G_FSUB for s16
Mon, Jun 20, 3:27 AM · Restricted Project, Restricted Project
mbrkusanin closed D128066: [AMDGPU][GlobalISel] Legalize G_FSUB for s16.
Mon, Jun 20, 3:27 AM · Restricted Project, Restricted Project

Fri, Jun 17

mbrkusanin requested review of D128066: [AMDGPU][GlobalISel] Legalize G_FSUB for s16.
Fri, Jun 17, 8:55 AM · Restricted Project, Restricted Project

Feb 11 2022

mbrkusanin committed rG5ff35ba8ae3c: [AMDGPU][GlobalISel] Fix insert point in FoldableFneg combine (authored by mbrkusanin).
[AMDGPU][GlobalISel] Fix insert point in FoldableFneg combine
Feb 11 2022, 3:12 AM
mbrkusanin closed D119459: [AMDGPU][GlobalISel] Fix insert point in FoldableFneg combine.
Feb 11 2022, 3:12 AM · Restricted Project

Feb 10 2022

mbrkusanin requested review of D119459: [AMDGPU][GlobalISel] Fix insert point in FoldableFneg combine.
Feb 10 2022, 9:59 AM · Restricted Project

Feb 3 2022

mbrkusanin requested review of D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel.
Feb 3 2022, 3:20 AM · Restricted Project

Feb 2 2022

mbrkusanin updated the diff for D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel.

Rebase

Feb 2 2022, 7:42 AM · Restricted Project
mbrkusanin updated the diff for D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.

Rebase

Feb 2 2022, 7:41 AM · Restricted Project
mbrkusanin updated the diff for D115945: [AMDGPU][GlobalISel] Eliminate cross regbank copies of constants .

Rebase

Feb 2 2022, 7:41 AM · Restricted Project
mbrkusanin updated the diff for D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

Rebase + Ping

Feb 2 2022, 7:41 AM · Restricted Project

Jan 26 2022

mbrkusanin added inline comments to D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel.
Jan 26 2022, 10:20 AM · Restricted Project
mbrkusanin updated the diff for D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel.
  • Refactor and updated isExtractHiElt function
  • Extracted work done in one iteration for selecting modifiers into a separate function so it can be used in selectVOP3NoMods. For same reason, parts that only look through instructions are separated and done before any code that selects source modifiers.
  • Added type checks in a lot of cases.
Jan 26 2022, 10:19 AM · Restricted Project
mbrkusanin added inline comments to D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.
Jan 26 2022, 10:17 AM · Restricted Project
mbrkusanin updated the diff for D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.
  • Fix handling of G_SHUFFLE_VECTOR
  • Handled case where low part of <2 x 16> could also be undef.
  • Added tests for new cases
Jan 26 2022, 10:16 AM · Restricted Project

Jan 20 2022

mbrkusanin added inline comments to D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.
Jan 20 2022, 2:40 AM · Restricted Project
mbrkusanin requested review of D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel.
Jan 20 2022, 2:34 AM · Restricted Project
mbrkusanin updated the diff for D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.

Refactor + updated comments

Jan 20 2022, 2:33 AM · Restricted Project
mbrkusanin updated the diff for D115945: [AMDGPU][GlobalISel] Eliminate cross regbank copies of constants .

Rebase

Jan 20 2022, 2:33 AM · Restricted Project
mbrkusanin updated the diff for D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

Rebase + Ping

Jan 20 2022, 2:33 AM · Restricted Project

Jan 14 2022

mbrkusanin updated the diff for D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.
  • Removed G_EXTRACT checks
  • Refactored parts of code dealing with setting OP_SEL_0 and OP_SEL_1 bits.
Jan 14 2022, 9:13 AM · Restricted Project

Dec 31 2021

mbrkusanin requested review of D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P.
Dec 31 2021, 5:17 AM · Restricted Project

Dec 24 2021

mbrkusanin updated the diff for D115945: [AMDGPU][GlobalISel] Eliminate cross regbank copies of constants .
Dec 24 2021, 9:09 AM · Restricted Project
mbrkusanin updated the diff for D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .
  • Added target check and covered G_FCONSTANT and G_IMPLICIT_DEF
Dec 24 2021, 9:08 AM · Restricted Project

Dec 17 2021

mbrkusanin updated the diff for D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

Removed combiner. Now only constants that have single use are handled here.
Combiner that handles constants with multiple uses is now: https://reviews.llvm.org/D115945

Dec 17 2021, 9:04 AM · Restricted Project
mbrkusanin requested review of D115945: [AMDGPU][GlobalISel] Eliminate cross regbank copies of constants .
Dec 17 2021, 9:04 AM · Restricted Project

Dec 16 2021

mbrkusanin added a comment to D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

Ping

Dec 16 2021, 3:05 AM · Restricted Project

Dec 2 2021

mbrkusanin updated the diff for D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

Clang-format + Rebase + Ping

Dec 2 2021, 2:24 AM · Restricted Project

Nov 29 2021

mbrkusanin committed rG0dd570ff56c5: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg…
Nov 29 2021, 7:29 AM
mbrkusanin committed rG5fe7fcd28e5e: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x)… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x)…
Nov 29 2021, 7:29 AM
mbrkusanin committed rG37c2a2201d68: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x)… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x)…
Nov 29 2021, 7:29 AM
mbrkusanin committed rGa7821692708c: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z) (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z)
Nov 29 2021, 7:29 AM
mbrkusanin committed rGe5e49a08f116: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) ->… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) ->…
Nov 29 2021, 7:29 AM
mbrkusanin closed D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin committed rGf7322925365c: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y…
Nov 29 2021, 7:28 AM
mbrkusanin closed D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin closed D98049: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), (fneg z)).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin committed rG895113621653: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x)… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x)…
Nov 29 2021, 7:28 AM
mbrkusanin committed rG881840fc268e: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z) (authored by mbrkusanin).
[AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z)
Nov 29 2021, 7:28 AM
mbrkusanin closed D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin closed D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin closed D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin closed D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Nov 29 2021, 7:28 AM · Restricted Project
mbrkusanin closed D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).
Nov 29 2021, 7:28 AM · Restricted Project

Nov 26 2021

mbrkusanin updated the diff for D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

I've considered this regbank combiner solution before but it was too late for D98040. Thankfully those cases are single use constants needed for offset for load/stores, a case which can be easily solved in RegBankSelect.

Nov 26 2021, 7:52 AM · Restricted Project

Nov 18 2021

mbrkusanin added inline comments to D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.
Nov 18 2021, 1:03 AM · Restricted Project

Nov 17 2021

mbrkusanin accepted D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).

LGTM

Nov 17 2021, 9:59 AM · Restricted Project
mbrkusanin accepted D98049: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), (fneg z)).

LGTM

Nov 17 2021, 9:59 AM · Restricted Project
mbrkusanin accepted D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)).

LGTM

Nov 17 2021, 9:59 AM · Restricted Project
mbrkusanin accepted D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

LGTM

Nov 17 2021, 9:58 AM · Restricted Project
mbrkusanin committed rGf2d402e58b90: [NFC][AMDGPU][GlobalISel] Fix some legalizer tests (authored by mbrkusanin).
[NFC][AMDGPU][GlobalISel] Fix some legalizer tests
Nov 17 2021, 5:28 AM
mbrkusanin committed rGdb6bc2ab5137: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods (authored by mbrkusanin).
[AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods
Nov 17 2021, 5:27 AM
mbrkusanin closed D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.
Nov 17 2021, 5:27 AM · Restricted Project

Nov 12 2021

mbrkusanin added a comment to D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .

This is another attempt at trying to get of cross reg bank copies for which I needed manual checks when matching (like in https://reviews.llvm.org/D110937, https://reviews.llvm.org/D98040)

Nov 12 2021, 10:38 AM · Restricted Project
mbrkusanin requested review of D113784: [AMDGPU][GlobalISel] Try to rematerialize when repairing regbank .
Nov 12 2021, 10:29 AM · Restricted Project
mbrkusanin updated the diff for D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.
  • AMDGPUCombinerHelper now inherits CombinerHelper class.
  • Now using AMDGPUCombinerHelper as one of helpers in prelegalizer and postlegalzer combiner passes instead of both AMDGPUCombinerHelper and CombinerHelper (does not affect tablegen generated code that much)
Nov 12 2021, 8:23 AM · Restricted Project

Nov 10 2021

mbrkusanin added inline comments to D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.
Nov 10 2021, 10:09 AM · Restricted Project
mbrkusanin updated the diff for D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.
  • Added AMDGPUCombinerHelper, a common helper for both amdgpu-prelegalizer-combiner and amdgpu-postlegalizer-combiner pass. This way same combine can be used in both passes.
Nov 10 2021, 10:07 AM · Restricted Project

Nov 3 2021

mbrkusanin added a comment to D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

clang-format for CombinerHelper.cpp

Nov 3 2021, 10:50 AM · Restricted Project
mbrkusanin accepted D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).

LGTM with a few nits

Nov 3 2021, 10:50 AM · Restricted Project
mbrkusanin accepted D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).

LGTM (with a nit)

Nov 3 2021, 10:49 AM · Restricted Project
mbrkusanin accepted D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).

LGTM

Nov 3 2021, 10:49 AM · Restricted Project
mbrkusanin accepted D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

LGTM

Nov 3 2021, 10:49 AM · Restricted Project

Oct 29 2021

mbrkusanin added a comment to D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.

Following opcodes are not expected to appear after legalizer but I guess there is no harm keeping them.

Oct 29 2021, 9:16 AM · Restricted Project
mbrkusanin requested review of D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods.
Oct 29 2021, 9:12 AM · Restricted Project

Oct 14 2021

mbrkusanin updated the diff for D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.

Updated IgnoreCopy matcher to skip through multiple copies.

Oct 14 2021, 3:35 AM · Restricted Project

Oct 8 2021

mbrkusanin committed rGd20840c93700: [GlobalISel] Combine for eliminating redundant operand negations (authored by mbrkusanin).
[GlobalISel] Combine for eliminating redundant operand negations
Oct 8 2021, 5:30 AM
mbrkusanin closed D111319: [GlobalISel] Combine for eliminating redundant operand negations.
Oct 8 2021, 5:30 AM · Restricted Project
mbrkusanin added inline comments to D111319: [GlobalISel] Combine for eliminating redundant operand negations.
Oct 8 2021, 4:36 AM · Restricted Project
mbrkusanin updated the diff for D111319: [GlobalISel] Combine for eliminating redundant operand negations.
  • Fix comments + rebase
Oct 8 2021, 4:36 AM · Restricted Project

Oct 7 2021

mbrkusanin requested review of D111319: [GlobalISel] Combine for eliminating redundant operand negations.
Oct 7 2021, 8:36 AM · Restricted Project
mbrkusanin added inline comments to D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.
Oct 7 2021, 3:15 AM · Restricted Project
mbrkusanin added reviewers for D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32: aemerson, paquette.
Oct 7 2021, 3:14 AM · Restricted Project

Oct 6 2021

mbrkusanin added inline comments to D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.
Oct 6 2021, 9:08 AM · Restricted Project
mbrkusanin updated the diff for D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.
Oct 6 2021, 9:08 AM · Restricted Project

Oct 5 2021

mbrkusanin committed rG40e00063bcb7: [GlobalISel] Combine fabs(fneg(x)) to fabs(x) (authored by mbrkusanin).
[GlobalISel] Combine fabs(fneg(x)) to fabs(x)
Oct 5 2021, 4:45 AM
mbrkusanin closed D110943: [GlobalISel] Combine fabs(fneg(x)) to fabs(x).
Oct 5 2021, 4:44 AM · Restricted Project

Oct 1 2021

mbrkusanin added inline comments to D110943: [GlobalISel] Combine fabs(fneg(x)) to fabs(x).
Oct 1 2021, 8:56 AM · Restricted Project
mbrkusanin requested review of D110943: [GlobalISel] Combine fabs(fneg(x)) to fabs(x).
Oct 1 2021, 8:33 AM · Restricted Project
mbrkusanin added inline comments to D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.
Oct 1 2021, 7:51 AM · Restricted Project
mbrkusanin added a comment to D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.

This can land before D98050 (or any other fma combine) but for a review it might be easier to see src modifiers in .ll tests than .mir.
If this is accepted before, we can commit it without .ll tests.

Oct 1 2021, 7:50 AM · Restricted Project
mbrkusanin requested review of D110937: [AMDGPU][GlobalISel] Select v_fma_mix_f32 and v_mad_mix_f32.
Oct 1 2021, 7:50 AM · Restricted Project

Sep 30 2021

mbrkusanin added inline comments to D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).
Sep 30 2021, 9:02 AM · Restricted Project
mbrkusanin added inline comments to D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Sep 30 2021, 7:54 AM · Restricted Project
mbrkusanin added inline comments to D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).
Sep 30 2021, 7:48 AM · Restricted Project
mbrkusanin added inline comments to D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).
Sep 30 2021, 7:47 AM · Restricted Project
mbrkusanin added inline comments to D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).
Sep 30 2021, 7:47 AM · Restricted Project

Sep 29 2021

mbrkusanin added inline comments to D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Sep 29 2021, 7:48 AM · Restricted Project

Sep 7 2021

mbrkusanin committed rG5263bf583a26: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR (authored by mbrkusanin).
[AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR
Sep 7 2021, 7:38 AM
mbrkusanin committed rG6c4b634da619: [AMDGPU][GlobalISel] Legalize G_MUL for non-standard types (authored by mbrkusanin).
[AMDGPU][GlobalISel] Legalize G_MUL for non-standard types
Sep 7 2021, 7:38 AM
mbrkusanin closed D109228: [AMDGPU][GlobalISel] Legalize G_MUL for non-standard types.
Sep 7 2021, 7:38 AM · Restricted Project
mbrkusanin closed D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.
Sep 7 2021, 7:38 AM · Restricted Project
mbrkusanin added inline comments to D109228: [AMDGPU][GlobalISel] Legalize G_MUL for non-standard types.
Sep 7 2021, 6:33 AM · Restricted Project
mbrkusanin committed rG36527cbe02c4: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics (authored by mbrkusanin).
[AMDGPU][GlobalISel] Legalize memcpy family of intrinsics
Sep 7 2021, 3:33 AM
mbrkusanin closed D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics.
Sep 7 2021, 3:33 AM · Restricted Project

Sep 6 2021

mbrkusanin updated the summary of D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics.
Sep 6 2021, 8:44 AM · Restricted Project
mbrkusanin added inline comments to D109228: [AMDGPU][GlobalISel] Legalize G_MUL for non-standard types.
Sep 6 2021, 8:34 AM · Restricted Project