Page MenuHomePhabricator

dp (Dmitry Preobrazhensky)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2017, 7:55 AM (198 w, 13 h)

Recent Activity

Thu, Nov 26

dp added inline comments to D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier.
Thu, Nov 26, 2:13 AM · Restricted Project

Wed, Nov 25

dp abandoned D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier.
Wed, Nov 25, 10:58 AM · Restricted Project
dp requested review of D92088: [AMDGPU][MC] Improved diagnostics message for sym/expr operands.
Wed, Nov 25, 3:11 AM · Restricted Project
dp requested review of D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier.
Wed, Nov 25, 2:48 AM · Restricted Project
dp requested review of D92084: [AMDGPU][MC] Corrected error position for invalid MOVREL src.
Wed, Nov 25, 2:42 AM · Restricted Project

Mon, Nov 23

dp committed rGce44bf2cf229: [AMDGPU][MC] Improved diagnostic messages (authored by dp).
[AMDGPU][MC] Improved diagnostic messages
Mon, Nov 23, 5:15 AM
dp closed D91794: [AMDGPU][MC] Improved diagnostic messages.
Mon, Nov 23, 5:15 AM · Restricted Project
dp committed rGe4effef33059: [AMDGPU][MC] Improved diagnostic messages for invalid literals (authored by dp).
[AMDGPU][MC] Improved diagnostic messages for invalid literals
Mon, Nov 23, 4:48 AM
dp closed D91793: [AMDGPU][MC] Improved diagnostics for invalid literals.
Mon, Nov 23, 4:48 AM · Restricted Project

Thu, Nov 19

dp requested review of D91794: [AMDGPU][MC] Improved diagnostic messages.
Thu, Nov 19, 6:30 AM · Restricted Project
dp requested review of D91793: [AMDGPU][MC] Improved diagnostics for invalid literals.
Thu, Nov 19, 6:03 AM · Restricted Project

Mon, Nov 16

dp committed rG65f3e121fe4f: [AMDGPU][MC] Corrected error position for some operands and modifiers (authored by dp).
[AMDGPU][MC] Corrected error position for some operands and modifiers
Mon, Nov 16, 5:11 AM
dp closed D91412: [AMDGPU][MC] Corrected error position for some operands and modifiers.
Mon, Nov 16, 5:11 AM · Restricted Project
dp committed rG0bee8c784b3f: [AMDGPU][MC] Corrected error position for swizzle() (authored by dp).
[AMDGPU][MC] Corrected error position for swizzle()
Mon, Nov 16, 3:39 AM
dp closed D91408: [AMDGPU][MC] Corrected error position for swizzle().
Mon, Nov 16, 3:39 AM · Restricted Project
dp committed rG89df8fc0d73f: [AMDGPU][MC] Corrected error position for hwreg() and sendmsg() (authored by dp).
[AMDGPU][MC] Corrected error position for hwreg() and sendmsg()
Mon, Nov 16, 3:26 AM
dp closed D91407: [AMDGPU][MC] Corrected error position for hwreg() and sendmsg().
Mon, Nov 16, 3:25 AM · Restricted Project

Fri, Nov 13

dp requested review of D91412: [AMDGPU][MC] Corrected error position for some operands and modifiers.
Fri, Nov 13, 4:27 AM · Restricted Project
dp requested review of D91408: [AMDGPU][MC] Corrected error position for swizzle().
Fri, Nov 13, 2:40 AM · Restricted Project
dp updated the diff for D91407: [AMDGPU][MC] Corrected error position for hwreg() and sendmsg().

Corrected indentation

Fri, Nov 13, 2:26 AM · Restricted Project
dp requested review of D91407: [AMDGPU][MC] Corrected error position for hwreg() and sendmsg().
Fri, Nov 13, 2:22 AM · Restricted Project

Mon, Nov 9

dp committed rGf4cc511303bd: [AMDGPU][MC] Added tests for checking error position (authored by dp).
[AMDGPU][MC] Added tests for checking error position
Mon, Nov 9, 5:20 AM
dp closed D90925: [AMDGPU][MC] Added tests for checking error position.
Mon, Nov 9, 5:20 AM · Restricted Project

Fri, Nov 6

dp requested review of D90925: [AMDGPU][MC] Added tests for checking error position.
Fri, Nov 6, 3:08 AM · Restricted Project

Thu, Nov 5

dp accepted D90730: [AMDGPU] Add default 1 glc operand to rtn atomics.

LGTM with a minor issue

Thu, Nov 5, 4:07 AM · Restricted Project

Oct 27 2020

dp added inline comments to D90242: [AMDGPU] Fix check prefix for VOP3 VI disassembler tests.
Oct 27 2020, 10:26 AM · Restricted Project
dp added inline comments to D90242: [AMDGPU] Fix check prefix for VOP3 VI disassembler tests.
Oct 27 2020, 9:55 AM · Restricted Project

Oct 8 2020

dp committed rG1e75668821f7: [AMDGPU][MC][GFX1030] Disabled v_mac_f32 (authored by dp).
[AMDGPU][MC][GFX1030] Disabled v_mac_f32
Oct 8 2020, 4:02 AM
dp closed D89000: [AMDGPU][MC][GFX1030] Disabled v_mac_f32.
Oct 8 2020, 4:01 AM · Restricted Project

Oct 7 2020

dp requested review of D89000: [AMDGPU][MC][GFX1030] Disabled v_mac_f32.
Oct 7 2020, 12:02 PM · Restricted Project
dp committed rG4a7e7620d6c6: [AMDGPU][MC] Improved diagnostics for instructions with missing features (authored by dp).
[AMDGPU][MC] Improved diagnostics for instructions with missing features
Oct 7 2020, 6:32 AM
dp closed D88887: [AMDGPU][MC] Improved diagnostics for instructions with missing features.
Oct 7 2020, 6:32 AM · Restricted Project

Oct 6 2020

dp added inline comments to D88887: [AMDGPU][MC] Improved diagnostics for instructions with missing features.
Oct 6 2020, 10:11 AM · Restricted Project
dp added inline comments to D88887: [AMDGPU][MC] Improved diagnostics for instructions with missing features.
Oct 6 2020, 9:39 AM · Restricted Project
dp committed rGe2452f57faa9: [AMDGPU][MC] Added detection of unsupported instructions (authored by dp).
[AMDGPU][MC] Added detection of unsupported instructions
Oct 6 2020, 6:45 AM
dp closed D88211: [AMDGPU][MC] Added detection of unsupported instructions.
Oct 6 2020, 6:44 AM · Restricted Project
dp requested review of D88887: [AMDGPU][MC] Improved diagnostics for instructions with missing features.
Oct 6 2020, 4:19 AM · Restricted Project

Oct 5 2020

dp committed rGe70e7d1019ca: [TableGen] Added a function for identification of unsupported opcodes. (authored by dp).
[TableGen] Added a function for identification of unsupported opcodes.
Oct 5 2020, 4:28 AM
dp closed D88214: [TableGen] Added a function to identify unsupported opcodes.
Oct 5 2020, 4:28 AM · Restricted Project

Oct 3 2020

dp added a comment to D88214: [TableGen] Added a function to identify unsupported opcodes.

Just to make sure I understand this correctly though. These instructions are valid for at least some invocation of feature flags, <...>

Oct 3 2020, 11:32 AM · Restricted Project

Oct 1 2020

dp added a comment to D88214: [TableGen] Added a function to identify unsupported opcodes.

I'm sorry for not trying your patch earlier. I thought that it only fixed problems with operand matcher and I had a feeling that most problems were located in instruction matcher.
Well, I finally tried your patch. It did not fix all issues, but for on-liner it is really good!
There are several lit tests created specifically to test unsupported instructions. Below is a summary of results with and without your patch.

Oct 1 2020, 11:57 AM · Restricted Project

Sep 30 2020

dp added a comment to D88214: [TableGen] Added a function to identify unsupported opcodes.

Hello @sdesmalen. Thanks for your review.

Sep 30 2020, 6:09 AM · Restricted Project

Sep 29 2020

dp added reviewers for D88214: [TableGen] Added a function to identify unsupported opcodes: dsanders, nhaehnle, t.p.northover.
Sep 29 2020, 3:50 AM · Restricted Project

Sep 24 2020

dp updated the diff for D88211: [AMDGPU][MC] Added detection of unsupported instructions.

Removed unnecessary code

Sep 24 2020, 5:56 AM · Restricted Project
dp updated the summary of D88211: [AMDGPU][MC] Added detection of unsupported instructions.
Sep 24 2020, 4:08 AM · Restricted Project
dp requested review of D88214: [TableGen] Added a function to identify unsupported opcodes.
Sep 24 2020, 4:05 AM · Restricted Project
dp requested review of D88211: [AMDGPU][MC] Added detection of unsupported instructions.
Sep 24 2020, 3:30 AM · Restricted Project

Sep 16 2020

dp committed rG06d058afecdf: [AMDGPU] Corrected directive to use for ELF weak refs (authored by dp).
[AMDGPU] Corrected directive to use for ELF weak refs
Sep 16 2020, 8:54 AM
dp closed D87762: [AMDGPU] Corrected directive to use for ELF weak refs.
Sep 16 2020, 8:54 AM · Restricted Project
dp updated the diff for D87762: [AMDGPU] Corrected directive to use for ELF weak refs.

Added a test

Sep 16 2020, 8:27 AM · Restricted Project
dp requested review of D87762: [AMDGPU] Corrected directive to use for ELF weak refs.
Sep 16 2020, 7:38 AM · Restricted Project

Sep 9 2020

dp committed rG95b7040e4384: [AMDGPU][MC] Improved diagnostic messages for invalid registers (authored by dp).
[AMDGPU][MC] Improved diagnostic messages for invalid registers
Sep 9 2020, 6:44 AM
dp closed D87234: [AMDGPU][MC] Improved diagnostic messages for invalid registers.
Sep 9 2020, 6:44 AM · Restricted Project

Sep 8 2020

dp added inline comments to D87234: [AMDGPU][MC] Improved diagnostic messages for invalid registers.
Sep 8 2020, 4:41 PM · Restricted Project

Sep 7 2020

dp requested review of D87234: [AMDGPU][MC] Improved diagnostic messages for invalid registers.
Sep 7 2020, 6:45 AM · Restricted Project

Sep 2 2020

dp committed rGecde200209f8: [AMDGPU][MC] Corrected parser to avoid generation of excessive error messages (authored by dp).
[AMDGPU][MC] Corrected parser to avoid generation of excessive error messages
Sep 2 2020, 9:45 AM
dp closed D86940: [AMDGPU][MC] Corrected parser to avoid excessive error messages.
Sep 2 2020, 9:45 AM · Restricted Project

Sep 1 2020

dp requested review of D86940: [AMDGPU][MC] Corrected parser to avoid excessive error messages.
Sep 1 2020, 7:34 AM · Restricted Project

Aug 21 2020

dp committed rG3f7985e6ec21: [AMDGPU][MC][NFC][DOC] Updated AMD GPU assembler syntax description. (authored by dp).
[AMDGPU][MC][NFC][DOC] Updated AMD GPU assembler syntax description.
Aug 21 2020, 4:25 AM

Aug 14 2020

dp added a comment to D85941: AMDGPU: Correct definitions for global saddr instructions.

This change fixes bug 35436.
https://bugs.llvm.org/show_bug.cgi?id=35436

Aug 14 2020, 9:45 AM · Restricted Project
dp accepted D85941: AMDGPU: Correct definitions for global saddr instructions.

LGTM.
The syntax is terrible but at least it is sp3-compatible.

Aug 14 2020, 5:27 AM · Restricted Project

Jul 24 2020

dp added inline comments to D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier.
Jul 24 2020, 6:45 AM · Restricted Project
dp committed rG6b8948922c59: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier (authored by dp).
[AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier
Jul 24 2020, 6:41 AM
dp closed D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier.
Jul 24 2020, 6:41 AM · Restricted Project

Jul 23 2020

dp added inline comments to D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier.
Jul 23 2020, 1:52 PM · Restricted Project
dp added inline comments to D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier.
Jul 23 2020, 4:43 AM · Restricted Project

Jul 22 2020

dp accepted D84337: AMDGPU: Don't assert on f16 inv2pi immediates pre-gfx8.

LGTM

Jul 22 2020, 10:36 AM · Restricted Project
dp committed rG0b8fd77ad953: [AMDGPU][MC] Corrected decoding of 16-bit literals (authored by dp).
[AMDGPU][MC] Corrected decoding of 16-bit literals
Jul 22 2020, 7:21 AM
dp closed D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.
Jul 22 2020, 7:21 AM · Restricted Project

Jul 21 2020

dp added a comment to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.

Are there any more issues with this change?

Jul 21 2020, 3:45 PM · Restricted Project

Jul 20 2020

dp updated the diff for D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.

Corrected after a discussion with Matt:

  • added 16-bit truncation;
  • printed as unsigned.
Jul 20 2020, 9:16 PM · Restricted Project
dp added inline comments to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.
Jul 20 2020, 8:54 AM · Restricted Project
dp added inline comments to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.
Jul 20 2020, 7:33 AM · Restricted Project
dp added inline comments to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.
Jul 20 2020, 7:18 AM · Restricted Project
dp added inline comments to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.
Jul 20 2020, 7:15 AM · Restricted Project
dp added inline comments to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals.
Jul 20 2020, 6:58 AM · Restricted Project

Jul 18 2020

dp updated the diff for D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier.

Minor correction - removed 'SP3' from function names.

Jul 18 2020, 7:46 AM · Restricted Project
Herald added a project to D84098: [AMDGPU][MC] Corrected decoding of 16-bit literals: Restricted Project.
Jul 18 2020, 6:43 AM · Restricted Project

Jul 17 2020

dp committed rG2e87acac9b88: [AMDGPU] Removed s_mov_regrd and mov_fed opcodes (authored by dp).
[AMDGPU] Removed s_mov_regrd and mov_fed opcodes
Jul 17 2020, 9:53 AM
dp closed D81659: [AMDGPU] Removed s_mov_regrd and mov_fed opcodes.
Jul 17 2020, 9:53 AM · Restricted Project
dp updated the summary of D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier.
Jul 17 2020, 7:17 AM · Restricted Project
Herald added a project to D84026: [AMDGPU][MC] Added support of SP3 syntax for MTBUF format modifier: Restricted Project.
Jul 17 2020, 7:11 AM · Restricted Project
dp added a comment to D83760: [AMDGPU][MC] Corrected MTBUF parsing and decoding.

Thanks Mikael. It will be fixed next week.

Jul 17 2020, 4:18 AM · Restricted Project

Jul 16 2020

dp accepted D83825: AMDGPU: Rename add/sub with carry out instructions.

Inconsistent error messages will be addressed separately - this is a known issue.

Jul 16 2020, 8:33 AM · Restricted Project

Jul 15 2020

dp added a comment to D83825: AMDGPU: Rename add/sub with carry out instructions.

Sure, I'll take a look tomorrow.

Jul 15 2020, 12:32 PM · Restricted Project
dp committed rGe122eba18505: [AMDGPU][MC] Corrected MTBUF parsing and decoding (authored by dp).
[AMDGPU][MC] Corrected MTBUF parsing and decoding
Jul 15 2020, 9:46 AM
dp closed D83760: [AMDGPU][MC] Corrected MTBUF parsing and decoding.
Jul 15 2020, 9:46 AM · Restricted Project

Jul 14 2020

dp reclaimed D81659: [AMDGPU] Removed s_mov_regrd and mov_fed opcodes.
Jul 14 2020, 12:02 PM · Restricted Project
Herald added a project to D83760: [AMDGPU][MC] Corrected MTBUF parsing and decoding: Restricted Project.
Jul 14 2020, 4:23 AM · Restricted Project
dp abandoned D81659: [AMDGPU] Removed s_mov_regrd and mov_fed opcodes.
Jul 14 2020, 3:19 AM · Restricted Project

Jul 13 2020

dp added a comment to D81659: [AMDGPU] Removed s_mov_regrd and mov_fed opcodes.

Ping. Is this change needed? If you are unsure we can content ourselves with removing these opcodes from assembler documentation.

Jul 13 2020, 11:43 AM · Restricted Project

Jul 3 2020

dp committed rG53422e8b4f65: [AMDGPU] Added support of new inline assembler constraints (authored by dp).
[AMDGPU] Added support of new inline assembler constraints
Jul 3 2020, 8:03 AM
dp closed D81657: [AMDGPU] Added support of new inline assembler constraints.
Jul 3 2020, 8:03 AM · Restricted Project

Jul 2 2020

dp committed rG1c9d681092d1: [AMDGPU][CODEGEN] Added support of new inline assembler constraints (authored by dp).
[AMDGPU][CODEGEN] Added support of new inline assembler constraints
Jul 2 2020, 7:33 AM
dp closed D81651: [AMDGPU][CODEGEN] Added support of new inline assembler constraints.
Jul 2 2020, 7:32 AM · Restricted Project

Jul 1 2020

dp added a comment to D81651: [AMDGPU][CODEGEN] Added support of new inline assembler constraints.

Ping

Jul 1 2020, 5:50 PM · Restricted Project

Jun 25 2020

dp updated the diff for D81651: [AMDGPU][CODEGEN] Added support of new inline assembler constraints.

Support of constraints 'L' and 'Kf' has been separated as D82538.

Jun 25 2020, 3:37 AM · Restricted Project
dp abandoned D82538: [AMDGPU][CODEGEN] Added support for inline assembler constraints 'L' and 'Kf'.
Jun 25 2020, 3:36 AM · Restricted Project
dp created D82538: [AMDGPU][CODEGEN] Added support for inline assembler constraints 'L' and 'Kf'.
Jun 25 2020, 3:36 AM · Restricted Project

Jun 24 2020

dp added inline comments to D81651: [AMDGPU][CODEGEN] Added support of new inline assembler constraints.
Jun 24 2020, 3:44 AM · Restricted Project