This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][AsmParser][NFC] Specify parser methods directly in operand classes.
ClosedPublic

Authored by kosarev on May 29 2023, 11:40 PM.

Details

Summary

Eliminates the need for custom operand classes whose only purpose is to
define a parser method.

Part of https://github.com/llvm/llvm-project/issues/62629.

Diff Detail

Event Timeline

kosarev created this revision.May 29 2023, 11:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 11:40 PM
kosarev requested review of this revision.May 29 2023, 11:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 11:40 PM
dp accepted this revision.Jun 4 2023, 10:54 AM

LGTM.

This revision is now accepted and ready to land.Jun 4 2023, 10:54 AM
This revision was landed with ongoing or failed builds.Jun 5 2023, 5:04 AM
This revision was automatically updated to reflect the committed changes.

@dp Thanks a lot for reviewing these, Dmitry! Will try to find someone to help with reviewing future AsmParser patches.