This is an archive of the discontinued LLVM Phabricator instance.

[IR][NFC] Change UndefMaskElem to PoisonMaskElem
ClosedPublic

Authored by ManuelJBrito on Apr 26 2023, 6:55 AM.

Details

Summary

Following the change in shufflevector semantics in D148637, poison will be used to represent undefined elements in shufflevector masks.

Diff Detail

Event Timeline

ManuelJBrito created this revision.Apr 26 2023, 6:55 AM
Herald added a project: Restricted Project. · View Herald Transcript
ManuelJBrito requested review of this revision.Apr 26 2023, 6:55 AM
nikic requested changes to this revision.Apr 26 2023, 11:52 AM
nikic added inline comments.
llvm/include/llvm-c/Core.h
4097

undefined -> poison?

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
966

Why did the ExtendingManyInputs checks go away here?

6351

Rebase mistake?

This revision now requires changes to proceed.Apr 26 2023, 11:52 AM

Address comments

ManuelJBrito added inline comments.Apr 27 2023, 3:45 AM
llvm/include/llvm-c/Core.h
4097

I was thinking we can have undefined here to mean either poison or undef, just to match the function's name.

nikic accepted this revision.Apr 27 2023, 6:01 AM

LGTM

This revision is now accepted and ready to land.Apr 27 2023, 6:01 AM
This revision was landed with ongoing or failed builds.Apr 27 2023, 10:02 AM
This revision was automatically updated to reflect the committed changes.