This is an archive of the discontinued LLVM Phabricator instance.

Switch `llvm/CodeGen/MachineValueType.h` to the generated one
ClosedPublic

Authored by chapuni on Apr 19 2023, 5:50 PM.

Details

Summary

Prune SupportTests/MVTTest since it is no longer needed.

See also, "[RFC] Let MVT generated and restore MVT into llvm/CodeGen"
https://discourse.llvm.org/t/rfc-let-mvt-generated-and-restore-mvt-into-llvm-codegen/69547

Depends on D148769

Diff Detail

Event Timeline

chapuni created this revision.Apr 19 2023, 5:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 5:50 PM
chapuni requested review of this revision.Apr 19 2023, 5:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 5:50 PM
chapuni updated this revision to Diff 515156.Apr 19 2023, 5:51 PM
chapuni edited the summary of this revision. (Show Details)
  • Update desc
chapuni updated this revision to Diff 515321.Apr 20 2023, 7:14 AM
chapuni edited the summary of this revision. (Show Details)
  • fix a typo in modmap

These series can close my RFC. Feel free to add other reviewers/subscribers.

"[RFC] Let MVT generated and restore MVT into llvm/CodeGen"
https://discourse.llvm.org/t/rfc-let-mvt-generated-and-restore-mvt-into-llvm-codegen/69547

chapuni updated this revision to Diff 516183.Apr 23 2023, 9:29 AM
  • Update CMake deps
arsenm accepted this revision.Apr 25 2023, 3:44 AM
This revision is now accepted and ready to land.Apr 25 2023, 3:44 AM
chapuni updated this revision to Diff 518723.May 2 2023, 7:29 AM
  • Rebase
This revision was landed with ongoing or failed builds.May 2 2023, 8:18 AM
This revision was automatically updated to reflect the committed changes.

I have found the case aarch64svcount is incompatible. Will fix.

Fixed temporarily in rGd091a19e58a2.

thakis added a subscriber: thakis.May 2 2023, 4:47 PM

This adds a dependency cycle:

//llvm/utils/TableGen:llvm-tblgen ->
//llvm/utils/TableGen/GlobalISel:GlobalISel ->
//llvm/include/llvm/CodeGen:GenVT ->
//llvm/utils/TableGen:llvm-tblgen
thakis added a comment.May 2 2023, 4:50 PM

Oh I see, that's what D146352 is for.

That's a lot of machinery. Is there any benefit to these changes too to justify that?

skan added a subscriber: skan.May 3 2023, 8:00 PM
llvm/unittests/Support/CMakeLists.txt