Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/CodeGen/AMDGPU/global-atomic-scan.ll | ||
|---|---|---|
| 2 | Don't know why this is introducing a new test. also drop -verify-machineinstrs, it won't do anything for opt | |
| llvm/test/CodeGen/AMDGPU/global-atomic-scan.ll | ||
|---|---|---|
| 2 |
Currently there are no tests for atomic optimizer which runs in isolation i.e., only amdgpu-atomic-optimizer pass alone. All existing tests runs complete pipeline. | |
LGTM. Please wait for a day before committing in case other reviewers have any comments.
LGTM. But please do address all comments before submitting.
| llvm/test/CodeGen/AMDGPU/global-atomic-scan.ll | ||
|---|---|---|
| 1441 | This needs fixing ... newline at the end of file is helpful with a lot of text utilities. | |
Don't know why this is introducing a new test. also drop -verify-machineinstrs, it won't do anything for opt