Page MenuHomePhabricator

sameerds (Sameer Sahasrabuddhe)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2012, 11:25 AM (506 w, 1 d)

Working on ROCm at AMD

Recent Activity

Tue, Jun 21

sameerds accepted D123231: [StructurizeCFG] Improve basic block ordering.

I had tried a different approach to avoid inserting excessive number of boolean values during the loop-exit-unify in D127831. I just did some testing of that change against the LLVM IR Brendon shared with me. It shows the change could help reducing the number of registers as well as compile time. But it is sad that I still hit the error: "unhandled SGPR spill to memory" from SGPRSpillBuilder in SIRegisterInfo.cpp. Can the limitation be fixed? I did some register pressure comparison, seems the way I proposed would use much less VGPR than (D123230 + D123231), but use more SGPR. I haven't looked further why there is such behavior difference. I think we need more investigation to know why. But looks like D127831 might help us generate better code because we can use one VGPR as the backup storage for spilling of 64/32 SGPRs. And the idea used there is much easy to follow.

Tue, Jun 21, 10:50 PM · Restricted Project, Restricted Project

Tue, Jun 14

sameerds accepted D126523: [MachineSSAUpdater] compile time improvement in GetValueInMiddleOfBlock.
Tue, Jun 14, 3:56 AM · Restricted Project, Restricted Project
sameerds added a comment to D126523: [MachineSSAUpdater] compile time improvement in GetValueInMiddleOfBlock.

Same typo in the change description, last paragraph ... middle "of" the block.

Tue, Jun 14, 1:29 AM · Restricted Project, Restricted Project
sameerds added a comment to D126523: [MachineSSAUpdater] compile time improvement in GetValueInMiddleOfBlock.

Looks straightforward enough to me. If the value is a PHI, it must be at the beginning of the current block. If it is outside this block, then whoever registered it is confident that it dominates this block. Is it correct that the SSAUpdater will not end up in a state where it tries to use a phi to produce another phi in the same block? Because that might race against the assumption that the used phi is available earlier in the block.

Tue, Jun 14, 1:27 AM · Restricted Project, Restricted Project

Mon, Jun 13

sameerds added a comment to D123231: [StructurizeCFG] Improve basic block ordering.

The change itself looks okay to me, to the extent that it does not seem to break the structurizer. Just by putting nodes in the right order, it is still able to generate predicates that preserve the original control flow. I think that's good enough to boldly make this change. I do have some comments/questions about the tests.

Mon, Jun 13, 11:43 PM · Restricted Project, Restricted Project

May 30 2022

sameerds accepted D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values.

The code looks okay to me, but still need @arsenm to check the effect on the AMDGPU lit test. There seem to be superficial changes to the control flow, but Matt might be able to say whether the test still serves its original purpose after this change.

May 30 2022, 9:43 PM · Restricted Project, Restricted Project
sameerds added a comment to D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values.

Even then, a target independent test in LLVM IR will certainly be useful.

That would be good but SSA Updater is not triggered directly as a pass. I found the motivation case in tailduplication codegen pass, so I've written it in mir format. Writing it in LLVM IR will just include a lot of other passes where the changes might disappear the case I'm testing. I though the more precise test is better than something general.

If you'd like I can try to create unittest triggering directly SSA Updater.

May 30 2022, 12:18 AM · Restricted Project, Restricted Project
sameerds added inline comments to D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values.
May 30 2022, 12:16 AM · Restricted Project, Restricted Project

May 29 2022

sameerds added a reviewer for D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values: arsenm.
May 29 2022, 9:56 PM · Restricted Project, Restricted Project
sameerds added a comment to D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values.

This is interesting! Can you please make a simple/dedicated LLVM IR case for this only, so we can go over the example to get the whole picture?

llvm/test/CodeGen/AArch64/tail-dup-redundant-phi.mir is dedicated test for this patch and https://reviews.llvm.org/D126523. This test is not landed yet. I just uploaded it here as diff to show the difference.

May 29 2022, 9:56 PM · Restricted Project, Restricted Project
sameerds updated subscribers of D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values.

Requesting @arsenm to take a look at the AMDGPU test.

May 29 2022, 9:53 PM · Restricted Project, Restricted Project

May 23 2022

sameerds accepted D123995: [MachineSink] replace MachineLoop with MachineCycle.

LGTM! My sincere apologies for the delay ... I have no excuse :(

May 23 2022, 8:26 PM · Restricted Project, Restricted Project

May 17 2022

sameerds added a comment to D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

Sorry I missed this earlier. The name of the new test "issue55099.ll" doesn't really convey much information. It should be renamed to something more informative, like "preserve-child-loops.ll"

May 17 2022, 11:18 PM · Restricted Project, Restricted Project
sameerds added a comment to D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

Sorry, I'm new here, so I know little about the workflows. I've just updated the title and the summary of this revision. I don't know whether you mean this. And I've noticed there is a build failure on x64 debian. Should I fix this?

May 17 2022, 10:48 PM · Restricted Project, Restricted Project
sameerds accepted D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

I think the change description is missing the point and needs to be rephrased. The modified function was incorrectly (not unnecessarily) ignoring grandchild loops, and this change fixes the bug. In particular, this fixes the handling of the loop { inner, body }. The TODO in the same function is talking about the b1 self loop, which may be "unnecessarily" lost, but that is a different issue.

May 17 2022, 10:23 PM · Restricted Project, Restricted Project

May 5 2022

sameerds requested changes to D123995: [MachineSink] replace MachineLoop with MachineCycle.
May 5 2022, 9:52 PM · Restricted Project, Restricted Project

May 4 2022

sameerds resigned from D124813: [HLSL] Add clang builtin for HLSL..

I am not much familiar with DirectX and HLSL, so unable to review this patch. It might help to post on the Discourse under Clang Frontend:

May 4 2022, 11:48 PM · Restricted Project, Restricted Project

Apr 20 2022

sameerds accepted D123995: [MachineSink] replace MachineLoop with MachineCycle.

The changes in GenericCycleInfo look good to me. But please do wait for reviewers looking at MachineSink.

Apr 20 2022, 4:52 PM · Restricted Project, Restricted Project

Apr 19 2022

sameerds added a comment to D123995: [MachineSink] replace MachineLoop with MachineCycle.

Do note that the cycle hierarchy is implementation-defined, and hence the reported cycle depth is not an invariant property of the program being compiled. For example, in the following CFG:

Apr 19 2022, 10:27 AM · Restricted Project, Restricted Project

Apr 14 2022

sameerds added a comment to D123231: [StructurizeCFG] Improve basic block ordering.

which increases compilation time and register pressure.

Have you looked at which part is responsible for the compilation time increase? Is is possible that we hit inefficiency in certain pass?
The "register pressure" here specifically means SGPR usage, right?

I don't think it is a good idea to move exist blocks into the loop especially when threads in a wave exit the loop in different iterations. Executing the exit block after loop should benefit for runtime performance.

Apr 14 2022, 12:30 AM · Restricted Project, Restricted Project

Apr 12 2022

sameerds added a comment to D123231: [StructurizeCFG] Improve basic block ordering.

In specific cases, this patch reduces the number of values needed
after loop by moving the exit block to the loop.

I think "into the loop" would be clearer if that's what you mean.

Apr 12 2022, 3:47 AM · Restricted Project, Restricted Project

Apr 11 2022

sameerds accepted D123548: AMDGPU: Emit metadata for the hidden_multigrid_sync_arg conditionally.

This patch clearly follows the same pattern as other attributes. At least I didn't spot anything different. Please give it a day for others to comment, otherwise good to go.

Apr 11 2022, 11:43 PM · Restricted Project, Restricted Project
sameerds added a comment to D123231: [StructurizeCFG] Improve basic block ordering.

Needs more reviewers ... I would suggest authors of previous non-trivial changes to the structurizer, and their reviewers.

Apr 11 2022, 2:03 AM · Restricted Project, Restricted Project

Apr 10 2022

sameerds accepted D123230: [UnifyLoopExits] Reduce number of guard blocks.
Apr 10 2022, 10:36 PM · Restricted Project, Restricted Project

Apr 9 2022

sameerds added inline comments to D123230: [UnifyLoopExits] Reduce number of guard blocks.
Apr 9 2022, 3:30 AM · Restricted Project, Restricted Project

Apr 7 2022

sameerds added inline comments to D123230: [UnifyLoopExits] Reduce number of guard blocks.
Apr 7 2022, 12:59 AM · Restricted Project, Restricted Project

Mar 29 2022

sameerds accepted D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

LGTM! But not sure if @yaxunl and/or @arsenm should have another look at the final version.

Mar 29 2022, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
sameerds added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

@yaxunl Does excluding device-libs via COV_None make sense?

@sameerds Would you still rather we just not add this attribute in the frontend at all? I'm OK with it if that is the consensus

Mar 29 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

sameerds added inline comments to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 24 2022, 11:15 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

sameerds added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

The check for "__ockl_hostcall_internal" is not longer relevant with the new hostcall attribute. Can we simply remove this check? What is the situation where the warning is still useful?

I wasn't aware of the new attribute, I'm happy to just delete it.

Mar 18 2022, 9:34 PM · Restricted Project, Restricted Project, Restricted Project
sameerds added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 18 2022, 9:33 PM · Restricted Project, Restricted Project, Restricted Project
sameerds added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

The check for "__ockl_hostcall_internal" is not longer relevant with the new hostcall attribute. Can we simply remove this check? What is the situation where the warning is still useful?

Mar 18 2022, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

sameerds added inline comments to D120265: AMDGPU: Use the implicit kernargs for code object version 5.
Mar 16 2022, 9:34 PM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

sameerds added a comment to D120265: AMDGPU: Use the implicit kernargs for code object version 5.

Please remove the JIRA ticket number from the commit description.

Mar 11 2022, 10:54 PM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

sameerds accepted D119762: AMDGPU: Set up User SGPRs for queue_ptr only when necessary.

Please wait for a day to give other reviewers a chance to respond.

Mar 7 2022, 8:59 PM · Restricted Project, Restricted Project

Feb 25 2022

sameerds accepted D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg.
Feb 25 2022, 3:24 AM · Restricted Project

Feb 21 2022

sameerds added inline comments to D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg.
Feb 21 2022, 10:39 PM · Restricted Project
sameerds added inline comments to D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg.
Feb 21 2022, 10:13 PM · Restricted Project
sameerds added inline comments to D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg.
Feb 21 2022, 9:01 PM · Restricted Project
sameerds added a comment to D120265: AMDGPU: Use the implicit kernargs for code object version 5.

Please fix the commit description so that the first line is self-contained and separated from the rest by a blank line. This matters a lot when looking at the output of "git log ---oneline". In particular, the start with "in this work we implement" is pretty much unnecessary.

Feb 21 2022, 8:53 PM · Restricted Project, Restricted Project, Restricted Project
sameerds added a comment to D119762: AMDGPU: Set up User SGPRs for queue_ptr only when necessary.

Please fix the commit description so that the first line is self-contained and separated from the rest by a blank line. This matters a lot when looking at the output of "git log ---oneline".

Feb 21 2022, 8:51 PM · Restricted Project, Restricted Project

Feb 20 2022

sameerds added inline comments to D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg.
Feb 20 2022, 5:28 AM · Restricted Project

Feb 17 2022

sameerds added inline comments to D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg.
Feb 17 2022, 1:06 AM · Restricted Project

Feb 11 2022

sameerds committed rGd8f99bb6e064: [AMDGPU] replace hostcall module flag with function attribute (authored by sameerds).
[AMDGPU] replace hostcall module flag with function attribute
Feb 11 2022, 9:23 AM
sameerds closed D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 11 2022, 9:23 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2022

sameerds updated the diff for D119216: [AMDGPU] replace hostcall module flag with function attribute.

use AAPointerInfo; add more tests to demonstrate the same

Feb 10 2022, 9:17 PM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2022

sameerds added inline comments to D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 9 2022, 3:07 AM · Restricted Project, Restricted Project, Restricted Project
sameerds added inline comments to D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 9 2022, 1:20 AM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2022

sameerds added inline comments to D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.
Feb 8 2022, 7:15 PM · Restricted Project
sameerds committed rGc6a6b57902b3: [AMDGPU] [NFC] Fix incorrect use of bitwise operator. (authored by sameerds).
[AMDGPU] [NFC] Fix incorrect use of bitwise operator.
Feb 8 2022, 7:14 PM
sameerds closed D119308: [AMDGPU] [NFC] Fix incorrect use of bitwise operator..
Feb 8 2022, 7:13 PM · Restricted Project
sameerds requested review of D119308: [AMDGPU] [NFC] Fix incorrect use of bitwise operator..
Feb 8 2022, 7:11 PM · Restricted Project
sameerds added inline comments to D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 8 2022, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
sameerds added inline comments to D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.
Feb 8 2022, 5:56 PM · Restricted Project
sameerds updated the diff for D119216: [AMDGPU] replace hostcall module flag with function attribute.

added tests for i128 load. hostcall position is now independent of subtarget.

Feb 8 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
sameerds added inline comments to D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 8 2022, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
sameerds updated the diff for D119216: [AMDGPU] replace hostcall module flag with function attribute.

further simplified the callback return value; moved hostcall info out of the subtarget

Feb 8 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
sameerds added inline comments to D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 8 2022, 5:35 AM · Restricted Project, Restricted Project, Restricted Project
sameerds updated the diff for D119216: [AMDGPU] replace hostcall module flag with function attribute.

eliminated NeedsHostcall by simply checking the return value of the walk over all calls

Feb 8 2022, 5:33 AM · Restricted Project, Restricted Project, Restricted Project
sameerds added inline comments to D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 8 2022, 4:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2022

sameerds added reviewers for D119216: [AMDGPU] replace hostcall module flag with function attribute: b-sumner, arsenm, cfang, yaxunl, tony-tye, kpyzhov.
Feb 7 2022, 11:36 PM · Restricted Project, Restricted Project, Restricted Project
sameerds requested review of D119216: [AMDGPU] replace hostcall module flag with function attribute.
Feb 7 2022, 11:35 PM · Restricted Project, Restricted Project, Restricted Project
sameerds committed rG02a2e46ff05b: [AMDGPU] [NFC] refactor the AMDGPU attributor (authored by sameerds).
[AMDGPU] [NFC] refactor the AMDGPU attributor
Feb 7 2022, 6:46 PM
sameerds closed D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.
Feb 7 2022, 6:46 PM · Restricted Project
sameerds updated the diff for D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.

Fixed stale comments that mention the attribute amdgpu-queue-ptr in the positive sense.

Feb 7 2022, 11:00 AM · Restricted Project
sameerds added inline comments to D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.
Feb 7 2022, 8:12 AM · Restricted Project
sameerds added inline comments to D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.
Feb 7 2022, 7:52 AM · Restricted Project

Feb 6 2022

sameerds added a reviewer for D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor: arsenm.
Feb 6 2022, 10:00 AM · Restricted Project
sameerds requested review of D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor.
Feb 6 2022, 9:55 AM · Restricted Project

Jan 31 2022

sameerds added inline comments to D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls..
Jan 31 2022, 8:20 PM · Restricted Project, Restricted Project

Dec 10 2021

sameerds added a comment to D112696: CycleInfo: Introduce cycles as a generalization of loops.

I managed to reproduce the breakage locally with -DLLVM_ENABLE_MODULES=On. With my latest revision, I can see that the error specifically mentioning my files has disappeared, but the build does not complete. @JDevlieghere do you have any advice on perfectly reproducing that build locally? Are there other things to be specified on the cmake line?

Dec 10 2021, 1:13 AM · Restricted Project
sameerds added a reverting change for rG02940d6d2202: Revert "CycleInfo: Introduce cycles as a generalization of loops": rG1d0244aed781: Reapply CycleInfo: Introduce cycles as a generalization of loops.
Dec 10 2021, 1:08 AM
sameerds committed rG1d0244aed781: Reapply CycleInfo: Introduce cycles as a generalization of loops (authored by sameerds).
Reapply CycleInfo: Introduce cycles as a generalization of loops
Dec 10 2021, 1:08 AM
sameerds closed D112696: CycleInfo: Introduce cycles as a generalization of loops.
Dec 10 2021, 1:08 AM · Restricted Project

Dec 8 2021

sameerds added a comment to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Dec 8 2021, 9:25 PM · Restricted Project
sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.
  • rebase
  • The opaque member class Compute broke module builds.
  • Moved compute to an extern template class in namespace llvm.
  • Cleaned out a spurious class declaration that was not used anywhere.
Dec 8 2021, 9:20 PM · Restricted Project
sameerds reopened D112696: CycleInfo: Introduce cycles as a generalization of loops.

Reopening revision to help with pre-submit checks, before reapplying the reverted commit.

Dec 8 2021, 9:19 PM · Restricted Project

Dec 6 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Dec 6 2021, 10:37 PM · Restricted Project
sameerds committed rG0fe61ecc2cef: CycleInfo: Introduce cycles as a generalization of loops (authored by sameerds).
CycleInfo: Introduce cycles as a generalization of loops
Dec 6 2021, 10:37 PM
sameerds closed D112696: CycleInfo: Introduce cycles as a generalization of loops.
Dec 6 2021, 10:36 PM · Restricted Project

Nov 28 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 28 2021, 10:27 PM · Restricted Project
sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.
  • rebase
  • addressed review comments
Nov 28 2021, 10:22 PM · Restricted Project

Nov 23 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 23 2021, 3:59 AM · Restricted Project
sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.
  • rebase
  • removed the "vacuous root" from the cycle description
Nov 23 2021, 3:27 AM · Restricted Project

Nov 22 2021

sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.
  • rebase
  • replace Dfg and Ssa with uppercase versions
  • eliminate any interpretation of nullptr as root cycle
  • move two functions from CycleInfo to Cycle, just like LoopInfo
  • small cleanup to the cycle terminology, pointed out by @nhaehnle
Nov 22 2021, 8:49 PM · Restricted Project
sameerds accepted D114146: [DA][NFC] Update publication - add remarks.
Nov 22 2021, 2:17 AM · Restricted Project

Nov 19 2021

sameerds added a comment to D114146: [DA][NFC] Update publication - add remarks.

All good points. PDT and the comment on strict loop compactness are leftovers. I will remove PDT in a followup patch.

Nov 19 2021, 11:55 PM · Restricted Project
sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 19 2021, 11:46 PM · Restricted Project

Nov 18 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 18 2021, 7:30 PM · Restricted Project
sameerds added a comment to D114146: [DA][NFC] Update publication - add remarks.

Not related to the changes proposed in this review, but it seems the PDT is not used by the implementation. It might be good to take out that dependency.

Nov 18 2021, 6:58 PM · Restricted Project

Nov 12 2021

sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.

rebase

Nov 12 2021, 2:04 AM · Restricted Project

Nov 11 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 11 2021, 2:29 AM · Restricted Project
sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.
  • Fixed some doxygen comments.
  • Eliminated the "root" cycle.
  • Cycle should not point to CycleInfo; it's hard to update that reference. Fixed the side-effects of eliminating that reference.
  • Fixed names mentioned in review comments.
  • Extracted two helper functions: getTopLevelParent() and moveToNewParent(). Both very helpful in improving readability.
  • SsaContext now keeps a reference to the Function so that user analyses can retrieve it. Forward looking change, found to be useful in later analyses not introduced yet.
Nov 11 2021, 2:25 AM · Restricted Project

Nov 5 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 5 2021, 11:18 PM · Restricted Project

Nov 3 2021

sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.

"uint" broke the Windows build

Nov 3 2021, 8:35 PM · Restricted Project

Nov 2 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Nov 2 2021, 1:43 AM · Restricted Project
sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.
  • added specific wording from paper to description of cycle tree
  • added LLVM_DEBUG to implementation
  • fixed typos
Nov 2 2021, 1:39 AM · Restricted Project

Oct 29 2021

sameerds added inline comments to D112696: CycleInfo: Introduce cycles as a generalization of loops.
Oct 29 2021, 3:03 AM · Restricted Project
sameerds updated the diff for D112696: CycleInfo: Introduce cycles as a generalization of loops.

Addressed review comments

Oct 29 2021, 2:50 AM · Restricted Project

Oct 28 2021

sameerds committed rGb437aaa672e8: MachineDominators: Define MachineDomTree type alias (authored by nhaehnle).
MachineDominators: Define MachineDomTree type alias
Oct 28 2021, 10:01 AM