Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

sameerds (Sameer Sahasrabuddhe)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2012, 11:25 AM (570 w, 4 d)

Working on ROCm at AMD

Recent Activity

Mon, Sep 18

sameerds abandoned D153414: [LLVM] Do not speculate convergent calls.

Abandoning. I agree with relying on attribute speculatable. If we figure out the conditions that make a convergent call speculatable, then at that time, we should use the appropriate attribute to record that fact. On the other hand, if speculation of a convergent call is dependent on the surrounding control flow, then we will probably have to do it as a separate optimization.

Mon, Sep 18, 10:58 PM · Restricted Project, Restricted Project

Fri, Sep 1

sameerds updated subscribers of D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.
Fri, Sep 1, 1:47 AM · Restricted Project, Restricted Project

Thu, Aug 31

sameerds added inline comments to rG850ec7bbb18f: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Thu, Aug 31, 9:19 PM · Restricted Project, Restricted Project

Wed, Aug 30

sameerds accepted D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.

LGTM, with a few nits.

Wed, Aug 30, 11:52 PM · Restricted Project, Restricted Project
sameerds added inline comments to D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.
Wed, Aug 30, 4:43 AM · Restricted Project, Restricted Project

Mon, Aug 28

sameerds added a comment to D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.

Bump! Waiting for more info on comments from @arsenm

Mon, Aug 28, 10:09 PM · Restricted Project, Restricted Project

Aug 22 2023

sameerds committed rG0cb6d2f643b2: [LLVM][Convergence] further refactor convergence verifier (authored by sameerds).
[LLVM][Convergence] further refactor convergence verifier
Aug 22 2023, 11:33 PM · Restricted Project, Restricted Project
sameerds closed D158394: [LLVM][Convergence] further refactor convergence verifier.
Aug 22 2023, 11:32 PM · Restricted Project, Restricted Project
sameerds accepted D158477: [AMDGPU] Respect `nobuiltin` when converting `printf`.
Aug 22 2023, 8:53 AM · Restricted Project, Restricted Project
sameerds added inline comments to D158477: [AMDGPU] Respect `nobuiltin` when converting `printf`.
Aug 22 2023, 6:33 AM · Restricted Project, Restricted Project

Aug 21 2023

sameerds abandoned D85606: Inliner: handle the convergence control operand bundle.
Aug 21 2023, 11:50 PM · Restricted Project, Restricted Project
sameerds commandeered D85606: Inliner: handle the convergence control operand bundle.

Superseded by D152431.

Aug 21 2023, 11:49 PM · Restricted Project, Restricted Project
sameerds abandoned D85603: IR: Add convergence control operand bundle and intrinsics.
Aug 21 2023, 11:48 PM · Restricted Project, Restricted Project
sameerds commandeered D85603: IR: Add convergence control operand bundle and intrinsics.

Superseded by D147116

Aug 21 2023, 11:48 PM · Restricted Project, Restricted Project
sameerds added inline comments to D158477: [AMDGPU] Respect `nobuiltin` when converting `printf`.
Aug 21 2023, 11:14 PM · Restricted Project, Restricted Project
sameerds updated the summary of D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.
Aug 21 2023, 10:55 PM · Restricted Project, Restricted Project
sameerds added inline comments to D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.
Aug 21 2023, 10:52 PM · Restricted Project, Restricted Project
sameerds updated the diff for D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.
  • rebased
  • addressed some review comments
  • added machine verifier
Aug 21 2023, 10:50 PM · Restricted Project, Restricted Project
sameerds updated subscribers of D158394: [LLVM][Convergence] further refactor convergence verifier.
Aug 21 2023, 12:51 AM · Restricted Project, Restricted Project
sameerds requested review of D158394: [LLVM][Convergence] further refactor convergence verifier.
Aug 21 2023, 12:51 AM · Restricted Project, Restricted Project

Aug 20 2023

sameerds committed rGef38e6d97f48: [GlobalISel] introduce MIFlag::NoConvergent (authored by sameerds).
[GlobalISel] introduce MIFlag::NoConvergent
Aug 20 2023, 8:47 AM · Restricted Project, Restricted Project
sameerds closed D157475: [GlobalISel] introduce MIFlag::NoConvergent.
Aug 20 2023, 8:47 AM · Restricted Project, Restricted Project

Aug 18 2023

sameerds updated the diff for D157475: [GlobalISel] introduce MIFlag::NoConvergent.
  • updated the lit test to match the changed error message
Aug 18 2023, 1:18 AM · Restricted Project, Restricted Project
sameerds added a comment to D158014: [LLVM][Uniformity] Fix error causing assert on some irreducible control flow.

@AlexM FYI: submitted a different fix in the same location: 4d081560cd3b6ac114aee15f50480dd978b55a44

Aug 18 2023, 12:56 AM · Restricted Project, Restricted Project
sameerds committed rG4d081560cd3b: [Uniformity] fix assert in a cycle made divergent by outside branch (authored by sameerds).
[Uniformity] fix assert in a cycle made divergent by outside branch
Aug 18 2023, 12:56 AM · Restricted Project, Restricted Project

Aug 17 2023

sameerds updated the diff for D157475: [GlobalISel] introduce MIFlag::NoConvergent.
  • rebased
  • fixed formatting near assert
  • added clang-format off/on to allow existing code through pre-checks
Aug 17 2023, 10:23 PM · Restricted Project, Restricted Project
sameerds committed rG09e12d13a04f: [LLVM][Uniformity] Fix error causing assert on some irreducible control flow (authored by AlexM).
[LLVM][Uniformity] Fix error causing assert on some irreducible control flow
Aug 17 2023, 9:19 PM · Restricted Project, Restricted Project
sameerds closed D158014: [LLVM][Uniformity] Fix error causing assert on some irreducible control flow.
Aug 17 2023, 9:18 PM · Restricted Project, Restricted Project
sameerds added reviewers for D158147: [RFC][GlobalISel] convergence control tokens and intrinsics: nhaehnle, foad, critson, ruiling.
Aug 17 2023, 8:08 AM · Restricted Project, Restricted Project

Aug 16 2023

sameerds added reviewers for D158147: [RFC][GlobalISel] convergence control tokens and intrinsics: chapuni, arsenm.
Aug 16 2023, 11:33 PM · Restricted Project, Restricted Project
sameerds requested review of D158147: [RFC][GlobalISel] convergence control tokens and intrinsics.
Aug 16 2023, 11:28 PM · Restricted Project, Restricted Project
sameerds committed rG8dce4c56dd76: [Inliner] Handle convergence control when inlining a call (authored by sameerds).
[Inliner] Handle convergence control when inlining a call
Aug 16 2023, 9:27 PM · Restricted Project, Restricted Project
sameerds closed D152431: [Inliner] Handle convergence control when inlining a call.
Aug 16 2023, 9:26 PM · Restricted Project, Restricted Project
sameerds accepted D158014: [LLVM][Uniformity] Fix error causing assert on some irreducible control flow.

Can you please reword the change description? Rather than talking about the code in terms of if/while, it's more helpful to talk about what is happening. For example, "we should first check for an irreducible outermost cycle before checking if the parent is reducible".

Aug 16 2023, 8:52 PM · Restricted Project, Restricted Project
sameerds added reviewers for D158014: [LLVM][Uniformity] Fix error causing assert on some irreducible control flow: foad, ruiling, nhaehnle.
Aug 16 2023, 3:00 AM · Restricted Project, Restricted Project
sameerds requested changes to D158014: [LLVM][Uniformity] Fix error causing assert on some irreducible control flow.
Aug 16 2023, 2:59 AM · Restricted Project, Restricted Project
sameerds added inline comments to D157475: [GlobalISel] introduce MIFlag::NoConvergent.
Aug 16 2023, 12:04 AM · Restricted Project, Restricted Project
sameerds updated the diff for D157475: [GlobalISel] introduce MIFlag::NoConvergent.
  • rebased
  • machine verifier disallows NoConvergent on opcodes that are not isConvergent
  • new test for the machine verifier
  • added missing comment
Aug 16 2023, 12:02 AM · Restricted Project, Restricted Project

Aug 10 2023

sameerds committed rGff5cb1ec6209: [Verifier] add missing checks for convergence control intrinsics (authored by sameerds).
[Verifier] add missing checks for convergence control intrinsics
Aug 10 2023, 12:58 AM · Restricted Project, Restricted Project

Aug 9 2023

sameerds added a comment to D157475: [GlobalISel] introduce MIFlag::NoConvergent.

I have a mostly updated copy of the noconvergent patch, fixing the remaining tests seems permanently stuck as the #3 thing on my todo list. I've also been debating splitting the existing isConvergent MI property into two halves (doesn't really matter for this patch, it's a lot easier to change MI flags than IR ones)

Aug 9 2023, 9:50 PM · Restricted Project, Restricted Project
sameerds accepted D157389: AutoUpgrade: Use syncscope("agent") atomic.inc/dec intrinsic upgrade.
Aug 9 2023, 9:48 PM · Restricted Project, Restricted Project
sameerds added a comment to D157475: [GlobalISel] introduce MIFlag::NoConvergent.

Adding @xbolva00, @RKSimon and @craig.topper since a lot of thought seems to have been involved when the size of MIFlags was bumped to uint32_t, in D118118. Note that we intend to use this new flag MIFlags::NoConvergent only in GlobalISel.

Aug 9 2023, 2:37 AM · Restricted Project, Restricted Project
sameerds added reviewers for D157475: [GlobalISel] introduce MIFlag::NoConvergent: xbolva00, RKSimon, craig.topper.
Aug 9 2023, 2:36 AM · Restricted Project, Restricted Project

Aug 8 2023

sameerds updated subscribers of D157475: [GlobalISel] introduce MIFlag::NoConvergent.
Aug 8 2023, 10:52 PM · Restricted Project, Restricted Project
sameerds requested review of D157475: [GlobalISel] introduce MIFlag::NoConvergent.
Aug 8 2023, 10:51 PM · Restricted Project, Restricted Project
sameerds added a comment to D157389: AutoUpgrade: Use syncscope("agent") atomic.inc/dec intrinsic upgrade.

What is the "old syncscope parameter" mentioned in the change description? In the actual change and the lit tests, the default "system" scope is being changed to "agent", which superficially looks like an incorrect change.

In the deleted intrinsic. There was an integer syncscope argument which was never actually used. This just needs to try emulating the old intrinsic behavior

Aug 8 2023, 10:13 PM · Restricted Project, Restricted Project
sameerds added a comment to D157389: AutoUpgrade: Use syncscope("agent") atomic.inc/dec intrinsic upgrade.

What is the "old syncscope parameter" mentioned in the change description? In the actual change and the lit tests, the default "system" scope is being changed to "agent", which superficially looks like an incorrect change.

Aug 8 2023, 8:26 AM · Restricted Project, Restricted Project

Aug 7 2023

sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Aug 7 2023, 11:21 PM · Restricted Project, Restricted Project
sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Aug 7 2023, 11:12 PM · Restricted Project, Restricted Project
sameerds committed rGf7031c41eca3: [NFC] strengthen some CHECK-NOT lines (authored by sameerds).
[NFC] strengthen some CHECK-NOT lines
Aug 7 2023, 4:20 AM · Restricted Project, Restricted Project

Aug 4 2023

sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Aug 4 2023, 1:34 AM · Restricted Project, Restricted Project

Aug 2 2023

sameerds committed rGbd7a4d7b2736: Restore "[LLVM] move verification of convergence control to a class template"" (authored by sameerds).
Restore "[LLVM] move verification of convergence control to a class template""
Aug 2 2023, 10:10 PM · Restricted Project, Restricted Project
sameerds closed D156522: [LLVM] move verification of convergence control to a class template.
Aug 2 2023, 10:10 PM · Restricted Project, Restricted Project
sameerds added inline comments to D156522: [LLVM] move verification of convergence control to a class template.
Aug 2 2023, 2:11 AM · Restricted Project, Restricted Project
sameerds updated the diff for D156522: [LLVM] move verification of convergence control to a class template.
  • rebase
  • fix build failures:
    • Shared libraries build failed with undefined references due to "extern template" declarations.
    • Modules build failed due to a cycle dependence between llvm/ADT and llvm/IR. The Generic*Impl.h files should be in llvm/IR to prevent this.
Aug 2 2023, 2:07 AM · Restricted Project, Restricted Project

Aug 1 2023

sameerds committed rGd3718f1e4f10: [LLVM] remove extern template declarations of GenericCycleInfo (authored by sameerds).
[LLVM] remove extern template declarations of GenericCycleInfo
Aug 1 2023, 6:23 AM · Restricted Project, Restricted Project
sameerds reopened D156522: [LLVM] move verification of convergence control to a class template.

Reopened this because of build errors with shared libraries enabled.

Aug 1 2023, 4:54 AM · Restricted Project, Restricted Project
sameerds added a reverting change for rG93a3706711fd: [LLVM] move verification of convergence control to a class template: rG466bd9981150: Revert "[LLVM] move verification of convergence control to a class template".
Aug 1 2023, 4:53 AM · Restricted Project, Restricted Project
sameerds committed rG466bd9981150: Revert "[LLVM] move verification of convergence control to a class template" (authored by sameerds).
Revert "[LLVM] move verification of convergence control to a class template"
Aug 1 2023, 4:52 AM · Restricted Project, Restricted Project
sameerds added a reverting change for D156522: [LLVM] move verification of convergence control to a class template: rG466bd9981150: Revert "[LLVM] move verification of convergence control to a class template".
Aug 1 2023, 4:52 AM · Restricted Project, Restricted Project
sameerds committed rGc599cb5d0a16: [Verifier] Check valid raw_ostream pointer before printing errors (authored by sameerds).
[Verifier] Check valid raw_ostream pointer before printing errors
Aug 1 2023, 2:22 AM · Restricted Project, Restricted Project
sameerds added a comment to D156522: [LLVM] move verification of convergence control to a class template.

this broke my build with:

ld.lld-12: error: undefined symbol: llvm::GenericCycle<llvm::GenericSSAContext<llvm::Function> >::contains(llvm::BasicBlock const*) const
>>> referenced by UniformityAnalysis.cpp:72 (/home/culrho01/llvm-project/llvm/lib/Analysis/UniformityAnalysis.cpp:72)
>>>               lib/Analysis/CMakeFiles/LLVMAnalysis.dir/UniformityAnalysis.cpp.o:(llvm::GenericUniformityAnalysisImpl<llvm::GenericSSAContext<llvm::Function> >::usesValueFromCycle(llvm::Instruction const&, llvm::GenericCycle<llvm::GenericSSAContext<llvm::Function> > const&) const)

please could you look into it?

Aug 1 2023, 2:06 AM · Restricted Project, Restricted Project

Jul 31 2023

sameerds committed rG93a3706711fd: [LLVM] move verification of convergence control to a class template (authored by sameerds).
[LLVM] move verification of convergence control to a class template
Jul 31 2023, 10:53 PM · Restricted Project, Restricted Project
sameerds closed D156522: [LLVM] move verification of convergence control to a class template.
Jul 31 2023, 10:52 PM · Restricted Project, Restricted Project
sameerds accepted D156682: AMDGPU: Partially respect nobuiltin in libcall simplifier.
Jul 31 2023, 6:15 AM · Restricted Project, Restricted Project
sameerds added inline comments to D156682: AMDGPU: Partially respect nobuiltin in libcall simplifier.
Jul 31 2023, 6:13 AM · Restricted Project, Restricted Project
sameerds added inline comments to D156522: [LLVM] move verification of convergence control to a class template.
Jul 31 2023, 1:01 AM · Restricted Project, Restricted Project
sameerds added inline comments to D156522: [LLVM] move verification of convergence control to a class template.
Jul 31 2023, 1:00 AM · Restricted Project, Restricted Project
sameerds updated the diff for D156522: [LLVM] move verification of convergence control to a class template.
  • rebase
  • replaced std::function with function_ref
  • removed the everything capture
  • renamed CheckFailed() to reportFailure() ... more aligned with the coding standard
Jul 31 2023, 12:56 AM · Restricted Project, Restricted Project

Jul 30 2023

sameerds added inline comments to D154766: [GlobalISel] convergent intrinsics.
Jul 30 2023, 11:46 PM · Restricted Project, Restricted Project
sameerds committed rGd9847cde4841: [GlobalISel] convergent intrinsics (authored by sameerds).
[GlobalISel] convergent intrinsics
Jul 30 2023, 11:46 PM · Restricted Project, Restricted Project
sameerds closed D154766: [GlobalISel] convergent intrinsics.
Jul 30 2023, 11:46 PM · Restricted Project, Restricted Project
sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Jul 30 2023, 11:27 PM · Restricted Project, Restricted Project
sameerds committed rGf7b09516e466: [LLVM] Add missing verifier checks for convergence control (authored by sameerds).
[LLVM] Add missing verifier checks for convergence control
Jul 30 2023, 10:38 PM · Restricted Project, Restricted Project

Jul 29 2023

sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Jul 29 2023, 9:49 PM · Restricted Project, Restricted Project

Jul 28 2023

sameerds added reviewers for D156522: [LLVM] move verification of convergence control to a class template: nhaehnle, foad, arsenm, ruiling.
Jul 28 2023, 4:35 AM · Restricted Project, Restricted Project
sameerds requested review of D156522: [LLVM] move verification of convergence control to a class template.
Jul 28 2023, 4:34 AM · Restricted Project, Restricted Project
sameerds updated the diff for D154766: [GlobalISel] convergent intrinsics.
  • rebased
  • replaced the "Explicit" functions with overloads
  • s/Code/Opcode/
  • renamed verifyIntrinsic* functions
Jul 28 2023, 3:13 AM · Restricted Project, Restricted Project

Jul 27 2023

sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Jul 27 2023, 11:11 PM · Restricted Project, Restricted Project
sameerds committed rG7c760b224bc4: Restore "[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic… (authored by sameerds).
Restore "[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic…
Jul 27 2023, 2:22 AM · Restricted Project, Restricted Project
sameerds closed D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
Jul 27 2023, 2:22 AM · Restricted Project, Restricted Project
sameerds added inline comments to D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}.
Jul 27 2023, 2:13 AM · Restricted Project, Restricted Project
sameerds updated the diff for D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
  • fixed missing headers
Jul 27 2023, 12:49 AM · Restricted Project, Restricted Project

Jul 26 2023

sameerds added inline comments to D154766: [GlobalISel] convergent intrinsics.
Jul 26 2023, 10:30 PM · Restricted Project, Restricted Project
sameerds updated the diff for D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
  • reverted and fixed buildbot breakage
  • there were dangling uses of MachineInstr::getIntrinsicID() in other targets
  • note to self: don't forget to check Phab for a successful build before submitting!
Jul 26 2023, 10:16 PM · Restricted Project, Restricted Project
sameerds reopened D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
Jul 26 2023, 10:16 PM · Restricted Project, Restricted Project
sameerds added a reverting change for rGbaa3386edb11: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR: rGd0f7850b01cf: Revert "[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic….
Jul 26 2023, 9:45 PM · Restricted Project, Restricted Project
sameerds committed rGd0f7850b01cf: Revert "[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic… (authored by sameerds).
Revert "[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic…
Jul 26 2023, 9:45 PM · Restricted Project, Restricted Project
sameerds added a reverting change for D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR: rGd0f7850b01cf: Revert "[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic….
Jul 26 2023, 9:45 PM · Restricted Project, Restricted Project
sameerds committed rGbaa3386edb11: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR (authored by sameerds).
[GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR
Jul 26 2023, 9:31 PM · Restricted Project, Restricted Project
sameerds closed D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
Jul 26 2023, 9:31 PM · Restricted Project, Restricted Project
sameerds committed rGb14e30f10daf: [LLVM] refactor GenericSSAContext and its specializations (authored by sameerds).
[LLVM] refactor GenericSSAContext and its specializations
Jul 26 2023, 9:26 PM · Restricted Project, Restricted Project
sameerds closed D156288: [LLVM] refactor GenericSSAContext and its specializations.
Jul 26 2023, 9:25 PM · Restricted Project, Restricted Project

Jul 25 2023

sameerds added inline comments to D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
Jul 25 2023, 11:36 PM · Restricted Project, Restricted Project
sameerds updated the diff for D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.
  • rebased
  • added the GIntrinsic::is() method
  • fixed issues with coding style
Jul 25 2023, 11:32 PM · Restricted Project, Restricted Project
sameerds updated subscribers of D156288: [LLVM] refactor GenericSSAContext and its specializations.
Jul 25 2023, 8:51 PM · Restricted Project, Restricted Project
sameerds requested review of D156288: [LLVM] refactor GenericSSAContext and its specializations.
Jul 25 2023, 8:51 PM · Restricted Project, Restricted Project

Jul 24 2023

sameerds added a comment to D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR.

Bump! This is blocking further changes. Added some more reviewers to get more eyeballs.

Jul 24 2023, 10:44 PM · Restricted Project, Restricted Project
sameerds added reviewers for D155556: [GlobalISel] GIntrinsic subclass to represent intrinsics in Generic Machine IR: aemerson, foad, Petar.Avramovic.
Jul 24 2023, 10:44 PM · Restricted Project, Restricted Project
sameerds accepted D156088: [AMDGPU] - Mark inverse.ballot as not convergent.
Jul 24 2023, 8:59 PM · Restricted Project, Restricted Project