This is an archive of the discontinued LLVM Phabricator instance.

[NewPM][AMDGPU] Port amdgpu-atomic-optimizer
ClosedPublic

Authored by pravinjagtap on Apr 18 2023, 5:08 AM.

Diff Detail

Event Timeline

pravinjagtap created this revision.Apr 18 2023, 5:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 5:08 AM
pravinjagtap requested review of this revision.Apr 18 2023, 5:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 5:08 AM
arsenm added inline comments.Apr 18 2023, 5:36 AM
llvm/test/CodeGen/AMDGPU/global-atomic-scan.ll
3

Don't know why this is introducing a new test. also drop -verify-machineinstrs, it won't do anything for opt

pravinjagtap added inline comments.Apr 18 2023, 6:07 AM
llvm/test/CodeGen/AMDGPU/global-atomic-scan.ll
3

Don't know why this is introducing a new test

Currently there are no tests for atomic optimizer which runs in isolation i.e., only amdgpu-atomic-optimizer pass alone. All existing tests runs complete pipeline.

LGTM. Please wait for a day before committing in case other reviewers have any comments.

gandhi21299 accepted this revision.Apr 18 2023, 9:03 AM
This revision is now accepted and ready to land.Apr 18 2023, 9:03 AM
sameerds accepted this revision.Apr 19 2023, 12:27 AM

LGTM. But please do address all comments before submitting.

llvm/test/CodeGen/AMDGPU/global-atomic-scan.ll
1441

This needs fixing ... newline at the end of file is helpful with a lot of text utilities.

Rebased and addressed comments

pravinjagtap marked 2 inline comments as done.Apr 19 2023, 1:57 AM
arsenm accepted this revision.Apr 19 2023, 6:36 AM
This revision was landed with ongoing or failed builds.Apr 19 2023, 9:31 PM
This revision was automatically updated to reflect the committed changes.