This is an archive of the discontinued LLVM Phabricator instance.

ValueTracking: Delete body of isKnownNeverInfinity
ClosedPublic

Authored by arsenm on Apr 10 2023, 7:48 AM.

Details

Summary

computeKnownFPClass should now handle infinity checks equally as
well as what this could do before so delete the redundant code.

Most of the diff is from threading DataLayout through the various
APIs that call into isKnownNeverInfinity.

Diff Detail

Event Timeline

arsenm created this revision.Apr 10 2023, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 7:48 AM
arsenm requested review of this revision.Apr 10 2023, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 7:48 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 512145.Apr 10 2023, 7:50 AM
foad added a comment.Apr 19 2023, 1:26 AM

How does DataLayout influence a KnownFPClass query?

How does DataLayout influence a KnownFPClass query?

It's used by the Query shared with ComputeKnownBits. Don't know if it actually does anything

foad accepted this revision.Apr 20 2023, 3:07 AM

Seems reasonable, and nice to get rid of the old code.

This revision is now accepted and ready to land.Apr 20 2023, 3:07 AM

Split most of this into 86d0b524f363