This is an archive of the discontinued LLVM Phabricator instance.

ValueTracking: Handle exp/exp2 in computeKnownFPClass
ClosedPublic

Authored by arsenm on Apr 10 2023, 6:43 AM.

Details

Diff Detail

Event Timeline

arsenm created this revision.Apr 10 2023, 6:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 6:43 AM
arsenm requested review of this revision.Apr 10 2023, 6:43 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
kpn added inline comments.Apr 13 2023, 6:35 AM
llvm/lib/Analysis/ValueTracking.cpp
4555

Infinity. In chapter 9.2.1 of 754-2019 it defines exp(0) and exp2(0) as 1. Since we know this isn't infinity, it seems like now is a good time to add a check?

llvm/lib/Analysis/ValueTracking.cpp
4555

exp/exp2 is never a negative number, not even -0 (exp(-inf) = +0).

arsenm updated this revision to Diff 514286.Apr 17 2023, 10:00 AM

Never negative

jcranmer-intel accepted this revision.Apr 21 2023, 1:24 PM
This revision is now accepted and ready to land.Apr 21 2023, 1:24 PM