This is an archive of the discontinued LLVM Phabricator instance.

Differential D147695

[ReleaseNotes] DebugInfo: preferred_name attribute changes
ClosedPublic

Authored by Michael137 on Apr 6 2023, 3:07 AM.

Details

Reviewers
aprantl
dblaikie
Commits
rG8b0033e58a49: [ReleaseNotes] DebugInfo: preferred_name attribute changes
Summary

Describes changes made in D145803.

Diff Detail

Event Timeline

Michael137 created this revision.Apr 6 2023, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 3:07 AM
Michael137 requested review of this revision.Apr 6 2023, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 3:07 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Michael137 added a parent revision: D145832: [lldb][test] Add tests for clang::PreferredNameAttr formatting.Apr 6 2023, 3:07 AM
Michael137 edited parent revisions, added: D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available; removed: D145832: [lldb][test] Add tests for clang::PreferredNameAttr formatting.
Michael137 updated this revision to Diff 511349.Apr 6 2023, 3:09 AM
  • Fix formatting
  • Add link
Harbormaster completed remote builds in B223965: Diff 511349.Apr 6 2023, 5:10 AM
aprantl accepted this revision.Apr 6 2023, 4:44 PM
aprantl added inline comments.
llvm/docs/ReleaseNotes.rst
212

maybe use the actual flag in the wording here because the reader might not know that tuning means in this context?

This revision is now accepted and ready to land.Apr 6 2023, 4:44 PM
Michael137 updated this revision to Diff 511568.Apr 6 2023, 5:37 PM
  • Describe LLDB tuning more explicitly
This revision was landed with ongoing or failed builds.Apr 6 2023, 5:38 PM
Closed by commit rG8b0033e58a49: [ReleaseNotes] DebugInfo: preferred_name attribute changes (authored by Michael137). · Explain Why
This revision was automatically updated to reflect the committed changes.
Michael137 added a commit: rG8b0033e58a49: [ReleaseNotes] DebugInfo: preferred_name attribute changes.
Harbormaster completed remote builds in B224138: Diff 511568.Apr 6 2023, 6:58 PM

Revision Contents

PathSize
llvm/
docs/
4 lines

Diff 511347

llvm/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 201 Lines • ▼ Show 20 Lines
* The ``DW_AT_name`` on ``DW_AT_typedef``\ s for alias templates will now omit * The ``DW_AT_name`` on ``DW_AT_typedef``\ s for alias templates will now omit
defaulted template parameters. (`D142268 <https://reviews.llvm.org/D142268>`_) defaulted template parameters. (`D142268 <https://reviews.llvm.org/D142268>`_)
* The experimental ``@llvm.dbg.addr`` intrinsic has been removed (`D144801 * The experimental ``@llvm.dbg.addr`` intrinsic has been removed (`D144801
<https://reviews.llvm.org/D144801>`_). IR inputs with this intrinsic are <https://reviews.llvm.org/D144801>`_). IR inputs with this intrinsic are
auto-upgraded to ``@llvm.dbg.value`` with ``DW_OP_deref`` appended to the auto-upgraded to ``@llvm.dbg.value`` with ``DW_OP_deref`` appended to the
``DIExpression`` (`D144793 <https://reviews.llvm.org/D144793>`_). ``DIExpression`` (`D144793 <https://reviews.llvm.org/D144793>`_).
* When a template class annotated with the `[[clang::preferred_name]]` attribute
were to appear in a `DW_AT_type`, the type will now be that of the preferred_name
instead. This is only enabled when tuned for LLDB at the moment.
aprantlUnsubmitted
Not Done
ReplyInline Actions

maybe use the actual flag in the wording here because the reader might not know that tuning means in this context?

aprantl: maybe use the actual flag in the wording here because the reader might not know that tuning…
Changes to the LLVM tools Changes to the LLVM tools
--------------------------------- ---------------------------------
* llvm-lib now supports the /def option for generating a Windows import library from a definition file. * llvm-lib now supports the /def option for generating a Windows import library from a definition file.
* Made significant changes to JSON output format of `llvm-readobj`/`llvm-readelf` * Made significant changes to JSON output format of `llvm-readobj`/`llvm-readelf`
to improve correctness and clarity. to improve correctness and clarity.
Changes to LLDB Changes to LLDB
Show All 32 Lines