This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Enable "Type set is empty for each HW mode" error in non-debug builds
ClosedPublic

Authored by foad on Mar 29 2023, 2:42 AM.

Diff Detail

Event Timeline

foad created this revision.Mar 29 2023, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2023, 2:42 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
foad requested review of this revision.Mar 29 2023, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2023, 2:42 AM
foad added a comment.Mar 29 2023, 2:43 AM

I could not measure any consistent slow-down when building lib/Target/AMDGPU/AMDGPUGenDAGISel.inc with this patch.

arsenm added inline comments.Mar 29 2023, 4:21 AM
llvm/utils/TableGen/CodeGenDAGPatterns.cpp
890–891

Should switch these to errs

897–898

I thought dumps had a separate macro which was implied by NDEBUG

foad marked 2 inline comments as done.Mar 29 2023, 5:52 AM
arsenm accepted this revision.Mar 30 2023, 9:47 AM
arsenm added inline comments.
llvm/utils/TableGen/CodeGenDAGPatterns.cpp
890

Could just move this to limit the part with the dumps and still print the error

This revision is now accepted and ready to land.Mar 30 2023, 9:47 AM
foad added inline comments.Mar 30 2023, 9:52 AM
llvm/utils/TableGen/CodeGenDAGPatterns.cpp
890

We print the error unconditionally in the PrintFatalError call below. The only reason for these errs() is to provide a bit of context for the dump()s.

Joe_Nash accepted this revision.Mar 30 2023, 12:02 PM

I think this can catch bugs earlier, LGTM.

This revision was landed with ongoing or failed builds.Mar 31 2023, 1:14 AM
This revision was automatically updated to reflect the committed changes.