This is an archive of the discontinued LLVM Phabricator instance.

[clang] Remove mips target triple for Android
ClosedPublic

Authored by hiraditya on Mar 21 2023, 2:32 PM.

Details

Summary

thanks to @enh for pointing these out.

Diff Detail

Event Timeline

hiraditya created this revision.Mar 21 2023, 2:32 PM
hiraditya requested review of this revision.Mar 21 2023, 2:32 PM
srhines requested changes to this revision.Mar 21 2023, 2:39 PM

You probably need to remove the tests that use these triples (or switch them to a non-Android variant).

This revision now requires changes to proceed.Mar 21 2023, 2:39 PM
hiraditya updated this revision to Diff 507131.Mar 21 2023, 2:54 PM

Removed testcases.

hiraditya updated this revision to Diff 507171.Mar 21 2023, 4:19 PM

Removed several testcases related to 'mips.*-linux-android'

Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 4:19 PM
srhines accepted this revision.Mar 21 2023, 6:16 PM

Thank you for taking the time to properly remove this.

This revision is now accepted and ready to land.Mar 21 2023, 6:16 PM
MaskRay accepted this revision.Mar 21 2023, 8:15 PM

LG! llvm/test/CodeGen/Mips/ tests are unrelated to the driver change and the part should be committed separately.

LG! llvm/test/CodeGen/Mips/ tests are unrelated to the driver change and the part should be committed separately.

sgtm. i'll commit that separately.

Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 1:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript