[clang-tidy] Add readability-reference-to-constructed-temporary check

[PiotrZSL]

Summary

Detects code where a temporary object is directly constructed by calling
a constructor or using an initializer list and immediately assigned to a
reference variable.

[PiotrZSL]

There are 2 issues found in llvm repository:

• llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp:721:22: warning: reference variable 'S' extends the lifetime of a just-constructed temporary object 'const StringRef', consider changing reference to value [readability-reference-to-constructed-temporary]
• clang/lib/Sema/SemaChecking.cpp:10096:36: warning: reference variable 'AT2' extends the lifetime of a just-constructed temporary object 'const analyze_printf::ArgType', consider changing reference to value [readability-reference-to-constructed-temporary]

[Eugene.Zelenko]

clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp

23

const auto *.

27

Ditto.

clang-tools-extra/test/clang-tidy/checkers/readability/reference-to-constructed-temporary.cpp

32

Excessive newline.

[PiotrZSL]

Review comment fixes

[PiotrZSL]

Ping + Rebase

[PiotrZSL]

Ping