Page MenuHomePhabricator
Differential D146055

[AArch64] Change GeneratePerfectShuffle to return one destination operand for zip and transpose operations.
ClosedPublic
Actions

Authored by zjaffal on Tue, Mar 14, 8:27 AM.

Details

Reviewers
t.p.northover
dmgreen
fhahn
Commits
rG4b09d7a8ac11: [AArch64] Change GeneratePerfectShuffle to return one destination operand for…
Summary

The tests added where crashing because zip instruction was returning two destination operands. ZIP according to arm returns only one destination operand.

Diff Detail

Event Timeline

zjaffal created this revision.Tue, Mar 14, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 8:27 AM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
zjaffal requested review of this revision.Tue, Mar 14, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 8:27 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B219366: Diff 505114.Tue, Mar 14, 9:16 AM
dmgreen added a subscriber: dmgreen.Tue, Mar 14, 2:20 PM

Does this fix https://github.com/llvm/llvm-project/issues/61203?

zjaffal added a comment.Wed, Mar 15, 2:39 AM
In D146055#4194607, @dmgreen wrote:

Does this fix https://github.com/llvm/llvm-project/issues/61203?

I verified it just now this should resolve it as well

dmgreen accepted this revision.Wed, Mar 15, 10:18 AM

Thanks. Sometimes you wonder how things ever worked. LGTM.

This revision is now accepted and ready to land.Wed, Mar 15, 10:18 AM
fhahn accepted this revision.Wed, Mar 15, 10:39 AM
fhahn added a subscriber: fhahn.

LGTM, thanks!

Herald added a subscriber: StephenFan. · View Herald TranscriptWed, Mar 15, 10:39 AM
This revision was landed with ongoing or failed builds.Wed, Mar 15, 2:05 PM
Closed by commit rG4b09d7a8ac11: [AArch64] Change GeneratePerfectShuffle to return one destination operand for… (authored by zjaffal). · Explain Why
This revision was automatically updated to reflect the committed changes.
zjaffal added a commit: rG4b09d7a8ac11: [AArch64] Change GeneratePerfectShuffle to return one destination operand for….

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AArch64/
18 lines
test/
CodeGen/
AArch64/
64 lines

Diff 505617

View Options

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

Loading...
View Options

llvm/test/CodeGen/AArch64/arm64-zip.ll

Loading...