Page MenuHomePhabricator

[AArch64] Change GeneratePerfectShuffle to return one destination operand for zip and transpose operations.
ClosedPublic

Authored by zjaffal on Tue, Mar 14, 8:27 AM.

Details

Summary

The tests added where crashing because zip instruction was returning two destination operands. ZIP according to arm returns only one destination operand.

Diff Detail

Event Timeline

zjaffal created this revision.Tue, Mar 14, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 8:27 AM
zjaffal requested review of this revision.Tue, Mar 14, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 8:27 AM

I verified it just now this should resolve it as well

dmgreen accepted this revision.Wed, Mar 15, 10:18 AM

Thanks. Sometimes you wonder how things ever worked. LGTM.

This revision is now accepted and ready to land.Wed, Mar 15, 10:18 AM
fhahn accepted this revision.Wed, Mar 15, 10:39 AM
fhahn added a subscriber: fhahn.

LGTM, thanks!

This revision was landed with ongoing or failed builds.Wed, Mar 15, 2:05 PM
This revision was automatically updated to reflect the committed changes.