This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Multiple fixes to bugprone-exception-escape
AbandonedPublic

Authored by PiotrZSL on Mar 12 2023, 4:09 AM.

Details

Summary

Diff Detail

Event Timeline

PiotrZSL created this revision.Mar 12 2023, 4:09 AM
Herald added a project: Restricted Project. · View Herald Transcript
PiotrZSL requested review of this revision.Mar 12 2023, 4:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2023, 4:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added inline comments.
clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp
491–495

Please don't use auto unless type is explicitly stated in same statement or iterator.

514–517

Ditto.

clang-tools-extra/docs/ReleaseNotes.rst
217

Please keep alphabetical order (by check name) in this section.

PiotrZSL marked 3 inline comments as done.Mar 12 2023, 8:45 AM
PiotrZSL updated this revision to Diff 504444.Mar 12 2023, 8:48 AM

Review fixes

PiotrZSL updated this revision to Diff 504448.Mar 12 2023, 8:53 AM

Update documentation

This change obsoletes D115118 and D134588.

LegalizeAdulthood resigned from this revision.Mar 29 2023, 8:00 AM
PiotrZSL updated this revision to Diff 513691.Apr 14 2023, 11:34 AM

Ping + Rebase

There's a lot of changes in this patch (at least 6 as per commit message) - please split into smaller patches fixing 1 problem at a time.

PiotrZSL abandoned this revision.Apr 15 2023, 8:41 AM