This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Introduce option to allow magic numbers in type aliases
AbandonedPublic

Authored by florianhumblot on Mar 10 2023, 3:28 AM.

Details

Reviewers
njames93
Summary

This commit introduces an option to the readability-magic-values checker.
The option defaults to false so that the behavior of the checker doesn't change unless specifically enabled.
These commits are supposed to fix https://github.com/llvm/llvm-project/issues/61259

Diff Detail

Event Timeline

florianhumblot created this revision.Mar 10 2023, 3:28 AM
florianhumblot requested review of this revision.Mar 10 2023, 3:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 3:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Merge those commits under D145778, no need for separate review. (git rebase -i HEAD~3)

PiotrZSL added inline comments.Mar 10 2023, 3:37 AM
clang-tools-extra/docs/ReleaseNotes.rst
198

is set to true, not false.

florianhumblot abandoned this revision.Mar 10 2023, 4:24 AM

Accidentally opened this one with arcanist. The changes have been moved to https://reviews.llvm.org/D145778