Page MenuHomePhabricator
People florianhumblot

florianhumblot (Florian Humblot)
User

Projects

User does not belong to any projects.

User Details

User Since
Fri, Mar 10, 1:58 AM (2 w, 10 h)

Recent Activity
View All

Fri, Mar 10

florianhumblot added a comment to D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..
In D145778#4184611, @PiotrZSL wrote:

What should I put as commit author ?
I'm asking because this is diff, and commit author looks to be attached to it.

Fri, Mar 10, 5:47 AM · Restricted Project, Restricted Project
florianhumblot added a comment to D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..
In D145778#4184530, @PiotrZSL wrote:

LGTM

Fri, Mar 10, 5:12 AM · Restricted Project, Restricted Project
florianhumblot updated the diff for D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..

Generate diff with full context and updated the example to use the default settings of the readabiliy-magic-numbers checker

Fri, Mar 10, 4:39 AM · Restricted Project, Restricted Project
florianhumblot abandoned D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases.

Accidentally opened this one with arcanist. The changes have been moved to https://reviews.llvm.org/D145778

Fri, Mar 10, 4:24 AM · Restricted Project, Restricted Project
florianhumblot updated the diff for D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..

Made it so that the proposed change doesn't change the default behavior of the check.
Introduce an option to allow enabling the exclusion.

Fri, Mar 10, 4:06 AM · Restricted Project, Restricted Project
florianhumblot requested review of D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases.
Fri, Mar 10, 3:28 AM · Restricted Project, Restricted Project
florianhumblot requested review of D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..
Fri, Mar 10, 2:31 AM · Restricted Project, Restricted Project