This is an archive of the discontinued LLVM Phabricator instance.

[mlir][MemRef] Add ValueBoundsOpInterface impls
ClosedPublic

Authored by springerm on Mar 9 2023, 8:15 AM.

Diff Detail

Event Timeline

springerm created this revision.Mar 9 2023, 8:15 AM
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Mar 9 2023, 8:15 AM
springerm retitled this revision from [mlir][linalg] ValueBoundsOpInterface: Add memref ops to [mlir][MemRef] Add ValueBoundsOpInterface impls.Mar 16 2023, 8:15 AM
springerm updated this revision to Diff 509964.Mar 31 2023, 3:28 AM

update API

dcaballe accepted this revision.Mar 31 2023, 12:17 PM
dcaballe added inline comments.
mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
108

-> i =0, end = getType().getRank()

mlir/lib/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.cpp
30

ok, this seems to be common so I'm guessing the operator == is overloaded?

This revision is now accepted and ready to land.Mar 31 2023, 12:17 PM
springerm marked 2 inline comments as done.Apr 5 2023, 6:33 PM
springerm added inline comments.
mlir/lib/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.cpp
30

Yes, this is the new API that jpienaar suggested.

This revision was automatically updated to reflect the committed changes.
springerm marked an inline comment as done.