This is an archive of the discontinued LLVM Phabricator instance.

Differential D145140

[llvm-lib] update ReleaseNotes for llvm-lib's new support for generating an import library from a definition file
ClosedPublic

Authored by vadikp-intel on Mar 1 2023, 8:47 PM.

Details

Reviewers
mstorsjo
hans
Commits
rG56e8fd6f6a84: [llvm-lib] update ReleaseNotes for llvm-lib's new support for generating

Diff Detail

Unit TestsFailed

TimeTest
60,110 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
60,040 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

vadikp-intel created this revision.Mar 1 2023, 8:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 8:47 PM
vadikp-intel requested review of this revision.Mar 1 2023, 8:47 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptMar 1 2023, 8:47 PM
Harbormaster completed remote builds in B216899: Diff 501743.Mar 1 2023, 9:41 PM
hans added inline comments.Mar 2 2023, 1:12 AM
llvm/docs/ReleaseNotes.rst
173

I'd suggest mentioning that this is the "/def" option

How about: "llvm-lib now supports the /def option for generating a Windows import library from a definition file."

vadikp-intel updated this revision to Diff 501930.Mar 2 2023, 11:18 AM

addressed feedback

vadikp-intel marked an inline comment as done.Mar 2 2023, 11:19 AM
Harbormaster completed remote builds in B217018: Diff 501930.Mar 2 2023, 12:25 PM
hans accepted this revision.Mar 3 2023, 5:40 AM

lgtm, thanks!

This revision is now accepted and ready to land.Mar 3 2023, 5:40 AM
This revision was landed with ongoing or failed builds.Mar 3 2023, 10:58 AM
Closed by commit rG56e8fd6f6a84: [llvm-lib] update ReleaseNotes for llvm-lib's new support for generating (authored by vadikp-intel). · Explain Why
This revision was automatically updated to reflect the committed changes.
vadikp-intel added a commit: rG56e8fd6f6a84: [llvm-lib] update ReleaseNotes for llvm-lib's new support for generating.

Revision Contents

PathSize
llvm/
docs/
1 line

Diff 501930

llvm/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 164 Lines • ▼ Show 20 Lines* The DWARFv5 feature of attaching `DW_AT_default_value` to defaulted template
parameters will now be available in any non-strict DWARF mode and in a wider parameters will now be available in any non-strict DWARF mode and in a wider
range of cases than previously. (`D139953 <https://reviews.llvm.org/D139953>`_, `D139988 <https://reviews.llvm.org/D139988>`_) range of cases than previously. (`D139953 <https://reviews.llvm.org/D139953>`_, `D139988 <https://reviews.llvm.org/D139988>`_)
* The `DW_AT_name` on `DW_AT_typedef`s for alias templates will now omit defaulted * The `DW_AT_name` on `DW_AT_typedef`s for alias templates will now omit defaulted
template parameters. (`D142268 <https://reviews.llvm.org/D142268>`_) template parameters. (`D142268 <https://reviews.llvm.org/D142268>`_)
Changes to the LLVM tools Changes to the LLVM tools
--------------------------------- ---------------------------------
* llvm-lib now supports the /def option for generating a Windows import library from a definition file.
hansUnsubmitted
Done
ReplyInline Actions

I'd suggest mentioning that this is the "/def" option

How about: "llvm-lib now supports the /def option for generating a Windows import library from a definition file."

hans: I'd suggest mentioning that this is the "/def" option How about: "llvm-lib now supports the…
Changes to LLDB Changes to LLDB
--------------------------------- ---------------------------------
* In the results of commands such as `expr` and `frame var`, type summaries will now * In the results of commands such as `expr` and `frame var`, type summaries will now
omit defaulted template parameters. The full template parameter list can still be omit defaulted template parameters. The full template parameter list can still be
viewed with `expr --raw-output`/`frame var --raw-output`. (`D141828 <https://reviews.llvm.org/D141828>`_) viewed with `expr --raw-output`/`frame var --raw-output`. (`D141828 <https://reviews.llvm.org/D141828>`_)
Show All 23 Lines