This is an archive of the discontinued LLVM Phabricator instance.

Rename DebugAction to tracing::Action and move related code from lib/Support to lib/IR and lib/Debug
ClosedPublic

Authored by mehdi_amini on Feb 25 2023, 10:18 PM.

Details

Summary

This is a preparation for adding support for more infrastructure around the concept
of Action and make tracing Action more of a first class concept.
The doc will be updated later in a subsequent revision after the changes are
completed.

Action belongs to IR because of circular dependency: Actions are dispatched through
the MLIRContext but Action will learn to encapsulate IR construct.

Diff Detail

Event Timeline

mehdi_amini created this revision.Feb 25 2023, 10:18 PM
mehdi_amini requested review of this revision.Feb 25 2023, 10:18 PM
rriddle accepted this revision.Feb 27 2023, 9:36 AM
rriddle added inline comments.
mlir/include/mlir/IR/Action.h
29–32

Why are any of these needed?

mlir/unittests/Debug/DebugCounterTest.cpp
25

Why is this not CounterAction::tag?

This revision is now accepted and ready to land.Feb 27 2023, 9:36 AM
This revision was landed with ongoing or failed builds.Mar 6 2023, 7:12 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini marked an inline comment as done.
mehdi_amini marked an inline comment as done.Mar 6 2023, 7:14 AM
mehdi_amini added inline comments.
mlir/include/mlir/IR/Action.h
29–32

They aren't anymore, removed.

mlir/unittests/Debug/DebugCounterTest.cpp
25

Wasn't possible in a past iteration of the development, fixed now, thanks!