This is an archive of the discontinued LLVM Phabricator instance.

[mlir][IR] Trigger notifyOperationModified for replacements

Authored by springerm on Feb 22 2023, 3:16 AM.



Each user of the original value is modified in-place. Therefore, the corresponding notification should be triggered.

Also fixes a bug where RewriterBase::mergeBlocks did not notify the GreedyPatternRewriteDriver when replacing uses of block arguments. This function does not trigger "operation replaced" notifications, so the GreedyPatternRewriteDriver was not made aware of such IR changes.

Depends On: D144193

Diff Detail

Event Timeline

springerm created this revision.Feb 22 2023, 3:16 AM
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Feb 22 2023, 3:16 AM
springerm edited the summary of this revision. (Show Details)Feb 23 2023, 9:09 AM

please add a test

springerm updated this revision to Diff 501814.Mar 2 2023, 2:45 AM

address comments: add test case

rriddle accepted this revision.Mar 3 2023, 9:50 AM
This revision is now accepted and ready to land.Mar 3 2023, 9:50 AM
This revision was landed with ongoing or failed builds.Mar 6 2023, 1:08 AM
This revision was automatically updated to reflect the committed changes.