Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[mlir][GPU] Fix incorrect API usage in RewritePatterns
ClosedPublic
Actions

Authored by springerm on Feb 23 2023, 3:42 AM.

Details

Reviewers

guraypp
bondhugula
ThomasRaoux
nicolasvasilache
herhut

Commits

rGc080c1f48212: [mlir][GPU] Fix incorrect API usage in RewritePatterns

Summary

Incorrect API usage was detected by D144552.

Depends On: D144549

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

springerm created this revision.Feb 23 2023, 3:42 AM

Herald added a reviewer: bondhugula. · View Herald TranscriptFeb 23 2023, 3:42 AM

Herald added a reviewer: ThomasRaoux. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 23 others. · View Herald Transcript

springerm requested review of this revision.Feb 23 2023, 3:42 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 23 2023, 3:42 AM

Herald added a reviewer: herhut. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

springerm added a parent revision: D144549: [mlir][IR] Trigger notifyOperationModified for replacements.Feb 23 2023, 3:42 AM

Harbormaster completed remote builds in B215478: Diff 499796.Feb 23 2023, 3:42 AM

Nice that your change can detect this.

This revision is now accepted and ready to land.Feb 23 2023, 3:53 AM

This revision was landed with ongoing or failed builds.Feb 23 2023, 9:20 AM

Closed by commit rGc080c1f48212: [mlir][GPU] Fix incorrect API usage in RewritePatterns (authored by springerm). · Explain Why

This revision was automatically updated to reflect the committed changes.

springerm added a commit: rGc080c1f48212: [mlir][GPU] Fix incorrect API usage in RewritePatterns.

Revision Contents
Changeset List

Path

Size

mlir/

lib/

Dialect/

GPU/

IR/

GPUDialect.cpp

2 lines

Diff 499894

View Options

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp