Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D144636

[mlir][SCF] Fix incorrect API usage in RewritePatterns
ClosedPublic
Actions

Authored by springerm on Feb 23 2023, 3:29 AM.

Details

Reviewers
mehdi_amini
Mogball
rriddle
nicolasvasilache
Commits
rG61f37758048c: [mlir][SCF] Fix incorrect API usage in RewritePatterns
Summary

Incorrect API usage was detected by D144552.

Depends On: D144549

Diff Detail

Event Timeline

springerm created this revision.Feb 23 2023, 3:29 AM
Herald added a reviewer: rriddle. · View Herald TranscriptFeb 23 2023, 3:29 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, bzcheeseman, sdasgup3 and 20 others. · View Herald Transcript
springerm requested review of this revision.Feb 23 2023, 3:29 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 23 2023, 3:30 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
springerm added a parent revision: D144549: [mlir][IR] Trigger notifyOperationModified for replacements.Feb 23 2023, 3:30 AM
Harbormaster completed remote builds in B215474: Diff 499792.Feb 23 2023, 3:30 AM
nicolasvasilache accepted this revision.Feb 23 2023, 3:40 AM

Fantastic, thank you @springerm !

This revision is now accepted and ready to land.Feb 23 2023, 3:40 AM
This revision was landed with ongoing or failed builds.Feb 27 2023, 12:43 AM
Closed by commit rG61f37758048c: [mlir][SCF] Fix incorrect API usage in RewritePatterns (authored by springerm). · Explain Why
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rG61f37758048c: [mlir][SCF] Fix incorrect API usage in RewritePatterns.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
IR/
5 lines
lib/
Dialect/
SCF/
IR/
35 lines
Transforms/
9 lines
8 lines
test/
Dialect/
SCF/
29 lines

Diff 500686

View Options

mlir/include/mlir/IR/PatternMatch.h

Loading...
View Options

mlir/lib/Dialect/SCF/IR/SCF.cpp

Loading...
View Options

mlir/lib/Dialect/SCF/Transforms/ForToWhile.cpp

Loading...
View Options

mlir/lib/Dialect/SCF/Transforms/LoopSpecialization.cpp

Loading...
View Options

mlir/test/Dialect/SCF/canonicalize.mlir

Loading...