[clang-tidy] Add bugprone-chained-comparison check
Needs ReviewPublic
Actions

Authored by PiotrZSL on Mon, Feb 20, 1:19 PM.

Details

Reviewers

njames93
carlosgalvezp
LegalizeAdulthood

Summary

Check that flags chained comparison expressions,
such as a < b < c or a == b == c, which may have
unintended behavior due to implicit operator
associativity.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

PiotrZSL created this revision.Mon, Feb 20, 1:19 PM

Herald added a reviewer: njames93. · View Herald TranscriptMon, Feb 20, 1:19 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript

Note that looks like there is currently in implementation new warning -Wcomparison-op-parentheses under D142800, that warning currently handle only chained comparison by using BinaryOperator, not by using CXXOperatorCallExpr.
Scope of "-Wcomparison-op-parentheses" and whatever that warning will be delivered in LLVM 17 will determinate future of this check.
This check is feature-complete.

Harbormaster completed remote builds in B214841: Diff 498945.Mon, Feb 20, 1:38 PM

PiotrZSL published this revision for review.Mon, Feb 20, 1:43 PM

Herald added a project: Restricted Project. · View Herald TranscriptMon, Feb 20, 1:43 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

PiotrZSL added a reviewer: carlosgalvezp.Tue, Feb 21, 2:45 PM

Ping, Rebase

Harbormaster completed remote builds in B218060: Diff 503312.Wed, Mar 8, 5:05 AM

Rebase due to broken baseline

Harbormaster completed remote builds in B218096: Diff 503362.Wed, Mar 8, 7:47 AM

PiotrZSL added a reviewer: LegalizeAdulthood.Tue, Mar 14, 12:33 PM