Page MenuHomePhabricator
Differential D144072

[mlir] Add loop bounds to scf.foreach_thread.
ClosedPublic
Actions

Authored by pifon2a on Feb 14 2023, 11:14 PM.

Details

Reviewers
nicolasvasilache
springerm
bondhugula
ThomasRaoux
ftynse
herhut
chelini
Commits
rG310deca248c8: [mlir] Add loop bounds to scf.foreach_thread.
Summary

https://discourse.llvm.org/t/rfc-parallel-loops-on-tensors-in-mlir/68332

Diff Detail

Event Timeline

pifon2a created this revision.Feb 14 2023, 11:14 PM
Herald added a reviewer: bondhugula. · View Herald TranscriptFeb 14 2023, 11:14 PM
Herald added a reviewer: ThomasRaoux. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, Moerafaat, zero9178 and 25 others. · View Herald Transcript
pifon2a requested review of this revision.Feb 14 2023, 11:14 PM
Herald added a reviewer: herhut. · View Herald TranscriptFeb 14 2023, 11:14 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
pifon2a added a reviewer: chelini.Feb 14 2023, 11:23 PM
Harbormaster completed remote builds in B213809: Diff 497554.Feb 14 2023, 11:34 PM
chelini added a comment.Feb 15 2023, 12:10 AM

Would it make sense to split this PR into two: rename and addition of step/lb/ub?

pifon2a added a comment.Feb 15 2023, 12:20 AM
In D144072#4128191, @chelini wrote:

Would it make sense to split this PR into two: rename and addition of step/lb/ub?

I would prefer doing it in one.

nicolasvasilache added a comment.Feb 15 2023, 2:06 AM
In D144072#4128209, @pifon2a wrote:
In D144072#4128191, @chelini wrote:

Would it make sense to split this PR into two: rename and addition of step/lb/ub?

I would prefer doing it in one.

Please reconsider, the important logic changes that need to be reviewed independently are drowned into the massive NFC cruft ..

pifon2a updated this revision to Diff 497604.Feb 15 2023, 2:36 AM

Update.

pifon2a added a comment.Feb 15 2023, 2:37 AM

Reconsidered :)

pifon2a updated this revision to Diff 497605.Feb 15 2023, 2:38 AM

Revert unchanged file.

Harbormaster completed remote builds in B213847: Diff 497605.Feb 15 2023, 3:15 AM
pifon2a added a comment.Feb 15 2023, 6:19 AM

"Is anybody out there?"

pifon2a retitled this revision from [mlir] Add loop bounds to scf.foreach_thread and rename it to scf.forall. to [mlir] Add loop bounds to scf.foreach_thread..Feb 15 2023, 6:19 AM
mehdi_amini added inline comments.Feb 15 2023, 9:26 AM
mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
518

I suspect the doc should have some updates?

mlir/lib/Dialect/SCF/Transforms/BufferizableOpInterfaceImpl.cpp
1148

This is testing if it has 1 or more steps, but the comment says "if it has just a single step."

pifon2a marked 2 inline comments as done.Feb 16 2023, 12:28 PM
pifon2a updated this revision to Diff 498122.Feb 16 2023, 12:29 PM

Introduce mixed form.

pifon2a updated this revision to Diff 498123.Feb 16 2023, 12:31 PM

Update.

nicolasvasilache accepted this revision.Feb 16 2023, 12:54 PM

Looks great, thanks much @pifon2a !

This revision is now accepted and ready to land.Feb 16 2023, 12:54 PM
Harbormaster completed remote builds in B214237: Diff 498123.Feb 16 2023, 2:11 PM
pifon2a updated this revision to Diff 498259.Feb 16 2023, 11:30 PM

remove logging

pifon2a updated this revision to Diff 498260.Feb 16 2023, 11:37 PM

rebase

pifon2a updated this revision to Diff 498262.Feb 16 2023, 11:55 PM

Update tests

This revision was landed with ongoing or failed builds.Feb 16 2023, 11:58 PM
Closed by commit rG310deca248c8: [mlir] Add loop bounds to scf.foreach_thread. (authored by pifon2a). · Explain Why
This revision was automatically updated to reflect the committed changes.
pifon2a added a commit: rG310deca248c8: [mlir] Add loop bounds to scf.foreach_thread..
Harbormaster completed remote builds in B214337: Diff 498262.Feb 17 2023, 12:15 AM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SCF/
IR/
156 lines
Interfaces/
15 lines
lib/
Dialect/
GPU/
TransformOps/
31 lines
Linalg/
Transforms/
14 lines
SCF/
IR/
232 lines
Transforms/
44 lines
8 lines
Interfaces/
46 lines
test/
Dialect/
Linalg/
21 lines
9 lines
SCF/
49 lines
Tensor/
3 lines
lib/
Dialect/
Tensor/
9 lines

Diff 498263

View Options

mlir/include/mlir/Dialect/SCF/IR/SCFOps.td

Loading...
View Options

mlir/include/mlir/Interfaces/ViewLikeInterface.h

Loading...
View Options

mlir/lib/Dialect/GPU/TransformOps/GPUTransformOps.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp

Loading...
View Options

mlir/lib/Dialect/SCF/IR/SCF.cpp

Loading...
View Options

mlir/lib/Dialect/SCF/Transforms/BufferizableOpInterfaceImpl.cpp

Loading...
View Options

mlir/lib/Dialect/SCF/Transforms/LoopCanonicalization.cpp

Loading...
View Options

mlir/lib/Interfaces/ViewLikeInterface.cpp

Loading...
View Options

mlir/test/Dialect/Linalg/tile-to-foreach-thread.mlir

Loading...
View Options

mlir/test/Dialect/Linalg/transform-tile-reduction.mlir

Loading...
View Options

mlir/test/Dialect/SCF/ops.mlir

Loading...
View Options

mlir/test/Dialect/Tensor/extract-slice-from-collapse-shape.mlir

Loading...
View Options

mlir/test/lib/Dialect/Tensor/TestTensorTransforms.cpp

Loading...