Page MenuHomePhabricator

chelini (lorenzo chelini)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 12:20 AM (168 w, 5 d)

Recent Activity

May 3 2021

chelini added inline comments to D101710: [MLIR] Replace a not of a comparison with appropriate comparison.
May 3 2021, 12:22 AM · Restricted Project

Apr 29 2021

chelini committed rGde94b1855c63: [mlir] Fix top-level comments (NFC) (authored by chelini).
[mlir] Fix top-level comments (NFC)
Apr 29 2021, 4:07 AM

Apr 28 2021

chelini committed rG41b86d8ad917: [mlir] Fix typos (NFC) (authored by chelini).
[mlir] Fix typos (NFC)
Apr 28 2021, 3:52 AM

Apr 26 2021

chelini added inline comments to D101171: [mlir] Affine: parallelize affine loops with reductions.
Apr 26 2021, 11:33 AM · Restricted Project

Apr 23 2021

chelini accepted D101171: [mlir] Affine: parallelize affine loops with reductions.
Apr 23 2021, 11:19 AM · Restricted Project

Apr 22 2021

chelini abandoned D99643: [mlir] scf::ForOp: Propagate constants in loop body to trigger simplifications.

This is a wrong approach in using the pattern rewrite see: https://mlir.llvm.org/docs/PatternRewriter/#restrictions. I will close this.

Apr 22 2021, 1:17 AM · Restricted Project

Apr 6 2021

chelini accepted D99942: [mlir] Fix support for lowering non-32-bit affine reductions..

Thanks, looks good to me.

Apr 6 2021, 4:58 AM · Restricted Project

Mar 31 2021

chelini requested review of D99643: [mlir] scf::ForOp: Propagate constants in loop body to trigger simplifications.
Mar 31 2021, 1:56 AM · Restricted Project

Mar 18 2021

chelini committed rG4c782a24d901: [mlir] Fix typo in SCF.cpp (NFC) (authored by chelini).
[mlir] Fix typo in SCF.cpp (NFC)
Mar 18 2021, 11:16 AM

Mar 17 2021

chelini added a comment to D98711: [mlir] scf::ForOp: Drop iter arguments (and corresponding result) with no use.

@nicolasvasilache thanks for landing it!

Mar 17 2021, 5:15 AM · Restricted Project
chelini updated the diff for D98711: [mlir] scf::ForOp: Drop iter arguments (and corresponding result) with no use.

rebase.

Mar 17 2021, 2:01 AM · Restricted Project

Mar 16 2021

chelini updated the diff for D98711: [mlir] scf::ForOp: Drop iter arguments (and corresponding result) with no use.

Minor update for test case.

Mar 16 2021, 7:46 AM · Restricted Project
chelini added a reviewer for D98711: [mlir] scf::ForOp: Drop iter arguments (and corresponding result) with no use: rriddle.
Mar 16 2021, 7:42 AM · Restricted Project
chelini requested review of D98711: [mlir] scf::ForOp: Drop iter arguments (and corresponding result) with no use.
Mar 16 2021, 7:35 AM · Restricted Project

Mar 15 2021

chelini added a comment to D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.

Thanks!

Mar 15 2021, 11:33 AM · Restricted Project
chelini updated the diff for D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.

Update missed comment.

Mar 15 2021, 11:31 AM · Restricted Project
chelini updated the diff for D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.

Update comment.

Mar 15 2021, 11:27 AM · Restricted Project
chelini retitled D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded from add Canonicalization pattern 'EnableIterArgsFolderOnUnusedArgs' for scf::ForOp to scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.
Mar 15 2021, 9:11 AM · Restricted Project
chelini added a comment to D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.

@rriddle and @nicolasvasilache thanks for the suggestions. @nicolasvasilache I updated the code as you suggested. Indeed it simplified a lot.

Mar 15 2021, 9:10 AM · Restricted Project
chelini updated the diff for D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.

Updating D98503: Canonicalization for scf::ForOp

Mar 15 2021, 9:08 AM · Restricted Project

Mar 12 2021

chelini requested review of D98503: scf::ForOp: Fold away iterator arguments with no use and for which the corresponding input is yielded.
Mar 12 2021, 7:10 AM · Restricted Project

Dec 7 2020

chelini accepted D92765: [mlir] Add an option to control the number of loops in affine parallelizer.
Dec 7 2020, 9:09 AM · Restricted Project

Nov 27 2020

chelini added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Nov 27 2020, 6:10 AM · Restricted Project

Jul 2 2020

chelini added inline comments to D82952: [MLIR][Linalg] Retire C++ DotOp in favor of a linalg-ods-gen'd op.
Jul 2 2020, 3:10 AM · Restricted Project
chelini updated the diff for D82952: [MLIR][Linalg] Retire C++ DotOp in favor of a linalg-ods-gen'd op.

Drop check for custom op

Jul 2 2020, 3:10 AM · Restricted Project

Jul 1 2020

chelini created D82952: [MLIR][Linalg] Retire C++ DotOp in favor of a linalg-ods-gen'd op.
Jul 1 2020, 5:22 AM · Restricted Project

Jun 17 2020

chelini added a comment to D82007: [MLIR][Linalg] Retire C++ MatvecOp in favor of a linalg-ods-gen'd op.

Great, thank you @chelini !

Jun 17 2020, 11:58 PM · Restricted Project
chelini created D82007: [MLIR][Linalg] Retire C++ MatvecOp in favor of a linalg-ods-gen'd op.
Jun 17 2020, 5:53 AM · Restricted Project

Apr 17 2020

chelini added a comment to D78274: [MLIR] NFC after commit D77478..

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Apr 17 2020, 12:30 AM · Restricted Project

Apr 16 2020

chelini added a comment to D78274: [MLIR] NFC after commit D77478..

Thanks.

Apr 16 2020, 1:35 AM · Restricted Project

Apr 15 2020

chelini created D78274: [MLIR] NFC after commit D77478..
Apr 15 2020, 11:25 PM · Restricted Project

Jan 16 2020

chelini updated the diff for D72854: [mlir] Generalize m_ConstantIndexOp.

Add explicit keyword for the single-parameter constructor.

Jan 16 2020, 8:48 AM · Restricted Project, Restricted Project
chelini updated the diff for D72854: [mlir] Generalize m_ConstantIndexOp.
Jan 16 2020, 8:28 AM · Restricted Project, Restricted Project
chelini created D72854: [mlir] Generalize m_ConstantIndexOp.
Jan 16 2020, 8:19 AM · Restricted Project, Restricted Project

Jan 13 2020

chelini added a comment to D72397: [mlir] m_Constant().

Could you please commit this patch? I don't have commit permission.

Jan 13 2020, 8:03 AM · Restricted Project

Jan 10 2020

chelini updated the diff for D72397: [mlir] m_Constant().

Address River's comment by avoiding the double return.

Jan 10 2020, 12:48 AM · Restricted Project

Jan 9 2020

chelini updated the diff for D72397: [mlir] m_Constant().

Address River's comment by checking the cast before returning true and optionally binding to bind_value.

Jan 9 2020, 1:49 AM · Restricted Project

Jan 8 2020

chelini updated the diff for D72397: [mlir] m_Constant().

Introduce [mlir] tag in the commit message. Modify the constant_op_binder class as suggested by Alex. Specifically, introduce a class constructor with zero arguments which sets bind_value to nullptr. In the match method, insert an early exit if we match a constantOp, but we don't need to bind to any attribute value.

Jan 8 2020, 8:56 AM · Restricted Project
chelini created D72397: [mlir] m_Constant().
Jan 8 2020, 6:34 AM · Restricted Project

Jan 6 2020

chelini added inline comments to D72249: [mlir] Detemplaize m_Op and RecursivePatternMatcher..
Jan 6 2020, 7:38 AM · Restricted Project, Restricted Project
chelini created D72249: [mlir] Detemplaize m_Op and RecursivePatternMatcher..
Jan 6 2020, 1:40 AM · Restricted Project, Restricted Project

Mar 25 2019

chelini added a comment to D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.

Do you need help with landing the patch?

Mar 25 2019, 9:23 AM · Restricted Project, Restricted Project

Mar 12 2019

chelini created D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.
Mar 12 2019, 9:25 AM · Restricted Project, Restricted Project

Jul 3 2018

chelini added a reviewer for D48651: [RFC] Pattern matching on schedule trees.: ftynse.
Jul 3 2018, 1:53 AM · Restricted Project
chelini added inline comments to D48651: [RFC] Pattern matching on schedule trees..
Jul 3 2018, 1:52 AM · Restricted Project
chelini updated the diff for D48651: [RFC] Pattern matching on schedule trees..

Clean and update the patch as suggested.

Jul 3 2018, 1:28 AM · Restricted Project

Jun 27 2018

chelini created D48651: [RFC] Pattern matching on schedule trees..
Jun 27 2018, 8:42 AM · Restricted Project

Jun 19 2018

chelini added inline comments to D48162: [GSoC] Schedule tree performance..
Jun 19 2018, 8:49 AM · Restricted Project
chelini updated the diff for D48162: [GSoC] Schedule tree performance..
Jun 19 2018, 8:41 AM · Restricted Project

Jun 17 2018

chelini added a comment to D48162: [GSoC] Schedule tree performance..

I'm going to request changes so this does not show up on the feed. I added two more comments regarding constructors :)

Jun 17 2018, 4:54 AM · Restricted Project

Jun 15 2018

chelini updated the diff for D48162: [GSoC] Schedule tree performance..
Jun 15 2018, 11:02 PM · Restricted Project

Jun 14 2018

chelini created D48162: [GSoC] Schedule tree performance..
Jun 14 2018, 2:43 AM · Restricted Project

Jun 5 2018

chelini created D47786: getDependences to new C++ interface.
Jun 5 2018, 8:30 AM · Restricted Project

Jun 1 2018

chelini added a comment to D47252: partitionSetParts from C to C++ interface..

Great! Could you please commit it? I cannot do that.

Jun 1 2018, 12:11 PM · Restricted Project
chelini added a comment to D47252: partitionSetParts from C to C++ interface..

@chelini : any plans to update this patch?

Jun 1 2018, 11:27 AM · Restricted Project
chelini updated the diff for D47252: partitionSetParts from C to C++ interface..
Jun 1 2018, 11:24 AM · Restricted Project

May 23 2018

chelini created D47252: partitionSetParts from C to C++ interface..
May 23 2018, 5:12 AM · Restricted Project

May 19 2018

chelini created D47102: createNextIterationMap from C to C++ interface.
May 19 2018, 1:37 AM · Restricted Project

Apr 7 2018

chelini added a comment to D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..

LGTM. Good work!

Yes, llvm-commits and pollydev are subscribers (I actually didn't check by myself before, just added as a general node).

Do you have commit rights yet? If not, I can commit for you (with an annotation: "Contributed-by: Lorenzo Chelini").

Apr 7 2018, 9:44 AM · Restricted Project

Apr 6 2018

chelini added a comment to D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..

Thanks for the update. Can you run make polly-update-format on it (there seems to be some trailing whitespace)? The buildbots check the source code formatting and "fail" if some irregularity is found.

For reviews in Polly:

  1. Add "pollydev" and "llvm-commits" to the subscribers
  2. Add the tag [Polly] in front of the title. (adding llvm-commits to subscribers triggers a mail to the corresponding mailing list. Adding the tag is useful s.t. one doesn't need to open the mail to see that it is a change in Polly)
  3. Use "rPLO" for repository.
Apr 6 2018, 9:49 AM · Restricted Project
chelini updated the diff for D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..

removed trailing whitespaces.

Apr 6 2018, 9:34 AM · Restricted Project
chelini retitled D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection. from fixed test cases after removing immediate dominator heuristic for error block detection. to [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..
Apr 6 2018, 9:32 AM · Restricted Project

Apr 5 2018

chelini updated the summary of D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..
Apr 5 2018, 2:09 AM · Restricted Project
chelini updated the diff for D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..

Added the removal of the heuristic in lib/Support/ScopHelper.cpp to the patch.

Apr 5 2018, 1:44 AM · Restricted Project

Apr 4 2018

chelini created D45274: [Polly] fixed test cases after removing immediate dominator heuristic for error block detection..
Apr 4 2018, 11:09 AM · Restricted Project

Apr 3 2018

chelini added a comment to D41692: [Polly][WIP] Remove immediate dominator heuristic for error block detection..

Hi All,
Attached the patch to fix the test cases.


Best regards,
Lorenzo Chelini.

Apr 3 2018, 2:13 AM · Restricted Project

Mar 30 2018

chelini added a comment to D41692: [Polly][WIP] Remove immediate dominator heuristic for error block detection..

I am confused. It seems you want to be smarter about the error blocks (which is necessary!) but this will just make them more greedy (too greedy in my experience). Did anybody check how this affects the test-suite or why the test cases fail [, after all, this says "ready to land"] ?

If you want a generally smarter way to determine and work with error blocks I could also send you some patches.

Mar 30 2018, 9:29 AM · Restricted Project