This is an archive of the discontinued LLVM Phabricator instance.

[openmp] Fix building z_Linux_asm.S for armv5t
ClosedPublic

Authored by mstorsjo on Feb 9 2023, 2:43 PM.

Details

Summary

Don't use the ldrd instruction; that one requires armv5te and
thumb2.

This should fix https://github.com/llvm/llvm-project/issues/60370.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 9 2023, 2:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2023, 2:43 PM
mstorsjo requested review of this revision.Feb 9 2023, 2:43 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sstefan1. · View Herald Transcript
tianshilei1992 accepted this revision.Feb 9 2023, 4:46 PM

I don't know about the specific assembly but I assume it can fix the issue.

This revision is now accepted and ready to land.Feb 9 2023, 4:46 PM
mstorsjo updated this revision to Diff 496334.Feb 9 2023, 11:09 PM

Added an # if OMPT_SUPPORT. (With ldrd previously, there was less use for an ifdef, but with separate instructions, we can leave out the second one.)

This revision was automatically updated to reflect the committed changes.