[Flang][OpenMP] Do not consider procedure names for data-sharing

[kiranchandramohan]

Summary

An incorrect error was issued for procedure names occuring in OpenMP
regions with default clause set to NONE. Fix is to ignore all cases
where names are various kinds of procedures.

Fixes issue https://github.com/flang-compiler/f18-llvm-project/issues/1350

[peixin]

LGTM

What about the procedure pointer? If this patch does not apply to it, it is OK to handle it in next support.

[kiranchandramohan]

Add procedure pointer test.

[kiranchandramohan]

In D143384#4115272, @peixin wrote:

LGTM

What about the procedure pointer? If this patch does not apply to it, it is OK to handle it in next support.

Yes, this handles the procedure pointer case as well. I have added a test.

flang/lib/Semantics/resolve-directives.cpp

void OmpAttributeVisitor::Post(const parser::OpenMPExecutableAllocate &x) {
   PopContext();
 }
 
 // For OpenMP constructs, check all the data-refs within the constructs
 // and adjust the symbol for each Name if necessary
 void OmpAttributeVisitor::Post(const parser::Name &name) {
   auto *symbol{name.symbol};
   if (symbol && !dirContext_.empty() && GetContext().withinConstruct) {
-    if (!symbol->owner().IsDerivedType() && !symbol->has<ProcEntityDetails>() &&
+    if (!symbol->owner().IsDerivedType() && !IsProcedure(*symbol) &&
         !IsObjectWithDSA(*symbol) && !IsNamedConstant(*symbol)) {
       // TODO: create a separate function to go through the rules for
       //       predetermined, explicitly determined, and implicitly
       //       determined data-sharing attributes (2.15.1.1).
       if (Symbol * found{currScope().FindSymbol(name.source)}) {
         if (symbol != found) {
           name.symbol = found; // adjust the symbol within region
         } else if (GetContext().defaultDSA == Symbol::Flag::OmpNone) {

flang/test/Semantics/OpenMP/omp-default-none.f90

+!RUN: %python %S/../test_errors.py %s %flang -fopenmp
+! Positive tests for default(none)
+subroutine sb2(x)
+  real :: x
+end subroutine
+
+subroutine sb1
+  integer :: i
+  real :: a(10), b(10), k
+  inc(x) = x + 1.0
+  abstract interface
+    function iface(a, b)
+      real, intent(in) :: a, b
+      real :: iface
+    end function
+  end interface
+  procedure(iface) :: compute
+  procedure(iface), pointer :: ptr => NULL()
+  ptr => fn2
+  !$omp parallel default(none) shared(a,b,k) private(i)
+  do i = 1, 10
+    b(i) = k + sin(a(i)) + inc(a(i)) + fn1(a(i)) + compute(a(i),k) + add(k, k)
+    call sb3(b(i))
+    call sb2(a(i))
+  end do
+  !$omp end parallel
+contains
+ function fn1(x)
+   real :: x, fn1
+   fn1 = x
+ end function
+ function fn2(x, y)
+   real, intent(in) :: x, y
+   real :: fn2
+   fn2 = x + y
+ end function
+ subroutine sb3(x)
+   real :: x
+   print *, x
+ end subroutine
+end subroutine