This is an archive of the discontinued LLVM Phabricator instance.

InstCombine: Handle folding fcmp of 0 into llvm.is.fpclass
ClosedPublic

Authored by arsenm on Feb 3 2023, 9:10 AM.

Details

Summary

This needs to consider the denormal mode.

Diff Detail

Event Timeline

arsenm created this revision.Feb 3 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2023, 9:10 AM
arsenm requested review of this revision.Feb 3 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2023, 9:10 AM
Herald added a subscriber: wdng. · View Herald Transcript
foad added inline comments.Feb 6 2023, 2:04 AM
llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
1272

This is done?

1278

Simplify this to ~fcZero & fcAllFlags

1499

You can use getFunction, here and below

arsenm updated this revision to Diff 495197.Feb 6 2023, 10:05 AM
arsenm marked 3 inline comments as done.
foad accepted this revision.Feb 6 2023, 12:35 PM

LGTM.

This revision is now accepted and ready to land.Feb 6 2023, 12:35 PM
arsenm reopened this revision.Feb 15 2023, 1:28 AM

Pushed wrong patch

This revision is now accepted and ready to land.Feb 15 2023, 1:28 AM