[AArch64] Mark function calls as possibly changing FPCR
ClosedPublic
Actions

Authored by sepavloff on Jan 31 2023, 11:10 AM.

Details

Reviewers

t.p.northover
efriedma
john.brawn
aprantl

Commits

rGc4e38fadfa2a: [AArch64] Mark function calls as possibly changing FPCR

Summary

This patch does the same changes as D111433 for PowerPC and D139549 for
X86, - in the strictfp function all calls are marked as implicit defs of
FPCR. It prevents from moving FP operations across function calls, which
may change rounding mode, as fesetround does.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,030 ms	x64 debian > libFuzzer.libFuzzer::minimize_crash.test Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/NullDerefTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/minimize_crash.test.tmp-NullDerefTest

Event Timeline

sepavloff created this revision.Jan 31 2023, 11:10 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 11:10 AM

Herald added subscribers: steven.zhang, pengfei, hiraditya, kristof.beyls. · View Herald Transcript

sepavloff requested review of this revision.Jan 31 2023, 11:10 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 11:10 AM

LGTM

llvm/lib/Target/AArch64/AArch64ISelLowering.h
673	Not exactly part of this patch, but can you make getRoundingControlRegisters return an `ArrayRef<MCPhysReg>` instead of the weird thing you're doing with a raw pointer?

This revision is now accepted and ready to land.Jan 31 2023, 11:33 AM

Harbormaster completed remote builds in B211041: Diff 493685.Jan 31 2023, 1:09 PM

Thanks!

This revision was landed with ongoing or failed builds.Jan 31 2023, 9:07 PM

Closed by commit rGc4e38fadfa2a: [AArch64] Mark function calls as possibly changing FPCR (authored by sepavloff). · Explain Why

This revision was automatically updated to reflect the committed changes.

sepavloff added a commit: rGc4e38fadfa2a: [AArch64] Mark function calls as possibly changing FPCR.