This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Conversion] Rename the MemRefToLLVM pass
ClosedPublic

Authored by qcolombet on Jan 24 2023, 5:50 AM.

Details

Summary

TL;DR Pretty boring patch; Rename memref-to-llvm into finalize-memref-to-llvm

Since the recent MemRef refactoring that centralizes the lowering of
complex MemRef operations outside of the conversion framework, the
MemRefToLLVM pass doesn't directly convert these complex operations.

Instead, to fully convert the whole MemRef dialect space, MemRefToLLVM
needs to run after expand-strided-metadata.

Make this more obvious by changing the name of the pass and the option
associated with it from convert-memref-to-llvm to
finalize-memref-to-llvm.
The word "finalize" conveys that this pass needs to run after something
else and that something else is documented in its tablegen description.

This is a follow-up patch related to the conversation at:
https://discourse.llvm.org/t/psa-you-need-to-run-expand-strided-metadata-before-memref-to-llvm-now/66956/14

Diff Detail

Event Timeline

qcolombet created this revision.Jan 24 2023, 5:50 AM
qcolombet requested review of this revision.Jan 24 2023, 5:50 AM
mehdi_amini accepted this revision.Jan 24 2023, 10:18 AM
This revision is now accepted and ready to land.Jan 24 2023, 10:18 AM
This revision was automatically updated to reflect the committed changes.