This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][NFC] Update the OpenMPSupport page
Needs ReviewPublic

Authored by jdoerfert on Jan 11 2023, 1:01 PM.

Diff Detail

Event Timeline

jdoerfert created this revision.Jan 11 2023, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 1:01 PM
jdoerfert requested review of this revision.Jan 11 2023, 1:01 PM
jdoerfert added a subscriber: tianshilei1992.

I guessed sometimes a little, feedback appreciated. Add reviewers please.

clang/docs/OpenMPSupport.rst
149

Not sure what regular codegen only meant (@dreachem)?

171

Not sure what this means, I assume it works if nobody objects.

286
362

I'll fix these and replace :part:done with :good:done

tianshilei1992 added inline comments.Jan 11 2023, 1:34 PM
clang/docs/OpenMPSupport.rst
286

If D141545 is landed before this, it can be marked as done.

koops added a comment.Jan 12 2023, 9:54 PM

nowait clause on taskwait was marked as "part:done" because I have implemented the support for the clang compiler. The implementation for the runtime needs to be done and I have created a place holder for it. https://reviews.llvm.org/D131830 had the subject line " [OpenMP] Clang Support for taskwait nowait clause " .

nowait clause on taskwait was marked as "part:done" because I have implemented the support for the clang compiler. The implementation for the runtime needs to be done and I have created a place holder for it. https://reviews.llvm.org/D131830 had the subject line " [OpenMP] Clang Support for taskwait nowait clause " .

So, we accept it but handle it conservatively, e.g.. ignore the nowait but act on the dependences?

nowait clause on taskwait was marked as "part:done" because I have implemented the support for the clang compiler. The implementation for the runtime needs to be done and I have created a place holder for it. https://reviews.llvm.org/D131830 had the subject line " [OpenMP] Clang Support for taskwait nowait clause " .

So, we accept it but handle it conservatively, e.g.. ignore the nowait but act on the dependences?

Yes that is correct. Once the runtime support is done then taskwait nowait is completely done.

jdoerfert added inline comments.Jan 25 2023, 7:32 AM
clang/docs/OpenMPSupport.rst
171

Seems it works only for functions properly
https://godbolt.org/z/W4rqoEh5j