This is an archive of the discontinued LLVM Phabricator instance.

Differential D140722

[OpenMP] Prefix outlined and reduction func names with original func's name
ClosedPublic

Authored by nextsilicon-itay-bookstein on Dec 28 2022, 1:36 AM.

Details

Reviewers
jdoerfert
Commits
rG782c59a4eef0: [OpenMP] Prefix outlined and reduction func names with original func's name
rG029bfc311d4d: [OpenMP] Prefix outlined and reduction func names with original func's name
Summary

This patch prefixes omp outlined helpers and reduction funcs
with the original function's name.

Diff Detail

Unit TestsFailed

TimeTest
310 msx64 debian > Clang.CodeGen/PowerPC::ppc64le-varargs-f128.c

Event Timeline

nextsilicon-itay-bookstein created this revision.Dec 28 2022, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 1:36 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
nextsilicon-itay-bookstein requested review of this revision.Dec 28 2022, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 1:36 AM
Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B205061: Diff 485477.Dec 28 2022, 2:11 AM
nextsilicon-itay-bookstein edited the summary of this revision. (Show Details)Feb 2 2023, 5:56 AM
jdoerfert added a comment.Mar 20 2023, 11:20 AM

can we update some tests to see the results?

Herald added subscribers: jplehr, sunshaoce. · View Herald TranscriptMar 20 2023, 11:20 AM
nextsilicon-itay-bookstein updated this revision to Diff 507121.Mar 21 2023, 2:22 PM

Update relevant test outputs.

Herald added subscribers: mattd, asavonic, zzheng and 2 others. · View Herald TranscriptMar 21 2023, 2:22 PM
nextsilicon-itay-bookstein added a comment.Mar 21 2023, 2:25 PM

I had to cut context lines to 2 to fit in the 8MB limit. It looks like there are a few files that absorb way more line diff than makes sense, but I haven't investigated way. One particular offender is clang/test/OpenMP/nvptx_SPMD_codegen.cpp, which loses 23KLOC. I think some of the NVPTX files are not idempotent under update_cc_test_checks in master, but I haven't checked again to make sure.

Harbormaster completed remote builds in B220834: Diff 507121.Mar 21 2023, 3:33 PM
jdoerfert added a comment.Mar 21 2023, 4:20 PM

Generally, I think this is fine. I left comments below.

clang/lib/CodeGen/CGOpenMPRuntime.cpp
1261

why the empty string?

clang/test/OpenMP/declare_target_codegen_globalization.cpp
65

This might be easier to debug than the SPMD test. For some reason the function is gone, which is bad. My money is on the trailing $ which prevents us from matching it as a function in the update test script. That said, I really doubt we want that $ anyway.

nextsilicon-itay-bookstein updated this revision to Diff 507532.Mar 22 2023, 3:58 PM

Removed the empty string in the getName() invocation for the outlined helper's name.

Herald added subscribers: kosarev, kerbowa, jvesely. · View Herald TranscriptMar 22 2023, 3:58 PM
jdoerfert accepted this revision.Mar 22 2023, 4:56 PM

Assuming this passes all tests, incl. runtime tests in openmp/libomptarget/tests, LGTM.

This revision is now accepted and ready to land.Mar 22 2023, 4:56 PM
Harbormaster completed remote builds in B221159: Diff 507532.Mar 22 2023, 9:02 PM
nextsilicon-itay-bookstein updated this revision to Diff 508054.Mar 24 2023, 5:08 AM

Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test.

@jdoerfert Does the PR CI run these, or are there build bots that cover the different target-offloading variants? Can I somehow check this prior to merging without having all hardware variants on-hand?

nextsilicon-itay-bookstein edited the summary of this revision. (Show Details)Mar 24 2023, 5:09 AM
Harbormaster completed remote builds in B221557: Diff 508054.Mar 24 2023, 5:09 AM
nextsilicon-itay-bookstein updated this revision to Diff 508059.Mar 24 2023, 5:24 AM

Retry, wrong patch uploaded last time.

Harbormaster completed remote builds in B221561: Diff 508059.Mar 24 2023, 9:01 AM
nextsilicon-itay-bookstein updated this revision to Diff 508116.Mar 24 2023, 9:02 AM

Another minor tweak to clang/test/CodeGen/PowerPC/ppc64le-varargs-f128.c.

Harbormaster completed remote builds in B221607: Diff 508116.Mar 28 2023, 2:20 AM
nextsilicon-itay-bookstein added a comment.Mar 28 2023, 4:16 AM

Passes CI. How should I proceed w.r.t. libomptarget tests?

jplehr added a comment.Mar 31 2023, 2:48 PM
In D140722#4219182, @nextsilicon-itay-bookstein wrote:

Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test.

@jdoerfert Does the PR CI run these, or are there build bots that cover the different target-offloading variants? Can I somehow check this prior to merging without having all hardware variants on-hand?

There is a buildbot for AMDGPU and the x86 fallback. Not sure about the status of the NVPTX openmp offloading buildbot.
What hardware do you have access to? I could potentially give it a try on AMDGPU prior to merging.

nextsilicon-itay-bookstein added a comment.EditedApr 1 2023, 11:01 AM

I don't have non-cumbersome access to GPU targets at the moment.
I have run the following locally with the patch, and it seems to pass:

> ninja check-libomptarget
[0/1] Running libomptarget tests

Testing Time: 9.69s
  Unsupported:  57
  Passed     : 205

This is with the following parts enabled:

-- LIBOMPTARGET: Building offloading runtime library libomptarget.
-- LIBOMPTARGET: Not building aarch64 offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Building AMDGPU plugin for dlopened libhsa
-- LIBOMPTARGET: Not generating AMDGPU tests, no supported devices detected. Use 'LIBOMPTARGET_FORCE_AMDGPU_TESTS' to override.
-- LIBOMPTARGET: Building CUDA offloading plugin.
-- LIBOMPTARGET: Building CUDA plugin for dlopened libcuda
-- LIBOMPTARGET: Not generating NVIDIA tests, no supported devices detected. Use 'LIBOMPTARGET_FORCE_NVIDIA_TESTS' to override.
-- LIBOMPTARGET: Not building PPC64 offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building PPC64le offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building nec-aurora plugin: libveo or libveosinfo not found.
-- LIBOMPTARGET: Building x86_64 offloading plugin.
-- LIBOMPTARGET: Not building aarch64 NextGen offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Building AMDGPU NextGen plugin for dlopened libhsa
-- LIBOMPTARGET: Building CUDA NextGen offloading plugin.
-- LIBOMPTARGET: Building CUDA plugin for dlopened libcuda
-- LIBOMPTARGET: Not building PPC64 NextGen offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building PPC64le NextGen offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Building x86_64 NextGen offloading plugin.
-- LIBOMPTARGET: Building DeviceRTL. Using clang from in-tree build
-- LIBOMPTARGET: Building the llvm-omp-device-info tool
-- LIBOMPTARGET: Building the llvm-omp-kernel-replay tool
nextsilicon-itay-bookstein added a comment.Apr 5 2023, 1:45 AM

Ping :)

nextsilicon-itay-bookstein added a comment.Apr 17 2023, 12:27 AM

Ping (:

jplehr added a comment.Apr 17 2023, 4:14 AM

I'll get back to this soon, enjoyed vacation. ;)

jplehr added a comment.Apr 18 2023, 4:16 AM

Tested on AMDGPU (gfx90a)

-- OpenMP tools dir in libomptarget: /home/janplehr/git/trunk17.0/build/llvm-project/runtimes/runtimes-bins/openmp/runtime/src
-- LIBOMPTARGET: Building offloading runtime library libomptarget.
-- LIBOMPTARGET: Not building aarch64 offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Building AMDGPU plugin linked against libhsa
-- LIBOMPTARGET: Not building CUDA offloading plugin: LIBOMPTARGET_BUILD_CUDA_PLUGIN is false
-- LIBOMPTARGET: Not building PPC64 offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building PPC64le offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building nec-aurora plugin: libveo or libveosinfo not found.
-- LIBOMPTARGET: Building x86_64 offloading plugin.
-- LIBOMPTARGET: Not building aarch64 NextGen offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Building AMDGPU NextGen plugin linked against libhsa
-- LIBOMPTARGET: Not building CUDA NextGen offloading plugin: LIBOMPTARGET_BUILD_CUDA_PLUGIN is false
-- LIBOMPTARGET: Not building PPC64 NextGen offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Not building PPC64le NextGen offloading plugin: machine not found in the system.
-- LIBOMPTARGET: Building x86_64 NextGen offloading plugin.

Before
Testing Time: 44.63s

Unsupported: 123
Passed     : 657

After
Testing Time: 38.74s

Unsupported: 123
Passed     : 657
nextsilicon-itay-bookstein added a comment.Apr 18 2023, 12:54 PM

Alright, cool, thanks! I'll land it tomorrow evening if there are no objections.

Closed by commit rG029bfc311d4d: [OpenMP] Prefix outlined and reduction func names with original func's name (authored by nextsilicon-itay-bookstein). · Explain WhyApr 19 2023, 9:39 AM
This revision was automatically updated to reflect the committed changes.
nextsilicon-itay-bookstein added a commit: rG029bfc311d4d: [OpenMP] Prefix outlined and reduction func names with original func's name.
nextsilicon-itay-bookstein added a reverting change: rG6fdd13e0ec61: Revert "[OpenMP] Prefix outlined and reduction func names with original func's….Apr 19 2023, 9:57 AM
paulkirth added a subscriber: paulkirth.Apr 19 2023, 11:00 AM

I'm seeing some test failures in our CI:

Clang :: OpenMP/parallel_masked.cpp
Clang :: OpenMP/parallel_masked_target.cpp

Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8783369579855138017/overview

If this will be hard to fix, can you revert until a fix is ready?

paulkirth added a comment.Apr 19 2023, 11:02 AM

Sorry, I missed that this was already reverted.

nextsilicon-itay-bookstein reopened this revision.Apr 19 2023, 11:13 AM
nextsilicon-itay-bookstein marked 2 inline comments as done.

Reopening due to revert, will update with a fixed patch

This revision is now accepted and ready to land.Apr 19 2023, 11:13 AM
nextsilicon-itay-bookstein updated this revision to Diff 515025.Apr 19 2023, 11:14 AM
nextsilicon-itay-bookstein edited the summary of this revision. (Show Details)

Updated a couple of tests that were introduced in the interim

Harbormaster completed remote builds in B226651: Diff 515025.Apr 19 2023, 12:07 PM
This revision was landed with ongoing or failed builds.Apr 19 2023, 1:01 PM
Closed by commit rG782c59a4eef0: [OpenMP] Prefix outlined and reduction func names with original func's name (authored by nextsilicon-itay-bookstein). · Explain Why
This revision was automatically updated to reflect the committed changes.
nextsilicon-itay-bookstein added a commit: rG782c59a4eef0: [OpenMP] Prefix outlined and reduction func names with original func's name.

Large Diff

This large diff affects 217 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
lib/
CodeGen/
51 lines
50 lines
27 lines
20 lines
6 lines
test/
CodeGen/
PowerPC/
2 lines
OpenMP/
4 lines
16 lines
42 lines
34 lines
8 lines
8 lines
2 lines
22 lines
112 lines
32 lines
32 lines
440 lines
56 lines
72 lines
56 lines
192 lines
48 lines
24 lines
20 lines
440 lines
56 lines
300 lines
56 lines
192 lines
48 lines
24 lines
32 lines
224 lines
32 lines
32 lines
32 lines
28 lines
99 lines
187 lines
151 lines
101 lines
274 lines
262 lines
8 lines
2 lines
8 lines
8 lines
16 lines
4 lines
12 lines
276 lines
23336 lines
32 lines
78 lines
554 lines
276 lines
86 lines
138 lines
362 lines
112 lines
134 lines
106 lines
106 lines
372 lines
552 lines
642 lines
166 lines
202 lines
4138 lines
526 lines
1876 lines
2854 lines
128 lines
828 lines
2 lines
39 lines
4 lines
72 lines
112 lines
20 lines
152 lines
152 lines
16 lines
100 lines
8 lines
4 lines
2 lines
36 lines
16 lines
32 lines
8 lines
68 lines
117 lines
150 lines
117 lines
58 lines
174 lines
8 lines
8 lines
8 lines
128 lines
128 lines
79 lines
105 lines
76 lines
126 lines
8 lines
1074 lines
45 lines
42 lines
68 lines
4 lines
16 lines
4 lines
132 lines
172 lines
388 lines
288 lines
607 lines
8 lines
352 lines
152 lines
128 lines
8 lines
284 lines
180 lines
32 lines
128 lines
28 lines
32 lines
88 lines
56 lines
200 lines
88 lines
72 lines
56 lines
8 lines
80 lines
24 lines
88 lines
32 lines
688 lines
112 lines
56 lines
200 lines
88 lines
316 lines
56 lines
80 lines
24 lines
88 lines
688 lines
20 lines
552 lines
360 lines
32 lines
128 lines
28 lines
32 lines
20 lines
48 lines
272 lines
128 lines
128 lines
76 lines
60 lines
8 lines
8 lines
8 lines
8 lines
176 lines
64 lines
32 lines
128 lines
28 lines
32 lines
112 lines
56 lines
48 lines
200 lines
48 lines
72 lines
56 lines
96 lines
40 lines
24 lines
88 lines
32 lines
688 lines
112 lines
56 lines
200 lines
48 lines
300 lines
56 lines
96 lines
40 lines
24 lines
88 lines
688 lines
20 lines
48 lines
96 lines
32 lines
128 lines
28 lines
32 lines
20 lines
48 lines
88 lines
56 lines
8 lines
4 lines
8 lines
utils/
update_cc_test_checks/
Inputs/
8 lines
4 lines

Diff 507121

clang/lib/CodeGen/CGOpenMPRuntime.h

clang/lib/CodeGen/CGOpenMPRuntime.cpp

Context not available.
} }
std::string CGOpenMPRuntime::getOutlinedHelperName(StringRef Name) const {
std::string Suffix = getName({"omp_outlined", ""});
jdoerfertUnsubmitted
Done
ReplyInline Actions

why the empty string?

jdoerfert: why the empty string?
return (Name + Suffix).str();
}
std::string CGOpenMPRuntime::getOutlinedHelperName(CodeGenFunction &CGF) const {
return getOutlinedHelperName(CGF.CurFn->getName());
}
std::string CGOpenMPRuntime::getReductionFuncName(StringRef Name) const {
std::string Suffix = getName({"omp", "reduction", "reduction_func"});
return (Name + Suffix).str();
}
llvm::Function *CGOpenMPRuntime::emitParallelOutlinedFunction( llvm::Function *CGOpenMPRuntime::emitParallelOutlinedFunction(
const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, CodeGenFunction &CGF, const OMPExecutableDirective &D,
OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen) { const VarDecl *ThreadIDVar, OpenMPDirectiveKind InnermostKind,
const RegionCodeGenTy &CodeGen) {
const CapturedStmt *CS = D.getCapturedStmt(OMPD_parallel); const CapturedStmt *CS = D.getCapturedStmt(OMPD_parallel);
return emitParallelOrTeamsOutlinedFunction( return emitParallelOrTeamsOutlinedFunction(
CGM, D, CS, ThreadIDVar, InnermostKind, getOutlinedHelperName(), CodeGen); CGM, D, CS, ThreadIDVar, InnermostKind, getOutlinedHelperName(CGF),
CodeGen);
} }
llvm::Function *CGOpenMPRuntime::emitTeamsOutlinedFunction( llvm::Function *CGOpenMPRuntime::emitTeamsOutlinedFunction(
const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, CodeGenFunction &CGF, const OMPExecutableDirective &D,
OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen) { const VarDecl *ThreadIDVar, OpenMPDirectiveKind InnermostKind,
const RegionCodeGenTy &CodeGen) {
const CapturedStmt *CS = D.getCapturedStmt(OMPD_teams); const CapturedStmt *CS = D.getCapturedStmt(OMPD_teams);
return emitParallelOrTeamsOutlinedFunction( return emitParallelOrTeamsOutlinedFunction(
CGM, D, CS, ThreadIDVar, InnermostKind, getOutlinedHelperName(), CodeGen); CGM, D, CS, ThreadIDVar, InnermostKind, getOutlinedHelperName(CGF),
CodeGen);
} }
Context not available.
llvm::Function *CGOpenMPRuntime::emitReductionFunction( llvm::Function *CGOpenMPRuntime::emitReductionFunction(
SourceLocation Loc, llvm::Type *ArgsElemType, StringRef ReducerName, SourceLocation Loc, llvm::Type *ArgsElemType,
ArrayRef<const Expr *> Privates, ArrayRef<const Expr *> LHSExprs, ArrayRef<const Expr *> Privates, ArrayRef<const Expr *> LHSExprs,
ArrayRef<const Expr *> RHSExprs, ArrayRef<const Expr *> ReductionOps) { ArrayRef<const Expr *> RHSExprs, ArrayRef<const Expr *> ReductionOps) {
Context not available.
const auto &CGFI = const auto &CGFI =
CGM.getTypes().arrangeBuiltinFunctionDeclaration(C.VoidTy, Args); CGM.getTypes().arrangeBuiltinFunctionDeclaration(C.VoidTy, Args);
std::string Name = getName({"omp", "reduction", "reduction_func"}); std::string Name = getReductionFuncName(ReducerName);
auto *Fn = llvm::Function::Create(CGM.getTypes().GetFunctionType(CGFI), auto *Fn = llvm::Function::Create(CGM.getTypes().GetFunctionType(CGFI),
llvm::GlobalValue::InternalLinkage, Name, llvm::GlobalValue::InternalLinkage, Name,
Context not available.
// 2. Emit reduce_func(). // 2. Emit reduce_func().
llvm::Function *ReductionFn = llvm::Function *ReductionFn = emitReductionFunction(
emitReductionFunction(Loc, CGF.ConvertTypeForMem(ReductionArrayTy), CGF.CurFn->getName(), Loc, CGF.ConvertTypeForMem(ReductionArrayTy),
Privates, LHSExprs, RHSExprs, ReductionOps); Privates, LHSExprs, RHSExprs, ReductionOps);
// 3. Create static kmp_critical_name lock = { 0 }; // 3. Create static kmp_critical_name lock = { 0 };
Context not available.
llvm::Function *CGOpenMPSIMDRuntime::emitParallelOutlinedFunction( llvm::Function *CGOpenMPSIMDRuntime::emitParallelOutlinedFunction(
const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, CodeGenFunction &CGF, const OMPExecutableDirective &D,
OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen) { const VarDecl *ThreadIDVar, OpenMPDirectiveKind InnermostKind,
const RegionCodeGenTy &CodeGen) {
llvm_unreachable("Not supported in SIMD-only mode"); llvm_unreachable("Not supported in SIMD-only mode");
} }
llvm::Function *CGOpenMPSIMDRuntime::emitTeamsOutlinedFunction( llvm::Function *CGOpenMPSIMDRuntime::emitTeamsOutlinedFunction(
const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, CodeGenFunction &CGF, const OMPExecutableDirective &D,
OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen) { const VarDecl *ThreadIDVar, OpenMPDirectiveKind InnermostKind,
const RegionCodeGenTy &CodeGen) {
llvm_unreachable("Not supported in SIMD-only mode"); llvm_unreachable("Not supported in SIMD-only mode");
} }
Context not available.

clang/lib/CodeGen/CGOpenMPRuntimeGPU.h

clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

clang/lib/CodeGen/CGStmtOpenMP.cpp

clang/test/CodeGen/PowerPC/ppc64le-varargs-f128.c

clang/test/OpenMP/bug54082.c

clang/test/OpenMP/bug60602.cpp

clang/test/OpenMP/cancel_codegen.cpp

clang/test/OpenMP/cancellation_point_codegen.cpp

clang/test/OpenMP/debug-info-complex-byval.cpp

clang/test/OpenMP/debug-info-openmp-array.cpp

clang/test/OpenMP/debug_threadprivate_copyin.c

clang/test/OpenMP/declare_target_codegen_globalization.cpp

Context not available.
// CHECK1-NEXT: [[TMP3:%.*]] = getelementptr inbounds [1 x ptr], ptr [[CAPTURED_VARS_ADDRS]], i64 0, i64 0 // CHECK1-NEXT: [[TMP3:%.*]] = getelementptr inbounds [1 x ptr], ptr [[CAPTURED_VARS_ADDRS]], i64 0, i64 0
// CHECK1-NEXT: store ptr [[TMP0]], ptr [[TMP3]], align 8 // CHECK1-NEXT: store ptr [[TMP0]], ptr [[TMP3]], align 8
// CHECK1-NEXT: call void @__kmpc_parallel_51(ptr @[[GLOB1]], i32 [[TMP2]], i32 1, i32 -1, i32 -1, ptr @__omp_outlined__, ptr null, ptr [[CAPTURED_VARS_ADDRS]], i64 1) // CHECK1-NEXT: call void @__kmpc_parallel_51(ptr @[[GLOB1]], i32 [[TMP2]], i32 1, i32 -1, i32 -1, ptr @"{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}__Z6maini1v_l16_omp_outlined$", ptr null, ptr [[CAPTURED_VARS_ADDRS]], i64 1)
// CHECK1-NEXT: call void @__kmpc_target_deinit(ptr @[[GLOB1]], i8 2) // CHECK1-NEXT: call void @__kmpc_target_deinit(ptr @[[GLOB1]], i8 2)
// CHECK1-NEXT: ret void // CHECK1-NEXT: ret void
Context not available.
// //
// //
// CHECK1-LABEL: define {{[^@]+}}@__omp_outlined__
// CHECK1-SAME: (ptr noalias noundef [[DOTGLOBAL_TID_:%.*]], ptr noalias noundef [[DOTBOUND_TID_:%.*]], ptr noundef nonnull align 4 dereferenceable(4) [[A:%.*]]) #[[ATTR1:[0-9]+]] {
// CHECK1-NEXT: entry:
// CHECK1-NEXT: [[DOTGLOBAL_TID__ADDR:%.*]] = alloca ptr, align 8
// CHECK1-NEXT: [[DOTBOUND_TID__ADDR:%.*]] = alloca ptr, align 8
// CHECK1-NEXT: [[A_ADDR:%.*]] = alloca ptr, align 8
// CHECK1-NEXT: [[B:%.*]] = alloca i32, align 4
// CHECK1-NEXT: store ptr [[DOTGLOBAL_TID_]], ptr [[DOTGLOBAL_TID__ADDR]], align 8
// CHECK1-NEXT: store ptr [[DOTBOUND_TID_]], ptr [[DOTBOUND_TID__ADDR]], align 8
// CHECK1-NEXT: store ptr [[A]], ptr [[A_ADDR]], align 8
// CHECK1-NEXT: [[TMP0:%.*]] = load ptr, ptr [[A_ADDR]], align 8
// CHECK1-NEXT: [[CALL:%.*]] = call noundef i32 @_Z3fooRi(ptr noundef nonnull align 4 dereferenceable(4) [[B]]) #[[ATTR7:[0-9]+]]
// CHECK1-NEXT: [[CALL1:%.*]] = call noundef i32 @_Z3barv() #[[ATTR7]]
// CHECK1-NEXT: [[ADD:%.*]] = add nsw i32 [[CALL]], [[CALL1]]
// CHECK1-NEXT: store i32 [[ADD]], ptr [[TMP0]], align 4
// CHECK1-NEXT: ret void
//
//
jdoerfertUnsubmitted
Done
ReplyInline Actions

This might be easier to debug than the SPMD test. For some reason the function is gone, which is bad. My money is on the trailing $ which prevents us from matching it as a function in the update test script. That said, I really doubt we want that $ anyway.

jdoerfert: This might be easier to debug than the SPMD test. For some reason the function is gone, which…
// CHECK1-LABEL: define {{[^@]+}}@_Z3fooRi // CHECK1-LABEL: define {{[^@]+}}@_Z3fooRi
// CHECK1-SAME: (ptr noundef nonnull align 4 dereferenceable(4) [[A:%.*]]) #[[ATTR2:[0-9]+]] { // CHECK1-SAME: (ptr noundef nonnull align 4 dereferenceable(4) [[A:%.*]]) #[[ATTR2:[0-9]+]] {
Context not available.
// CHECK1-NEXT: entry: // CHECK1-NEXT: entry:
// CHECK1-NEXT: [[A:%.*]] = call align 8 ptr @__kmpc_alloc_shared(i64 4) // CHECK1-NEXT: [[A:%.*]] = call align 8 ptr @__kmpc_alloc_shared(i64 4)
// CHECK1-NEXT: [[CALL:%.*]] = call noundef i32 @_Z3fooRi(ptr noundef nonnull align 4 dereferenceable(4) [[A]]) #[[ATTR7]] // CHECK1-NEXT: [[CALL:%.*]] = call noundef i32 @_Z3fooRi(ptr noundef nonnull align 4 dereferenceable(4) [[A]]) #[[ATTR7:[0-9]+]]
// CHECK1-NEXT: call void @__kmpc_free_shared(ptr [[A]], i64 4) // CHECK1-NEXT: call void @__kmpc_free_shared(ptr [[A]], i64 4)
// CHECK1-NEXT: ret i32 [[CALL]] // CHECK1-NEXT: ret i32 [[CALL]]
Context not available.

clang/test/OpenMP/distribute_codegen.cpp

clang/test/OpenMP/distribute_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_private_codegen.cpp

clang/test/OpenMP/distribute_simd_codegen.cpp

clang/test/OpenMP/distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_private_codegen.cpp

clang/test/OpenMP/distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/for_firstprivate_codegen.cpp

clang/test/OpenMP/for_lastprivate_codegen.cpp

clang/test/OpenMP/for_linear_codegen.cpp

clang/test/OpenMP/for_private_codegen.cpp

clang/test/OpenMP/for_reduction_codegen.cpp

clang/test/OpenMP/for_reduction_codegen_UDR.cpp

clang/test/OpenMP/for_reduction_task_codegen.cpp

clang/test/OpenMP/function-attr.cpp

clang/test/OpenMP/master_taskloop_in_reduction_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_in_reduction_codegen.cpp

clang/test/OpenMP/metadirective_device_arch_codegen.cpp

clang/test/OpenMP/metadirective_device_isa_codegen.cpp

clang/test/OpenMP/metadirective_implementation_codegen.c

clang/test/OpenMP/nested_loop_codegen.cpp

clang/test/OpenMP/nvptx_SPMD_codegen.cpp

clang/test/OpenMP/nvptx_allocate_codegen.cpp

clang/test/OpenMP/nvptx_data_sharing.cpp

clang/test/OpenMP/nvptx_distribute_parallel_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_lambda_capturing.cpp

clang/test/OpenMP/nvptx_multi_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_nested_parallel_codegen.cpp

clang/test/OpenMP/nvptx_parallel_codegen.cpp

clang/test/OpenMP/nvptx_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

clang/test/OpenMP/nvptx_target_teams_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_simd_codegen.cpp

clang/test/OpenMP/nvptx_teams_codegen.cpp

clang/test/OpenMP/nvptx_teams_reduction_codegen.cpp

clang/test/OpenMP/omp_with_loop_pragma_instr_profile.c

clang/test/OpenMP/openmp_win_codegen.cpp

clang/test/OpenMP/outlined_artificial.c

clang/test/OpenMP/parallel_codegen.cpp

clang/test/OpenMP/parallel_copyin_codegen.cpp

clang/test/OpenMP/parallel_copyin_combined_codegen.c

clang/test/OpenMP/parallel_firstprivate_codegen.cpp

clang/test/OpenMP/parallel_for_codegen.cpp

clang/test/OpenMP/parallel_for_lastprivate_conditional.cpp

clang/test/OpenMP/parallel_for_linear_codegen.cpp

clang/test/OpenMP/parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_for_simd_aligned_codegen.cpp

clang/test/OpenMP/parallel_for_simd_codegen.cpp

clang/test/OpenMP/parallel_if_codegen.cpp

clang/test/OpenMP/parallel_if_codegen_PR51349.cpp

clang/test/OpenMP/parallel_master_codegen.cpp

clang/test/OpenMP/parallel_master_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_private_codegen.cpp

clang/test/OpenMP/parallel_reduction_codegen.cpp

clang/test/OpenMP/parallel_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_sections_codegen.cpp

clang/test/OpenMP/parallel_sections_reduction_task_codegen.cpp

clang/test/OpenMP/reduction_compound_op.cpp

clang/test/OpenMP/reduction_implicit_map.cpp

clang/test/OpenMP/sections_firstprivate_codegen.cpp

clang/test/OpenMP/sections_lastprivate_codegen.cpp

clang/test/OpenMP/sections_private_codegen.cpp

clang/test/OpenMP/sections_reduction_codegen.cpp

clang/test/OpenMP/sections_reduction_task_codegen.cpp

clang/test/OpenMP/single_codegen.cpp

clang/test/OpenMP/single_firstprivate_codegen.cpp

clang/test/OpenMP/single_private_codegen.cpp

clang/test/OpenMP/target_codegen_global_capture.cpp

clang/test/OpenMP/target_in_reduction_codegen.cpp

clang/test/OpenMP/target_map_codegen_03.cpp

clang/test/OpenMP/target_map_member_expr_codegen.cpp

clang/test/OpenMP/target_ompx_dyn_cgroup_mem_codegen.cpp

clang/test/OpenMP/target_parallel_codegen.cpp

clang/test/OpenMP/target_parallel_debug_codegen.cpp

clang/test/OpenMP/target_parallel_for_codegen.cpp

clang/test/OpenMP/target_parallel_for_debug_codegen.cpp

clang/test/OpenMP/target_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/target_parallel_for_simd_codegen.cpp

clang/test/OpenMP/target_parallel_if_codegen.cpp

clang/test/OpenMP/target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/target_parallel_reduction_task_codegen.cpp

clang/test/OpenMP/target_teams_codegen.cpp

clang/test/OpenMP/target_teams_distribute_codegen.cpp

clang/test/OpenMP/target_teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_order_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_map_codegen.cpp

clang/test/OpenMP/target_teams_num_teams_codegen.cpp

clang/test/OpenMP/target_teams_thread_limit_codegen.cpp

clang/test/OpenMP/task_codegen.cpp

clang/test/OpenMP/task_if_codegen.cpp

clang/test/OpenMP/task_in_reduction_codegen.cpp

clang/test/OpenMP/taskgroup_codegen.cpp

clang/test/OpenMP/taskloop_in_reduction_codegen.cpp

clang/test/OpenMP/taskloop_simd_in_reduction_codegen.cpp

clang/test/OpenMP/teams_codegen.cpp

clang/test/OpenMP/teams_distribute_codegen.cpp

clang/test/OpenMP/teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_copyin_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_private_codegen.cpp

clang/test/OpenMP/teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_firstprivate_codegen.cpp

clang/test/OpenMP/teams_private_codegen.cpp

clang/test/OpenMP/tile_codegen.cpp

clang/test/OpenMP/unroll_codegen_parallel_for_factor.cpp

clang/test/OpenMP/vla_crash.c

clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected

clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.no-generated.expected