This patch attempts to prefix omp outlined helpers and reduction funcs
with the original function's name.
Details
- Reviewers
jdoerfert
Diff Detail
Event Timeline
I had to cut context lines to 2 to fit in the 8MB limit. It looks like there are a few files that absorb way more line diff than makes sense, but I haven't investigated way. One particular offender is clang/test/OpenMP/nvptx_SPMD_codegen.cpp, which loses 23KLOC. I think some of the NVPTX files are not idempotent under update_cc_test_checks in master, but I haven't checked again to make sure.
Generally, I think this is fine. I left comments below.
clang/lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
1261 | why the empty string? | |
clang/test/OpenMP/declare_target_codegen_globalization.cpp | ||
65 | This might be easier to debug than the SPMD test. For some reason the function is gone, which is bad. My money is on the trailing $ which prevents us from matching it as a function in the update test script. That said, I really doubt we want that $ anyway. |
Assuming this passes all tests, incl. runtime tests in openmp/libomptarget/tests, LGTM.
Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test.
@jdoerfert Does the PR CI run these, or are there build bots that cover the different target-offloading variants? Can I somehow check this prior to merging without having all hardware variants on-hand?