Page MenuHomePhabricator

[OpenMP] Prefix outlined and reduction func names with original func's name

Authored by nextsilicon-itay-bookstein on Dec 28 2022, 1:36 AM.



This patch attempts to prefix omp outlined helpers and reduction funcs
with the original function's name.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 1:36 AM
nextsilicon-itay-bookstein requested review of this revision.Dec 28 2022, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 1:36 AM

can we update some tests to see the results?

Update relevant test outputs.

I had to cut context lines to 2 to fit in the 8MB limit. It looks like there are a few files that absorb way more line diff than makes sense, but I haven't investigated way. One particular offender is clang/test/OpenMP/nvptx_SPMD_codegen.cpp, which loses 23KLOC. I think some of the NVPTX files are not idempotent under update_cc_test_checks in master, but I haven't checked again to make sure.

Generally, I think this is fine. I left comments below.


why the empty string?


This might be easier to debug than the SPMD test. For some reason the function is gone, which is bad. My money is on the trailing $ which prevents us from matching it as a function in the update test script. That said, I really doubt we want that $ anyway.

Removed the empty string in the getName() invocation for the outlined helper's name.

jdoerfert accepted this revision.Wed, Mar 22, 4:56 PM

Assuming this passes all tests, incl. runtime tests in openmp/libomptarget/tests, LGTM.

This revision is now accepted and ready to land.Wed, Mar 22, 4:56 PM

Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test.

@jdoerfert Does the PR CI run these, or are there build bots that cover the different target-offloading variants? Can I somehow check this prior to merging without having all hardware variants on-hand?

Retry, wrong patch uploaded last time.

Another minor tweak to clang/test/CodeGen/PowerPC/ppc64le-varargs-f128.c.