Paths

Table of Contentst

Differential D140722

[OpenMP] Prefix outlined and reduction func names with original func's name
AcceptedPublic
Actions

Authored by nextsilicon-itay-bookstein on Dec 28 2022, 1:36 AM.

Details

Reviewers

jdoerfert

Summary

This patch attempts to prefix omp outlined helpers and reduction funcs
with the original function's name.

Diff Detail

Event Timeline

nextsilicon-itay-bookstein created this revision.Dec 28 2022, 1:36 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 1:36 AM

Herald added subscribers: guansong, yaxunl. · View Herald Transcript

nextsilicon-itay-bookstein requested review of this revision.Dec 28 2022, 1:36 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 1:36 AM

Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B205061: Diff 485477.Dec 28 2022, 2:11 AM

nextsilicon-itay-bookstein edited the summary of this revision. (Show Details)Feb 2 2023, 5:56 AM

can we update some tests to see the results?

Herald added subscribers: jplehr, sunshaoce. · View Herald TranscriptMon, Mar 20, 11:20 AM

Update relevant test outputs.

Herald added subscribers: mattd, asavonic, zzheng and 2 others. · View Herald TranscriptTue, Mar 21, 2:22 PM

I had to cut context lines to 2 to fit in the 8MB limit. It looks like there are a few files that absorb way more line diff than makes sense, but I haven't investigated way. One particular offender is clang/test/OpenMP/nvptx_SPMD_codegen.cpp, which loses 23KLOC. I think some of the NVPTX files are not idempotent under update_cc_test_checks in master, but I haven't checked again to make sure.

Harbormaster completed remote builds in B220834: Diff 507121.Tue, Mar 21, 3:33 PM

Generally, I think this is fine. I left comments below.

clang/lib/CodeGen/CGOpenMPRuntime.cpp
1261	why the empty string?
clang/test/OpenMP/declare_target_codegen_globalization.cpp
65	This might be easier to debug than the SPMD test. For some reason the function is gone, which is bad. My money is on the trailing $ which prevents us from matching it as a function in the update test script. That said, I really doubt we want that $ anyway.

Removed the empty string in the getName() invocation for the outlined helper's name.

Herald added subscribers: kosarev, kerbowa, jvesely. · View Herald TranscriptWed, Mar 22, 3:58 PM

Assuming this passes all tests, incl. runtime tests in openmp/libomptarget/tests, LGTM.

This revision is now accepted and ready to land.Wed, Mar 22, 4:56 PM

Harbormaster completed remote builds in B221159: Diff 507532.Wed, Mar 22, 9:02 PM

Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test.

@jdoerfert Does the PR CI run these, or are there build bots that cover the different target-offloading variants? Can I somehow check this prior to merging without having all hardware variants on-hand?

nextsilicon-itay-bookstein edited the summary of this revision. (Show Details)Fri, Mar 24, 5:09 AM

Harbormaster completed remote builds in B221557: Diff 508054.Fri, Mar 24, 5:09 AM

Retry, wrong patch uploaded last time.

Harbormaster completed remote builds in B221561: Diff 508059.Fri, Mar 24, 9:01 AM

Another minor tweak to clang/test/CodeGen/PowerPC/ppc64le-varargs-f128.c.

Large Diff

This large diff affects 221 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

CGOpenMPRuntime.h

51 lines

CGOpenMPRuntime.cpp

50 lines

CGOpenMPRuntimeGPU.h

27 lines

CGOpenMPRuntimeGPU.cpp

20 lines

CGStmtOpenMP.cpp

6 lines

test/

CodeGen/

PowerPC/

ppc64le-varargs-f128.c

2 lines

CoverageMapping/

openmp.c

2 lines

OpenMP/

amdgpu_target_with_aligned_attribute.c

8 lines

bug54082.c

4 lines

bug60602.cpp

16 lines

cancel_codegen.cpp

42 lines

cancellation_point_codegen.cpp

34 lines

debug-info-complex-byval.cpp

8 lines

debug-info-openmp-array.cpp

8 lines

debug_threadprivate_copyin.c

2 lines

declare_target_codegen_globalization.cpp

4 lines

distribute_codegen.cpp

112 lines

distribute_firstprivate_codegen.cpp

32 lines

distribute_lastprivate_codegen.cpp

32 lines

distribute_parallel_for_codegen.cpp

440 lines

distribute_parallel_for_firstprivate_codegen.cpp

56 lines

distribute_parallel_for_if_codegen.cpp

72 lines

distribute_parallel_for_lastprivate_codegen.cpp

56 lines

distribute_parallel_for_num_threads_codegen.cpp

192 lines

distribute_parallel_for_private_codegen.cpp

48 lines

distribute_parallel_for_proc_bind_codegen.cpp

24 lines

distribute_parallel_for_reduction_task_codegen.cpp

20 lines

distribute_parallel_for_simd_codegen.cpp

440 lines

distribute_parallel_for_simd_firstprivate_codegen.cpp

56 lines

distribute_parallel_for_simd_if_codegen.cpp

300 lines

distribute_parallel_for_simd_lastprivate_codegen.cpp

56 lines

distribute_parallel_for_simd_num_threads_codegen.cpp

192 lines

distribute_parallel_for_simd_private_codegen.cpp

48 lines

distribute_parallel_for_simd_proc_bind_codegen.cpp

24 lines

distribute_private_codegen.cpp

32 lines

distribute_simd_codegen.cpp

224 lines

distribute_simd_firstprivate_codegen.cpp

32 lines

distribute_simd_lastprivate_codegen.cpp

32 lines

distribute_simd_private_codegen.cpp

32 lines

distribute_simd_reduction_codegen.cpp

28 lines

for_firstprivate_codegen.cpp

99 lines

for_lastprivate_codegen.cpp

187 lines

for_linear_codegen.cpp

151 lines

for_private_codegen.cpp

101 lines

for_reduction_codegen.cpp

274 lines

for_reduction_codegen_UDR.cpp

262 lines

for_reduction_task_codegen.cpp

8 lines

function-attr.cpp

2 lines

master_taskloop_in_reduction_codegen.cpp

8 lines

master_taskloop_simd_in_reduction_codegen.cpp

8 lines

metadirective_device_arch_codegen.cpp

16 lines

metadirective_device_isa_codegen.cpp

4 lines

metadirective_implementation_codegen.c

12 lines

nested_loop_codegen.cpp

276 lines

nvptx_SPMD_codegen.cpp

1200 lines

nvptx_allocate_codegen.cpp

8 lines

nvptx_data_sharing.cpp

16 lines

nvptx_distribute_parallel_generic_mode_codegen.cpp

16 lines

nvptx_lambda_capturing.cpp

44 lines

nvptx_multi_target_parallel_codegen.cpp

24 lines

nvptx_nested_parallel_codegen.cpp

32 lines

nvptx_parallel_codegen.cpp

80 lines

nvptx_parallel_for_codegen.cpp

8 lines

nvptx_target_codegen.cpp

24 lines

nvptx_target_parallel_codegen.cpp

16 lines

nvptx_target_parallel_num_threads_codegen.cpp

16 lines

nvptx_target_parallel_proc_bind_codegen.cpp

72 lines

nvptx_target_parallel_reduction_codegen.cpp

90 lines

nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

34 lines

nvptx_target_teams_codegen.cpp

40 lines

nvptx_target_teams_distribute_codegen.cpp

24 lines

nvptx_target_teams_distribute_parallel_for_codegen.cpp

144 lines

nvptx_target_teams_distribute_parallel_for_generic_mode_codegen.cpp

16 lines

nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp

64 lines

nvptx_target_teams_distribute_simd_codegen.cpp

96 lines

nvptx_teams_codegen.cpp

32 lines

nvptx_teams_reduction_codegen.cpp

210 lines

omp_with_loop_pragma_instr_profile.c

2 lines

openmp_win_codegen.cpp

39 lines

outlined_artificial.c

4 lines

parallel_codegen.cpp

72 lines

parallel_copyin_codegen.cpp

112 lines

parallel_copyin_combined_codegen.c

20 lines

parallel_firstprivate_codegen.cpp

144 lines

parallel_for_codegen.cpp

152 lines

parallel_for_lastprivate_conditional.cpp

16 lines

parallel_for_linear_codegen.cpp

100 lines

parallel_for_reduction_task_codegen.cpp

8 lines

parallel_for_simd_aligned_codegen.cpp

4 lines

parallel_for_simd_codegen.cpp

2 lines

parallel_if_codegen.cpp

36 lines

parallel_if_codegen_PR51349.cpp

16 lines

parallel_master_codegen.cpp

32 lines

parallel_master_reduction_task_codegen.cpp

8 lines

parallel_master_taskloop_codegen.cpp

68 lines

parallel_master_taskloop_firstprivate_codegen.cpp

98 lines

parallel_master_taskloop_lastprivate_codegen.cpp

117 lines

parallel_master_taskloop_simd_codegen.cpp

150 lines

parallel_master_taskloop_simd_firstprivate_codegen.cpp

98 lines

parallel_master_taskloop_simd_lastprivate_codegen.cpp

117 lines

parallel_private_codegen.cpp

58 lines

parallel_reduction_codegen.cpp

174 lines

parallel_reduction_task_codegen.cpp

8 lines

parallel_sections_codegen.cpp

8 lines

parallel_sections_reduction_task_codegen.cpp

8 lines

reduction_compound_op.cpp

128 lines

reduction_implicit_map.cpp

86 lines

sections_firstprivate_codegen.cpp

79 lines

sections_lastprivate_codegen.cpp

105 lines

sections_private_codegen.cpp

76 lines

sections_reduction_codegen.cpp

126 lines

sections_reduction_task_codegen.cpp

8 lines

single_codegen.cpp

1074 lines

single_firstprivate_codegen.cpp

45 lines

single_private_codegen.cpp

42 lines

target_codegen_global_capture.cpp

68 lines

target_in_reduction_codegen.cpp

4 lines

target_map_codegen_03.cpp

16 lines

target_map_member_expr_codegen.cpp

4 lines

target_ompx_dyn_cgroup_mem_codegen.cpp

132 lines

target_parallel_codegen.cpp

172 lines

target_parallel_debug_codegen.cpp

24 lines

target_parallel_for_codegen.cpp

288 lines

target_parallel_for_debug_codegen.cpp

24 lines

target_parallel_for_reduction_task_codegen.cpp

8 lines

target_parallel_for_simd_codegen.cpp

352 lines

target_parallel_if_codegen.cpp

152 lines

target_parallel_num_threads_codegen.cpp

128 lines

target_parallel_reduction_task_codegen.cpp

8 lines

target_teams_codegen.cpp

284 lines

target_teams_distribute_codegen.cpp

180 lines

target_teams_distribute_collapse_codegen.cpp

32 lines

target_teams_distribute_dist_schedule_codegen.cpp

128 lines

target_teams_distribute_firstprivate_codegen.cpp

28 lines

target_teams_distribute_lastprivate_codegen.cpp

32 lines

target_teams_distribute_parallel_for_codegen.cpp

88 lines

target_teams_distribute_parallel_for_collapse_codegen.cpp

56 lines

target_teams_distribute_parallel_for_dist_schedule_codegen.cpp

200 lines

target_teams_distribute_parallel_for_firstprivate_codegen.cpp

88 lines

target_teams_distribute_parallel_for_if_codegen.cpp

72 lines

target_teams_distribute_parallel_for_lastprivate_codegen.cpp

56 lines

target_teams_distribute_parallel_for_order_codegen.cpp

8 lines

target_teams_distribute_parallel_for_private_codegen.cpp

80 lines

target_teams_distribute_parallel_for_proc_bind_codegen.cpp

24 lines

target_teams_distribute_parallel_for_reduction_codegen.cpp

88 lines

target_teams_distribute_parallel_for_reduction_task_codegen.cpp

32 lines

target_teams_distribute_parallel_for_schedule_codegen.cpp

688 lines

target_teams_distribute_parallel_for_simd_codegen.cpp

112 lines

target_teams_distribute_parallel_for_simd_collapse_codegen.cpp

56 lines

target_teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

200 lines

target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

88 lines

target_teams_distribute_parallel_for_simd_if_codegen.cpp

316 lines

target_teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

56 lines

target_teams_distribute_parallel_for_simd_private_codegen.cpp

80 lines

target_teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

24 lines

target_teams_distribute_parallel_for_simd_reduction_codegen.cpp

88 lines

target_teams_distribute_parallel_for_simd_schedule_codegen.cpp

688 lines

target_teams_distribute_private_codegen.cpp

20 lines

target_teams_distribute_reduction_codegen.cpp

552 lines

target_teams_distribute_simd_codegen.cpp

360 lines

target_teams_distribute_simd_collapse_codegen.cpp

32 lines

target_teams_distribute_simd_dist_schedule_codegen.cpp

128 lines

target_teams_distribute_simd_firstprivate_codegen.cpp

28 lines

target_teams_distribute_simd_lastprivate_codegen.cpp

32 lines

target_teams_distribute_simd_private_codegen.cpp

20 lines

target_teams_distribute_simd_reduction_codegen.cpp

48 lines

target_teams_map_codegen.cpp

272 lines

target_teams_num_teams_codegen.cpp

128 lines

target_teams_thread_limit_codegen.cpp

128 lines

task_codegen.cpp

76 lines

task_if_codegen.cpp

60 lines

task_in_reduction_codegen.cpp

8 lines

taskgroup_codegen.cpp

8 lines

taskloop_in_reduction_codegen.cpp

8 lines

taskloop_simd_in_reduction_codegen.cpp

8 lines

teams_codegen.cpp

176 lines

teams_distribute_codegen.cpp

64 lines

teams_distribute_collapse_codegen.cpp

32 lines

teams_distribute_dist_schedule_codegen.cpp

128 lines

teams_distribute_firstprivate_codegen.cpp

28 lines

teams_distribute_lastprivate_codegen.cpp

32 lines

teams_distribute_parallel_for_codegen.cpp

112 lines

teams_distribute_parallel_for_collapse_codegen.cpp

56 lines

teams_distribute_parallel_for_copyin_codegen.cpp

48 lines

teams_distribute_parallel_for_dist_schedule_codegen.cpp

200 lines

teams_distribute_parallel_for_firstprivate_codegen.cpp

48 lines

teams_distribute_parallel_for_if_codegen.cpp

72 lines

teams_distribute_parallel_for_lastprivate_codegen.cpp

56 lines

teams_distribute_parallel_for_num_threads_codegen.cpp

96 lines

teams_distribute_parallel_for_private_codegen.cpp

40 lines

teams_distribute_parallel_for_proc_bind_codegen.cpp

24 lines

teams_distribute_parallel_for_reduction_codegen.cpp

88 lines

teams_distribute_parallel_for_reduction_task_codegen.cpp

32 lines

teams_distribute_parallel_for_schedule_codegen.cpp

688 lines

teams_distribute_parallel_for_simd_codegen.cpp

112 lines

teams_distribute_parallel_for_simd_collapse_codegen.cpp

56 lines

teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

200 lines

teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

48 lines

teams_distribute_parallel_for_simd_if_codegen.cpp

300 lines

teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

56 lines

teams_distribute_parallel_for_simd_num_threads_codegen.cpp

96 lines

teams_distribute_parallel_for_simd_private_codegen.cpp

40 lines

teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

24 lines

teams_distribute_parallel_for_simd_reduction_codegen.cpp

88 lines

teams_distribute_parallel_for_simd_schedule_codegen.cpp

688 lines

teams_distribute_private_codegen.cpp

20 lines

teams_distribute_reduction_codegen.cpp

48 lines

teams_distribute_simd_codegen.cpp

96 lines

teams_distribute_simd_collapse_codegen.cpp

32 lines

teams_distribute_simd_dist_schedule_codegen.cpp

128 lines

teams_distribute_simd_firstprivate_codegen.cpp

28 lines

teams_distribute_simd_lastprivate_codegen.cpp

32 lines

teams_distribute_simd_private_codegen.cpp

20 lines

teams_distribute_simd_reduction_codegen.cpp

48 lines

teams_firstprivate_codegen.cpp

88 lines

teams_private_codegen.cpp

56 lines

tile_codegen.cpp

8 lines

unroll_codegen_parallel_for_factor.cpp

4 lines

vla_crash.c

8 lines

utils/

update_cc_test_checks/

Inputs/

generated-funcs.c.generated.expected

8 lines

generated-funcs.c.no-generated.expected

4 lines

[OpenMP] Prefix outlined and reduction func names with original func's nameAcceptedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 508116

clang/lib/CodeGen/CGOpenMPRuntime.h

clang/lib/CodeGen/CGOpenMPRuntime.cpp

clang/lib/CodeGen/CGOpenMPRuntimeGPU.h

clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

clang/lib/CodeGen/CGStmtOpenMP.cpp

clang/test/CodeGen/PowerPC/ppc64le-varargs-f128.c

clang/test/CoverageMapping/openmp.c

clang/test/OpenMP/amdgpu_target_with_aligned_attribute.c

clang/test/OpenMP/bug54082.c

clang/test/OpenMP/bug60602.cpp

clang/test/OpenMP/cancel_codegen.cpp

clang/test/OpenMP/cancellation_point_codegen.cpp

clang/test/OpenMP/debug-info-complex-byval.cpp

clang/test/OpenMP/debug-info-openmp-array.cpp

clang/test/OpenMP/debug_threadprivate_copyin.c

clang/test/OpenMP/declare_target_codegen_globalization.cpp

clang/test/OpenMP/distribute_codegen.cpp

clang/test/OpenMP/distribute_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_private_codegen.cpp

clang/test/OpenMP/distribute_simd_codegen.cpp

clang/test/OpenMP/distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_private_codegen.cpp

clang/test/OpenMP/distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/for_firstprivate_codegen.cpp

clang/test/OpenMP/for_lastprivate_codegen.cpp

clang/test/OpenMP/for_linear_codegen.cpp

clang/test/OpenMP/for_private_codegen.cpp

clang/test/OpenMP/for_reduction_codegen.cpp

clang/test/OpenMP/for_reduction_codegen_UDR.cpp

clang/test/OpenMP/for_reduction_task_codegen.cpp

clang/test/OpenMP/function-attr.cpp

clang/test/OpenMP/master_taskloop_in_reduction_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_in_reduction_codegen.cpp

clang/test/OpenMP/metadirective_device_arch_codegen.cpp

clang/test/OpenMP/metadirective_device_isa_codegen.cpp

clang/test/OpenMP/metadirective_implementation_codegen.c

clang/test/OpenMP/nested_loop_codegen.cpp

clang/test/OpenMP/nvptx_SPMD_codegen.cpp

clang/test/OpenMP/nvptx_allocate_codegen.cpp

clang/test/OpenMP/nvptx_data_sharing.cpp

clang/test/OpenMP/nvptx_distribute_parallel_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_lambda_capturing.cpp

clang/test/OpenMP/nvptx_multi_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_nested_parallel_codegen.cpp

clang/test/OpenMP/nvptx_parallel_codegen.cpp

clang/test/OpenMP/nvptx_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

clang/test/OpenMP/nvptx_target_teams_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_generic_mode_codegen.cpp

[OpenMP] Prefix outlined and reduction func names with original func's name
AcceptedPublic
Actions

Revision Contents
Changeset List