This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove lmuls argument in Sched class
ClosedPublic

Authored by pcwang-thead on Nov 24 2022, 12:37 AM.

Details

Summary

The original intention is adding a list of SchedWrites (which is a
default argument of ReadAdvance) to LMULReadAdvance, but it may not
be practical that there are two default arguments in one class. So
we add variants that are intended for widening and narrowing
instructions with postfix "W" and remove lmuls argument.

Diff Detail

Event Timeline

pcwang-thead requested review of this revision.Nov 24 2022, 12:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2022, 12:37 AM
This revision is now accepted and ready to land.Nov 29 2022, 5:24 PM

There may be some more changes (of the same kind) required depending when this lands because of the following patches:

https://reviews.llvm.org/D137342 (already landed)
https://reviews.llvm.org/D137426

There may be some more changes (of the same kind) required depending when this lands because of the following patches:

https://reviews.llvm.org/D137342 (already landed)
https://reviews.llvm.org/D137426

I will land this first and we can make some changes in D137426 before it is accepted.

This revision was automatically updated to reflect the committed changes.