This is an archive of the discontinued LLVM Phabricator instance.

Differential D138503

[flang] Enable RISC-V for x86CompatibleBehavior in floating point flag
ClosedPublic

Authored by realqhc on Nov 22 2022, 8:13 AM.

Details

Reviewers
rovka
schweitz
brad
LemonBoy
dcederman
vzakhari
Commits
rG1147e70e7ec1: [flang] Enable RISC-V for x86CompatibleBehavior in floating point flag
Summary

Fixes #59132 by mitigating the behavior of not setting underflow flag on RISC-V platform.

Diff Detail

Event Timeline

realqhc created this revision.Nov 22 2022, 8:13 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 22 2022, 8:13 AM
Herald added subscribers: sunshaoce, VincentWu, vkmr and 10 others. · View Herald Transcript
realqhc requested review of this revision.Nov 22 2022, 8:13 AM
Herald added subscribers: • pcwang-thead, jdoerfert. · View Herald TranscriptNov 22 2022, 8:13 AM
realqhc added reviewers: rovka, schweitz, brad, LemonBoy, dcederman.Nov 22 2022, 8:15 AM
realqhc mentioned this in D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.
Harbormaster completed remote builds in B198992: Diff 477206.Nov 22 2022, 9:22 AM
realqhc added a reviewer: vzakhari.Nov 28 2022, 2:52 PM
vzakhari accepted this revision.Nov 28 2022, 3:57 PM

LGTM

This revision is now accepted and ready to land.Nov 28 2022, 3:57 PM
Closed by commit rG1147e70e7ec1: [flang] Enable RISC-V for x86CompatibleBehavior in floating point flag (authored by Qihan Cai <qcai8733@uni.sydney.edu.au>). · Explain WhyNov 29 2022, 2:15 AM
This revision was automatically updated to reflect the committed changes.
Qihan Cai <qcai8733@uni.sydney.edu.au> added a commit: rG1147e70e7ec1: [flang] Enable RISC-V for x86CompatibleBehavior in floating point flag.
SixWeining mentioned this in D143132: [flang] Enable LoongArch for x86CompatibleBehavior in floating point flag.Feb 1 2023, 7:29 PM
SixWeining mentioned this in rG9bfe859e6b46: [flang] Enable LoongArch for x86CompatibleBehavior in floating point flag.Feb 7 2023, 5:57 PM

Revision Contents

PathSize
flang/
include/
flang/
Evaluate/
2 lines

Diff 478487

flang/include/flang/Evaluate/target.h

Show All 19 Lines
// Floating-point rounding control // Floating-point rounding control
struct Rounding { struct Rounding {
common::RoundingMode mode{common::RoundingMode::TiesToEven}; common::RoundingMode mode{common::RoundingMode::TiesToEven};
// When set, emulate status flag behavior peculiar to x86 // When set, emulate status flag behavior peculiar to x86
// (viz., fail to set the Underflow flag when an inexact product of a // (viz., fail to set the Underflow flag when an inexact product of a
// multiplication is rounded up to a normal number from a subnormal // multiplication is rounded up to a normal number from a subnormal
// in some rounding modes) // in some rounding modes)
#if __x86_64__ #if __x86_64__ || __riscv
bool x86CompatibleBehavior{true}; bool x86CompatibleBehavior{true};
#else #else
bool x86CompatibleBehavior{false}; bool x86CompatibleBehavior{false};
#endif #endif
}; };
class TargetCharacteristics { class TargetCharacteristics {
public: public:
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines