This is an archive of the discontinued LLVM Phabricator instance.

Differential D143132

[flang] Enable LoongArch for x86CompatibleBehavior in floating point flag
ClosedPublic

Authored by SixWeining on Feb 1 2023, 7:29 PM.

Details

Reviewers
sscalpone
vzakhari
brad
Commits
rG9bfe859e6b46: [flang] Enable LoongArch for x86CompatibleBehavior in floating point flag
Summary

Similar to D138503 for RISC-V which fix the flang-OldUnit test failure:

.../llvm-project/flang/unittests/Evaluate/real.cpp:504: FAIL:
FlagsToBits(prod.flags) == 0x18, not 0x10
0 0x800001 * 0xbf7ffffe

With this patch applied, check-flang all pass.

Depends on D143131.

Diff Detail

Event Timeline

SixWeining created this revision.Feb 1 2023, 7:29 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 1 2023, 7:29 PM
Herald added subscribers: sunshaoce, luismarques, s.egerton and 3 others. · View Herald Transcript
SixWeining requested review of this revision.Feb 1 2023, 7:29 PM
Herald added subscribers: • pcwang-thead, jdoerfert. · View Herald TranscriptFeb 1 2023, 7:29 PM
Harbormaster completed remote builds in B211371: Diff 494146.Feb 1 2023, 7:50 PM
vzakhari accepted this revision.Feb 3 2023, 12:36 PM
This revision is now accepted and ready to land.Feb 3 2023, 12:36 PM
Closed by commit rG9bfe859e6b46: [flang] Enable LoongArch for x86CompatibleBehavior in floating point flag (authored by SixWeining). · Explain WhyFeb 7 2023, 5:57 PM
This revision was automatically updated to reflect the committed changes.
SixWeining added a commit: rG9bfe859e6b46: [flang] Enable LoongArch for x86CompatibleBehavior in floating point flag.

Revision Contents

PathSize
flang/
include/
flang/
Evaluate/
2 lines

Diff 495699

flang/include/flang/Evaluate/target.h

Show All 19 Lines
// Floating-point rounding control // Floating-point rounding control
struct Rounding { struct Rounding {
common::RoundingMode mode{common::RoundingMode::TiesToEven}; common::RoundingMode mode{common::RoundingMode::TiesToEven};
// When set, emulate status flag behavior peculiar to x86 // When set, emulate status flag behavior peculiar to x86
// (viz., fail to set the Underflow flag when an inexact product of a // (viz., fail to set the Underflow flag when an inexact product of a
// multiplication is rounded up to a normal number from a subnormal // multiplication is rounded up to a normal number from a subnormal
// in some rounding modes) // in some rounding modes)
#if __x86_64__ || __riscv #if __x86_64__ || __riscv || __loongarch__
bool x86CompatibleBehavior{true}; bool x86CompatibleBehavior{true};
#else #else
bool x86CompatibleBehavior{false}; bool x86CompatibleBehavior{false};
#endif #endif
}; };
class TargetCharacteristics { class TargetCharacteristics {
public: public:
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines