The current lowering was converting it into llvm.intr.minnum/maxnum which has
incompattible NaN behavior to the one specified by the arit.min/max ops.
Depends On D137655
Differential D137786
Lower arith.min/max to llvm.intr.minimum/maximum gflegar on Nov 10 2022, 7:03 AM. Authored by
Details
Diff Detail
Event TimelineComment Actions Could you update the patch description with a brief description of the new/intended behavior? This way it would be easier to tell what the change entails without cross-checking with the llvm language reference.
nit: typo in 'arith' Comment Actions I'd like to request comment on https://discourse.llvm.org/t/rfc-explicitly-specifying-nan-and-signed-zero-semantics-for-minf-and-maxf/67539 , as it relates to the topic of this patch Comment Actions I don't think we even have a legalization implementation to expand these. You almost certainly intended to use llvm.minnum/maxnum Comment Actions No, I did want to use llvm.minimum/maximum, because those are the instructions that have the correct semantics for arith.min/max. This should also answer @krzysz00's question: we can't land before the dependent patch is figured out. |