Page MenuHomePhabricator

kuhar (Jakub Kuderski)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2015, 7:49 AM (363 w, 6 d)

Recent Activity

Mon, Jun 13

kuhar accepted D127640: [docs] Adding DirectX target usage doc.
Mon, Jun 13, 8:15 AM · Restricted Project, Restricted Project

Tue, Jun 7

kuhar accepted D127166: [DirectX] Add DirectX target object writer.

LGTM but please get a second approval before submitting

Tue, Jun 7, 10:46 AM · Restricted Project, Restricted Project
kuhar accepted D127165: [DirectX][MC] Add MC support for DXContainer.

LGTM but please get a second approval before submitting

Tue, Jun 7, 10:44 AM · Restricted Project, Restricted Project
kuhar added inline comments to D127165: [DirectX][MC] Add MC support for DXContainer.
Tue, Jun 7, 8:40 AM · Restricted Project, Restricted Project
kuhar added inline comments to D127165: [DirectX][MC] Add MC support for DXContainer.
Tue, Jun 7, 8:40 AM · Restricted Project, Restricted Project
kuhar accepted D127147: [DirectX] Add MC Register and Frame stubs.

LGTM but please get a second approval before submitting.

Tue, Jun 7, 8:31 AM · Restricted Project, Restricted Project

Mon, Jun 6

kuhar added inline comments to D127166: [DirectX] Add DirectX target object writer.
Mon, Jun 6, 8:32 PM · Restricted Project, Restricted Project
kuhar added inline comments to D127165: [DirectX][MC] Add MC support for DXContainer.
Mon, Jun 6, 8:28 PM · Restricted Project, Restricted Project
kuhar added a comment to D127153: [DirectX] Add DXILAsmPrinter.

Would it be possible to test this as-is, or are other changes necessary to meaningfully exercise this code?

Mon, Jun 6, 7:52 PM · Restricted Project, Restricted Project
kuhar added inline comments to D127147: [DirectX] Add MC Register and Frame stubs.
Mon, Jun 6, 7:49 PM · Restricted Project, Restricted Project
kuhar accepted D126795: [DX][ObjYAML] Support for parsing DXIL part.

LGTM

Mon, Jun 6, 2:46 PM · Restricted Project, Restricted Project
kuhar accepted D125334: [DirectX] Embed DXIL in LLVM Module.

LGTM

Mon, Jun 6, 11:49 AM · Restricted Project, Restricted Project

Jun 5 2022

kuhar accepted D126421: ADT/ArrayRef: Add makeMutableArrayRef overloads.

LGTM

Jun 5 2022, 11:48 AM · Restricted Project, Restricted Project

Jun 4 2022

kuhar abandoned D125701: [mlir][NFC] Do not convert bool to int when returning from main.
Jun 4 2022, 7:31 PM · Restricted Project, Restricted Project

Jun 1 2022

kuhar added a comment to D125701: [mlir][NFC] Do not convert bool to int when returning from main.

Kind ping

Jun 1 2022, 12:18 PM · Restricted Project, Restricted Project
kuhar added inline comments to D126795: [DX][ObjYAML] Support for parsing DXIL part.
Jun 1 2022, 12:16 PM · Restricted Project, Restricted Project
kuhar added inline comments to D126795: [DX][ObjYAML] Support for parsing DXIL part.
Jun 1 2022, 11:17 AM · Restricted Project, Restricted Project
kuhar accepted D124804: [Object][DX] Parse DXContainer Parts.

LGTM

Jun 1 2022, 10:29 AM · Restricted Project, Restricted Project

May 27 2022

kuhar committed rGb479ea4b0afc: Add llvm-debuginfod-find tool to Bazel build (authored by vettoreldaniele).
Add llvm-debuginfod-find tool to Bazel build
May 27 2022, 7:23 AM · Restricted Project
kuhar closed D126489: Add llvm-debuginfod-find tool to Bazel build.
May 27 2022, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

kuhar added a comment to D125701: [mlir][NFC] Do not convert bool to int when returning from main.

Can you clarify the motivation for this?

May 25 2022, 10:22 AM · Restricted Project, Restricted Project
kuhar added a reviewer for D125701: [mlir][NFC] Do not convert bool to int when returning from main: antiagainst.

Ping

May 25 2022, 8:00 AM · Restricted Project, Restricted Project
kuhar accepted D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

LGTM but please get a second approval before submitting.

May 25 2022, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2022

kuhar added inline comments to D124804: [Object][DX] Parse DXContainer Parts.
May 24 2022, 12:48 PM · Restricted Project, Restricted Project

May 19 2022

kuhar added inline comments to D124804: [Object][DX] Parse DXContainer Parts.
May 19 2022, 8:44 PM · Restricted Project, Restricted Project
kuhar added a comment to D124804: [Object][DX] Parse DXContainer Parts.

libObject uses MemoryBufferRefs which play back and forth with StringRef, and while it has been pointed out over and over again that many of StringRef’s methods should probably be on MemoryBufferRef because they are more broadly useful, it is the way it is.
I think ArrayRef<char> is probably the least common pattern for representing arbitrary data buffers in LLVM, and given the needs of libObject to operate with MemoryBufferRef I think this code is best to operate on StringRefs.

May 19 2022, 8:28 PM · Restricted Project, Restricted Project
kuhar requested changes to D124804: [Object][DX] Parse DXContainer Parts.

On high level, would it be possible to use an existing class like llvm::BinaryStreamReader instead that most of this data reading machinery?

May 19 2022, 5:24 PM · Restricted Project, Restricted Project

May 16 2022

kuhar resigned from D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.
May 16 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
kuhar resigned from D68460: [MachineSink] Don't preserve MachineLoopInfo.
May 16 2022, 10:59 AM · Restricted Project, Restricted Project
kuhar resigned from D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes.
May 16 2022, 10:59 AM · Restricted Project, Restricted Project
kuhar resigned from D83090: DomTree: Add TreeNode type alias.
May 16 2022, 10:59 AM · Restricted Project, Restricted Project
kuhar resigned from D83092: DomTree: Add climbLhsUntilSiblings helper.
May 16 2022, 10:58 AM · Restricted Project, Restricted Project
kuhar resigned from D83093: DomTree: Define GraphTraits for GenericDomTreeBase.
May 16 2022, 10:58 AM · Restricted Project, Restricted Project
kuhar committed rGffc3a0db003f: [mlir:toy][NFC] Remove unnecessary trailing return type (authored by kuhar).
[mlir:toy][NFC] Remove unnecessary trailing return type
May 16 2022, 10:48 AM · Restricted Project, Restricted Project
kuhar closed D125697: [mlir:toy][NFC] Remove unnecessary trailing return type.
May 16 2022, 10:47 AM · Restricted Project, Restricted Project
kuhar requested review of D125701: [mlir][NFC] Do not convert bool to int when returning from main.
May 16 2022, 9:21 AM · Restricted Project, Restricted Project
kuhar requested review of D125697: [mlir:toy][NFC] Remove unnecessary trailing return type.
May 16 2022, 8:51 AM · Restricted Project, Restricted Project

May 10 2022

kuhar added a comment to D123481: Do not build with Werror by default (Bazel build).

+1, I had to patch this locally in my project for exactly the reasons you mentioned

I don't understand what you mean about having to patch it locally in a different project. bazelrc files are only applicable to the project itself, not anything that uses it as a dependency.

May 10 2022, 7:10 PM · Restricted Project, Restricted Project
kuhar added inline comments to D125334: [DirectX] Embed DXIL in LLVM Module.
May 10 2022, 1:10 PM · Restricted Project, Restricted Project
kuhar added inline comments to D125334: [DirectX] Embed DXIL in LLVM Module.
May 10 2022, 1:06 PM · Restricted Project, Restricted Project
kuhar accepted D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function..

LGTM but please get another one before submitting

May 10 2022, 10:06 AM · Restricted Project, Restricted Project
kuhar added inline comments to D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function..
May 10 2022, 10:01 AM · Restricted Project, Restricted Project
kuhar added inline comments to D125158: [DirectX backend] Add pass to emit dxil metadata..
May 10 2022, 9:51 AM · Restricted Project, Restricted Project

May 9 2022

kuhar accepted D122269: Modify DXILPrepare to emit no-op bitcasts.
May 9 2022, 10:35 AM · Restricted Project, Restricted Project
kuhar accepted D125158: [DirectX backend] Add pass to emit dxil metadata..

LGTM but please get another one before submitting.

May 9 2022, 10:25 AM · Restricted Project, Restricted Project
kuhar added inline comments to D122270: Support converting pointers from opaque to typed.
May 9 2022, 7:54 AM · Restricted Project, Restricted Project, Restricted Project

May 8 2022

kuhar added inline comments to D125158: [DirectX backend] Add pass to emit dxil metadata..
May 8 2022, 7:47 PM · Restricted Project, Restricted Project
kuhar added inline comments to D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function..
May 8 2022, 7:43 PM · Restricted Project, Restricted Project
kuhar added inline comments to D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function..
May 8 2022, 7:40 PM · Restricted Project, Restricted Project
kuhar added inline comments to D122270: Support converting pointers from opaque to typed.
May 8 2022, 7:33 PM · Restricted Project, Restricted Project, Restricted Project
kuhar added inline comments to D122270: Support converting pointers from opaque to typed.
May 8 2022, 7:31 PM · Restricted Project, Restricted Project, Restricted Project
kuhar added inline comments to D122270: Support converting pointers from opaque to typed.
May 8 2022, 7:06 PM · Restricted Project, Restricted Project, Restricted Project
kuhar added inline comments to D122269: Modify DXILPrepare to emit no-op bitcasts.
May 8 2022, 7:03 PM · Restricted Project, Restricted Project
kuhar added inline comments to D122269: Modify DXILPrepare to emit no-op bitcasts.
May 8 2022, 6:57 PM · Restricted Project, Restricted Project

Apr 25 2022

kuhar accepted D122268: Add PointerType analysis for DirectX backend.

LGTM modulo nits. Thanks for the fixes!

Apr 25 2022, 3:00 PM · Restricted Project, Restricted Project
kuhar added inline comments to D122268: Add PointerType analysis for DirectX backend.
Apr 25 2022, 2:47 PM · Restricted Project, Restricted Project
kuhar added inline comments to D122268: Add PointerType analysis for DirectX backend.
Apr 25 2022, 2:42 PM · Restricted Project, Restricted Project
kuhar added inline comments to D122268: Add PointerType analysis for DirectX backend.
Apr 25 2022, 2:41 PM · Restricted Project, Restricted Project
kuhar added inline comments to D122268: Add PointerType analysis for DirectX backend.
Apr 25 2022, 11:30 AM · Restricted Project, Restricted Project

Apr 11 2022

kuhar accepted D123481: Do not build with Werror by default (Bazel build).

+1, I had to patch this locally in my project for exactly the reasons you mentioned

Apr 11 2022, 7:05 AM · Restricted Project, Restricted Project

Apr 8 2022

kuhar accepted D123278: [Clang] [Docs] Add HLSLSupport page.

LGTM

Apr 8 2022, 7:27 AM · Restricted Project, Restricted Project

Apr 7 2022

kuhar added inline comments to D123278: [Clang] [Docs] Add HLSLSupport page.
Apr 7 2022, 1:10 PM · Restricted Project, Restricted Project
kuhar added a comment to D123278: [Clang] [Docs] Add HLSLSupport page.

Looks good to me overall, I just left some local comments. Please take my writing suggestions with a pinch of salt, English is my second language.

Apr 7 2022, 1:08 PM · Restricted Project, Restricted Project

Mar 29 2022

kuhar added inline comments to D122079: [ADT] add initializer list specialization for is_contained.
Mar 29 2022, 10:28 AM · Restricted Project, Restricted Project
kuhar added inline comments to D122079: [ADT] add initializer list specialization for is_contained.
Mar 29 2022, 10:27 AM · Restricted Project, Restricted Project
kuhar accepted D122079: [ADT] add initializer list specialization for is_contained.

LGTM, thanks for the fixes.

Mar 29 2022, 10:25 AM · Restricted Project, Restricted Project
kuhar added inline comments to D122079: [ADT] add initializer list specialization for is_contained.
Mar 29 2022, 8:54 AM · Restricted Project, Restricted Project
kuhar added a comment to D122079: [ADT] add initializer list specialization for is_contained.

Could you also add some tests that make sure this can be constant-evaluated? (e.g., with static_assert)

Mar 29 2022, 8:52 AM · Restricted Project, Restricted Project

Mar 25 2022

kuhar added inline comments to D122268: Add PointerType analysis for DirectX backend.
Mar 25 2022, 10:51 AM · Restricted Project, Restricted Project
kuhar added inline comments to D122268: Add PointerType analysis for DirectX backend.
Mar 25 2022, 10:39 AM · Restricted Project, Restricted Project

Mar 22 2022

kuhar added a comment to D122079: [ADT] add initializer list specialization for is_contained.
Mar 22 2022, 9:09 PM · Restricted Project, Restricted Project

Mar 21 2022

kuhar added a comment to D122079: [ADT] add initializer list specialization for is_contained.

A few thoughts:

  1. Is the requirement for this to be constant folded by the optimizer?
  2. This could be made constexpr if we wanted.
  3. The function name suggests this handles enums only but it works with any copybale & comparable type. I think we should either restrict it to enum types or make the name more general.
  4. Since this function is not constexpr now, how about we added an overload to is_contained accepting an initializer list as the second element, e.g.: is_constained(MyEnum::A, {MyEnum::A, MyEnum::B, MyEnum::C})?
Mar 21 2022, 6:34 AM · Restricted Project, Restricted Project

Mar 16 2022

kuhar committed rG7c285b78cfd3: [bazel] Add build rule for llvm-remark-size-diff (authored by kuhar).
[bazel] Add build rule for llvm-remark-size-diff
Mar 16 2022, 11:08 AM · Restricted Project
kuhar closed D121742: [bazel] Add build rule for llvm-remark-size-diff.
Mar 16 2022, 11:07 AM · Restricted Project, Restricted Project
kuhar added a comment to D120811: [Dominators] Don't treat multi-edge as dominating.

I'm not too sure about the semantics either. I think it might be easier to think about if we tie this back to regular graphs without multi-edges.

Mar 16 2022, 7:42 AM · Restricted Project, Restricted Project

Mar 15 2022

kuhar added a reviewer for D121742: [bazel] Add build rule for llvm-remark-size-diff: dblaikie.
Mar 15 2022, 3:03 PM · Restricted Project, Restricted Project
kuhar updated the summary of D121742: [bazel] Add build rule for llvm-remark-size-diff.
Mar 15 2022, 2:32 PM · Restricted Project, Restricted Project
kuhar requested review of D121742: [bazel] Add build rule for llvm-remark-size-diff.
Mar 15 2022, 2:31 PM · Restricted Project, Restricted Project

Feb 23 2022

kuhar accepted D119061: [Clang] noinline call site attribute.

LGTM but please get at least one additional approval before submitting

Feb 23 2022, 10:24 AM · Restricted Project

Feb 14 2022

kuhar added inline comments to D119061: [Clang] noinline call site attribute.
Feb 14 2022, 12:47 PM · Restricted Project

Feb 10 2022

kuhar added a comment to D119061: [Clang] noinline call site attribute.

Do you plan to also add inline and flatten?

You mean always_inline? Yes, after noinline. The flatten call site attribute - theoretically why not, but it needs to be reworked in LLVM (like always_inline_recursively) before any patch like this one.

Feb 10 2022, 2:16 PM · Restricted Project
kuhar added a comment to D119061: [Clang] noinline call site attribute.

Thanks for working on this, @xbolva00! I don't know this part of the codebase, so won't comment on the patch itself. Just a few questions/suggestions:

Feb 10 2022, 1:59 PM · Restricted Project

Jan 30 2022

kuhar accepted D118386: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`.

LGTM

Jan 30 2022, 11:50 AM · Restricted Project, Restricted Project

Jan 28 2022

kuhar added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

@phosek, this patch fixes a regression that was introduced with D116521.
Could we fix this regression first with a simple patch that does not risk to be reverted again and do further refactorings afterwards?
Our downstream gcc build is broken and we’d like to re-enable it rather sooner than later.

Jan 28 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 5 2022

kuhar accepted D116610: [ADCE][NFC] Batch DT updates together.

LGTM

Jan 5 2022, 1:42 PM · Restricted Project

Jan 4 2022

kuhar added inline comments to D116610: [ADCE][NFC] Batch DT updates together.
Jan 4 2022, 7:36 PM · Restricted Project
kuhar added inline comments to D116610: [ADCE][NFC] Batch DT updates together.
Jan 4 2022, 2:48 PM · Restricted Project
kuhar added a comment to D116610: [ADCE][NFC] Batch DT updates together.

This change is NFC but can improve the runtime of the compiler dramatically in some pathological cases (where the pass was pushing a lot (several thousands) of small updates (less than 6)).
For instance on the motivating example we went from 300+ sec to less than a second.

Jan 4 2022, 11:30 AM · Restricted Project

Dec 23 2021

kuhar committed rG5410152827cc: [Bazel] Add target for llvm-tli-checker (authored by kuhar).
[Bazel] Add target for llvm-tli-checker
Dec 23 2021, 10:16 AM
kuhar closed D116222: [Bazel] Add target for llvm-tli-checker.
Dec 23 2021, 10:15 AM · Restricted Project
kuhar requested review of D116222: [Bazel] Add target for llvm-tli-checker.
Dec 23 2021, 9:05 AM · Restricted Project

Dec 18 2021

kuhar committed rG1e93f3895fc3: [AMDGPU] Use enum_seq to iterator over InstCounterTypes. NFC. (authored by kuhar).
[AMDGPU] Use enum_seq to iterator over InstCounterTypes. NFC.
Dec 18 2021, 1:10 PM
kuhar closed D115900: [AMDGPU] Use enum_seq to iterator over InstCounterTypes. NFC..
Dec 18 2021, 1:10 PM · Restricted Project
kuhar committed rGd9ae852fcc97: [AMDGPU] Fix data race in SIInsertWaitcnts (authored by kuhar).
[AMDGPU] Fix data race in SIInsertWaitcnts
Dec 18 2021, 1:05 PM
kuhar closed D115896: [AMDGPU] Fix data race in SIInsertWaitcnts.
Dec 18 2021, 1:05 PM · Restricted Project

Dec 16 2021

kuhar requested review of D115900: [AMDGPU] Use enum_seq to iterator over InstCounterTypes. NFC..
Dec 16 2021, 1:16 PM · Restricted Project
kuhar requested review of D115896: [AMDGPU] Fix data race in SIInsertWaitcnts.
Dec 16 2021, 12:23 PM · Restricted Project

Nov 26 2021

kuhar added a comment to D110292: Use a deterministic order when updating the DominatorTree.

I think it would be good to send the DomTree documentation changes separately as they are a clear improvement regardless of whether this patch goes in or not.

Nov 26 2021, 8:10 AM · Restricted Project
kuhar added inline comments to D110292: Use a deterministic order when updating the DominatorTree.
Nov 26 2021, 7:00 AM · Restricted Project

Nov 5 2021

kuhar added a comment to D107378: Make enum iteration with seq safe by default.

Hi @kuhar,

looks like these changes are reason of bunch of build warnings on the windows builders (VC). I see more than 1000 additional warnings such as

C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(119): warning C4309: 'static_cast': truncation of constant value
C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(120): warning C4309: 'static_cast': truncation of constant value
C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(119): warning C4309: 'static_cast': truncation of constant value
C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(120): warning C4309: 'static_cast': truncation of constant value

starting at this build https://lab.llvm.org/buildbot/#/builders/60/builds/5295

would you take care of them?
Thank you.

Nov 5 2021, 2:58 PM · Restricted Project