[flang]Fix build failure in tests

[Leporacanthicus]

Summary

After submitting the DataLayout fix, some tests fail when they didn't
before. This has to do with the target essentially being ignored when
these tests were run earlier, as the --target x86-unknown-linux-gnu
only has to be correctly formed to be accepted.

Now the target triple is actually being used to get the targetmachine
earlier - before MLIR is generated - so the test that has a valid target
but not available on the platform fails.

Fix is to require x86 registered target when running those tests.

[tblah]

This comment was removed by tblah.

[awarzynski]

What if you remove --target=x86_64-unknown-linux-gnu instead and make the tests target agnostic?

[Leporacanthicus]

Update to correct typos.

[Leporacanthicus]

Instead of requiring x86, remove target in tests. This will allow
testing on a wider range of targets, rather than a smaller range.

[tblah]

flang/test/Fir/boxchar.fir

4

Why does this test require x86 now that the --target flag is removed?

[awarzynski]

LGTM, thanks! Please wait for the pre-commit to be on the safe side :)

[Leporacanthicus]

In D137335#3905159, @awarzynski wrote:

What if you remove --target=x86_64-unknown-linux-gnu instead and make the tests target agnostic?

Yeah, that is likely working too.

[Leporacanthicus]

Try again, this time without requires line

flang/test/Fir/boxchar.fir

4

It doesn't. Too much haste, not enough speed! :)

flang/test/Fir/boxchar.fir

+// REQUIRES: x86-registered-target
+
 // RUN: tco --target=x86_64-unknown-linux-gnu %s | FileCheck %s
 // RUN: %flang_fc1 -emit-llvm -triple x86_64-unknown-linux-gnu %s -o - | FileCheck %s
 
 // Test of building and passing boxchar.
 
 func.func private @callee(%x : !fir.boxchar<1>)
 
 // CHECK-LABEL: define void @get_name
 func.func @get_name() {
   %1 = fir.address_of (@name) : !fir.ref<!fir.char<1,9>>

flang/test/Fir/inline.fir

+// REQUIRES: x86-registered-target
+
 // RUN: tco --target=x86_64-unknown-linux-gnu --inline-all %s -o - | FileCheck %s
 // RUN: %flang_fc1 -triple x86_64-unknown-linux-gnu -mmlir --inline-all -emit-llvm %s -o - | FileCheck %s
 
 // CHECK-LABEL: @add
 func.func @add(%a : i32, %b : i32) -> i32 {
   // CHECK: %[[add:.*]] = add i32
   %p = arith.addi %a, %b : i32
   // CHECK: ret i32 %[[add]]