Page MenuHomePhabricator

tblah (Tom Eccles)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2022, 2:43 AM (41 w, 5 d)

Recent Activity

Today

tblah requested review of D142898: WIP: [flang] lower sum intrinsic to hlfir.sum operation.
Mon, Jan 30, 7:43 AM · Restricted Project, Restricted Project
tblah requested review of D142897: WIP: [flang] add hlfir.sum operation.
Mon, Jan 30, 7:37 AM · Restricted Project, Restricted Project

Sat, Jan 28

tblah added inline comments to D138675: [flang] Add -ffast-math and -Ofast.
Sat, Jan 28, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
tblah requested review of D142807: [flang] Use clang sysroot image to test fastmath linking.
Sat, Jan 28, 5:53 AM · Restricted Project, Restricted Project

Thu, Jan 26

tblah added a comment to D140415: [flang] stack arrays pass.
Thu, Jan 26, 3:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Jan 25

tblah added a comment to D140415: [flang] stack arrays pass.

Thanks for taking a look, see my responses inline. For more information, the RFC is at https://reviews.llvm.org/D139617

Wed, Jan 25, 8:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah added inline comments to D140415: [flang] stack arrays pass.
Wed, Jan 25, 2:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.
  • Add missing early return for allocations not for arrays
  • Remove braces from if statement with a single statement in its body
  • Assert that a correct insertion point is found for the alloca
Wed, Jan 25, 2:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah added inline comments to D141401: [mlir] Add `mlir::blockIsInLoop()`.
Wed, Jan 25, 2:26 AM · Restricted Project, Restricted Project
tblah updated the diff for D141401: [mlir] Add `mlir::blockIsInLoop()`.
  • Check for a parent implementing LoopLikeOpInterface before searching for a CFG loop
  • Don't use recursion when searching for CFG cycles
  • Stop hierarchical search at anything implementing FunctionOpInterface, not just func.func
Wed, Jan 25, 2:21 AM · Restricted Project, Restricted Project

Tue, Jan 24

tblah added a comment to D140415: [flang] stack arrays pass.

Ping for review

Tue, Jan 24, 3:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah added a comment to D141401: [mlir] Add `mlir::blockIsInLoop()`.

Ping for any MLIR reviewers

Tue, Jan 24, 3:45 AM · Restricted Project, Restricted Project

Mon, Jan 23

tblah updated the diff for D140972: [flang] Add -fstack-arrays flag.
  • Rename option macro to make it clear that it doesn't do marshalling
Mon, Jan 23, 2:15 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jan 20

tblah committed rGd47a0ace5d39: [mlir][Linalg] fix comparison of integers with different signs (authored by tblah).
[mlir][Linalg] fix comparison of integers with different signs
Fri, Jan 20, 7:12 AM · Restricted Project, Restricted Project
tblah closed D142201: [mlir][Linalg] Use unsigned return type for RelayoutOp::getSourceRank,getDestRank.
Fri, Jan 20, 7:12 AM · Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.

Fix newly added tests

Fri, Jan 20, 6:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah retitled D142201: [mlir][Linalg] Use unsigned return type for RelayoutOp::getSourceRank,getDestRank from [mlir][Linalg] fix comparison of integers with different signs to [mlir][Linalg] Use unsigned return type for RelayoutOp::getSourceRank,getDestRank.
Fri, Jan 20, 6:11 AM · Restricted Project, Restricted Project
tblah updated the diff for D140972: [flang] Add -fstack-arrays flag.

Update to ensure that generated code for Options.td does not try to reference
clang::CodegenOpts::StackArrays.

Fri, Jan 20, 5:57 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D142201: [mlir][Linalg] Use unsigned return type for RelayoutOp::getSourceRank,getDestRank.

Updated getSourceRank and getDestRank to return size_t to avoid comparison
between int64_t and size_t.

Fri, Jan 20, 5:51 AM · Restricted Project, Restricted Project
tblah requested review of D142202: [mlir][Linalg] Fix ignoring nodiscard return value.
Fri, Jan 20, 4:28 AM · Restricted Project, Restricted Project
tblah requested review of D142201: [mlir][Linalg] Use unsigned return type for RelayoutOp::getSourceRank,getDestRank.
Fri, Jan 20, 4:24 AM · Restricted Project, Restricted Project

Wed, Jan 18

tblah added inline comments to D141401: [mlir] Add `mlir::blockIsInLoop()`.
Wed, Jan 18, 6:57 AM · Restricted Project, Restricted Project
tblah updated the diff for D141401: [mlir] Add `mlir::blockIsInLoop()`.

Handle case where blocks are nested inside of eachother

Wed, Jan 18, 6:56 AM · Restricted Project, Restricted Project
tblah updated the diff for D140972: [flang] Add -fstack-arrays flag.

Clarified a comment in stack-arrays.f90 and clarified the choice of FileCheck
prefix.

Wed, Jan 18, 3:37 AM · Restricted Project, Restricted Project, Restricted Project
tblah retitled D141401: [mlir] Add `mlir::blockIsInLoop()` from [mlir] Add `Block::isInLoop` to [mlir] Add `mlir::blockIsInLoop()`.
Wed, Jan 18, 3:13 AM · Restricted Project, Restricted Project
tblah updated the diff for D141401: [mlir] Add `mlir::blockIsInLoop()`.

Updated a comment and documentation string in the test pass to make it clear
the loop detection is no longer a method in mlir::Block

Wed, Jan 18, 3:12 AM · Restricted Project, Restricted Project

Tue, Jan 17

tblah added inline comments to D141401: [mlir] Add `mlir::blockIsInLoop()`.
Tue, Jan 17, 6:57 AM · Restricted Project, Restricted Project
tblah added a comment to D141401: [mlir] Add `mlir::blockIsInLoop()`.

@rriddle ping

Tue, Jan 17, 4:24 AM · Restricted Project, Restricted Project
tblah added inline comments to D140415: [flang] stack arrays pass.
Tue, Jan 17, 3:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.
  • Implement operator!= as !(operator==)
  • Move insertion point computation to StackArraysAnalysisWrapper::analyseFunction
  • Remove special-casing for join(allocated, unknown)
  • Add processing of fir.result to AllocationAnalysis::visitOperation so that lattices are propagated out of nested blocks
  • Walk function returns not freememops
  • Add a test checking that the data flow analysis gives correct results for scf.if
Tue, Jan 17, 3:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Jan 16

tblah added inline comments to D140972: [flang] Add -fstack-arrays flag.
Mon, Jan 16, 3:27 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D140972: [flang] Add -fstack-arrays flag.

Update to address review comments

Mon, Jan 16, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jan 13

tblah added reviewers for D141401: [mlir] Add `mlir::blockIsInLoop()`: Mogball, jpienaar, ftynse.
Fri, Jan 13, 2:23 AM · Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.

Updating patch context

Fri, Jan 13, 2:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Jan 12

tblah updated the diff for D140972: [flang] Add -fstack-arrays flag.

Updated to construct StackArrays as a ModuleOp pass

Thu, Jan 12, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.
  • Do not move allocations outside of openmp regions
  • Detect loops in the control flow graph
  • Attempt to use llvm.stacksave/llvm.stackrestore to allow stack allocations inside of loops
Thu, Jan 12, 9:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah added a comment to D141401: [mlir] Add `mlir::blockIsInLoop()`.

Thanks for review @DavidTruby

Thu, Jan 12, 7:46 AM · Restricted Project, Restricted Project
tblah updated the diff for D141401: [mlir] Add `mlir::blockIsInLoop()`.

Updated to use llvm::any_of instead of a for loop and an if.

Thu, Jan 12, 7:45 AM · Restricted Project, Restricted Project
tblah updated the diff for D139617: [flang] RFC: -fstack-arrays implementation.
  • Add mention of CFG loops, removed TODO for goto statements
  • Specified the conditions under which llvm.stacksave/llvm.stackrestore intrinsics are safe to use
Thu, Jan 12, 7:00 AM · Restricted Project, Restricted Project

Wed, Jan 11

tblah updated the diff for D141401: [mlir] Add `mlir::blockIsInLoop()`.

Moved to a stand alone function in LoopLikeInterface.h

Wed, Jan 11, 3:33 AM · Restricted Project, Restricted Project

Tue, Jan 10

tblah requested review of D141401: [mlir] Add `mlir::blockIsInLoop()`.
Tue, Jan 10, 9:10 AM · Restricted Project, Restricted Project

Fri, Jan 6

tblah added a comment to D140415: [flang] stack arrays pass.

Maybe it's worth testing SPEC 2017 (and SNAP?) about the compilation time increase and the performance improvement with -fstack-arrays?

Fri, Jan 6, 3:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah abandoned D138409: [flang] add -f[no-]rounding-math.
Fri, Jan 6, 2:22 AM · Restricted Project
tblah abandoned D138410: [flang] add -f[no-]trapping-math.
Fri, Jan 6, 2:22 AM · Restricted Project

Thu, Jan 5

tblah added inline comments to D140415: [flang] stack arrays pass.
Thu, Jan 5, 8:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah added a comment to D140415: [flang] stack arrays pass.

I am wondering about its cost compared to a solution that would apply the option when creating the allocations in lowering in a centralized FirOpBuilder helper to create array temps. Do you have any idea of the complexity of this pass? e.g. is it linear with the number of blocks/FIR instruction?

Thu, Jan 5, 5:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah added inline comments to D139617: [flang] RFC: -fstack-arrays implementation.
Thu, Jan 5, 5:46 AM · Restricted Project, Restricted Project
tblah updated the diff for D139617: [flang] RFC: -fstack-arrays implementation.
  • Remove quote from gfortran's man page
  • Fix typo
Thu, Jan 5, 5:45 AM · Restricted Project, Restricted Project

Wed, Jan 4

tblah requested review of D140972: [flang] Add -fstack-arrays flag.
Wed, Jan 4, 5:12 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.

Update patch again because I missed a test removal in the last update

Wed, Jan 4, 2:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D140415: [flang] stack arrays pass.

Un-WIP'ed, removed tests for the two unsupported cases (see the RFC for more information).

Wed, Jan 4, 2:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D139617: [flang] RFC: -fstack-arrays implementation.
  • Added a paragraph explaining handling of fir.call operations during data flow analysis
  • Added information about the two known cases where the existing analysis is insufficient (see the section on ConvertExpr.cpp)
Wed, Jan 4, 2:33 AM · Restricted Project, Restricted Project
tblah committed rG5bedd675d741: [mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation (authored by tblah).
[mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation
Wed, Jan 4, 2:24 AM · Restricted Project, Restricted Project
tblah closed D140879: [mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation.
Wed, Jan 4, 2:24 AM · Restricted Project, Restricted Project

Tue, Jan 3

tblah added a comment to D140879: [mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation.

+1 but why is the rename necessary? From what I understand, the name shouldn't conflict with any other method...

Tue, Jan 3, 8:18 AM · Restricted Project, Restricted Project
tblah updated the summary of D140879: [mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation.
Tue, Jan 3, 3:36 AM · Restricted Project, Restricted Project
tblah requested review of D140879: [mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation.
Tue, Jan 3, 3:36 AM · Restricted Project, Restricted Project

Dec 29 2022

tblah updated the diff for D140415: [flang] stack arrays pass.

Changes in the new patch version

  • Calculate allocmem insertion point in the analysis stage so that we can catch all failures during analysis and then succeed when making real code changes
  • Pass the lattice through fir.call operations. This is important so that we move allocations for array temporaries created for function arguments. It is safe to assume that functions do not change the allocation status of the allocations we are tracking because we only track allocations for temporaries created by flang.
  • Add some tests. The last three tests in stack-arrays.f90 don't check anything useful yet: they are placeholders for when the stack arrays can handle these cases correctly.
Dec 29 2022, 2:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 21 2022

tblah updated the diff for D140415: [flang] stack arrays pass.

Thanks for review.

Dec 21 2022, 8:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 20 2022

tblah added a comment to D139617: [flang] RFC: -fstack-arrays implementation.

There is a WIP implementation of the RFC at https://reviews.llvm.org/D140415

Dec 20 2022, 9:17 AM · Restricted Project, Restricted Project
tblah requested review of D140415: [flang] stack arrays pass.
Dec 20 2022, 9:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 19 2022

tblah updated the diff for D139617: [flang] RFC: -fstack-arrays implementation.

Add a section naming a new FIR attribute to mark allocations which should never be moved to the stack: fir.must_be_heap

Dec 19 2022, 5:57 AM · Restricted Project, Restricted Project

Dec 14 2022

tblah updated the diff for D139617: [flang] RFC: -fstack-arrays implementation.

Thank you everyone for the feedback so far.

Dec 14 2022, 9:07 AM · Restricted Project, Restricted Project
tblah added a comment to D138675: [flang] Add -ffast-math and -Ofast.

See D139967 for why UNSUPPORTED: powerpc didn't work. That patch will put it back, and also update the lit config so the check will work now.

Dec 14 2022, 8:34 AM · Restricted Project, Restricted Project, Restricted Project
tblah accepted D140016: [flang] Disable LTO when building the flang runtime.

LGTM, thanks for fixing this!

Dec 14 2022, 5:48 AM · Restricted Project, Restricted Project

Dec 12 2022

tblah added a comment to D138675: [flang] Add -ffast-math and -Ofast.

Thanks for the follow up patch! I tested the patch locally and also saw the buildbot results, and it doesn't appear like the follow up patch marked powerpc as unsupported as the error still persists (https://lab.llvm.org/buildbot/#/builders/21/builds/57850).
I was playing around with the test case locally and what appears to work is doing something like:

! UNSUPPORTED: powerpc-registered-target
Dec 12 2022, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
tblah committed rG9d86f2dc4f1d: [flang] skip fast_math linker test on powerpc #3 (authored by tblah).
[flang] skip fast_math linker test on powerpc #3
Dec 12 2022, 1:50 PM · Restricted Project, Restricted Project
tblah added a comment to D138675: [flang] Add -ffast-math and -Ofast.

Hi,

The ppc64le-flang-rhel-clang bot is also experiencing some failures with the Driver/fast_math.f90 test case. In particular, crtfastmath.o is not found at all for CHECK-CRT as we can see in the failure details.

llvm-project/flang/test/Driver/fast_math.f90:64:19: error: CHECK-CRT-SAME: expected string not found in input
! CHECK-CRT-SAME: crtfastmath.o

The output for the CHECK-CRT line on the bot looks like the following:

"/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/flang-new" "-fc1" "-triple" "powerpc64le-unknown-linux-gnu" "-emit-obj" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-ffast-math" "-target-cpu" "ppc64le" "-o" "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-x" "f95-cpp-input" "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Driver/fast_math.f90" 

"/usr/bin/ld" "-pie" "--hash-style=gnu" "--eh-frame-hdr" "-m" "elf64lppc" "-dynamic-linker" "/lib64/ld64.so.2" "-o" "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/test/Driver/Output/fast_math.f90.tmp" "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/Scrt1.o" "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/crti.o" "/usr/lib/gcc/ppc64le-redhat-linux/8/crtbeginS.o" "-L/usr/lib/gcc/ppc64le-redhat-linux/8" "-L/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64" "-L/lib/../lib64" "-L/usr/lib/../lib64" "-L/lib" "-L/usr/lib" "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-lFortran_main" "-lFortranRuntime" "-lFortranDecimal" "-lm" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "-lc" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "/usr/lib/gcc/ppc64le-redhat-linux/8/crtendS.o" "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/crtn.o"

Would it be possible to follow up with a fix for this test case?

Dec 12 2022, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
tblah committed rG6442b4da4e70: [flang] disable fast_math test on powerpc (authored by tblah).
[flang] disable fast_math test on powerpc
Dec 12 2022, 12:05 PM · Restricted Project, Restricted Project
tblah committed rG1a4f1449ac52: [flang] Match alternative names for crtend in fastmath test (authored by tblah).
[flang] Match alternative names for crtend in fastmath test
Dec 12 2022, 5:35 AM · Restricted Project, Restricted Project
tblah committed rG5d91f79fced1: [mlir] Fix -Wstrict-prototypes warning (authored by tblah).
[mlir] Fix -Wstrict-prototypes warning
Dec 12 2022, 4:06 AM · Restricted Project, Restricted Project
tblah closed D139322: [mlir] Fix -Wstrict-prototypes warnings.
Dec 12 2022, 4:05 AM · Restricted Project, Restricted Project
tblah added a comment to D138675: [flang] Add -ffast-math and -Ofast.

I have the Driver/fast_math.f90 failing on my side.

llvm-project/flang/test/Driver/fast_math.f90:63:14: error: CHECK-CRT: expected string not found in input
! CHECK-CRT: crtbeginS.o

I have a crtbegin.o in the link line but not a crtbeginS.o

Dec 12 2022, 3:30 AM · Restricted Project, Restricted Project, Restricted Project
tblah committed rGbea45027b43e: [flang] match alternate names for crtbegin in fastmath test (authored by tblah).
[flang] match alternate names for crtbegin in fastmath test
Dec 12 2022, 3:29 AM · Restricted Project, Restricted Project
tblah added a comment to D139322: [mlir] Fix -Wstrict-prototypes warnings.

ping @nicolasvasilache

Dec 12 2022, 3:25 AM · Restricted Project, Restricted Project

Dec 10 2022

tblah added inline comments to D139617: [flang] RFC: -fstack-arrays implementation.
Dec 10 2022, 2:44 AM · Restricted Project, Restricted Project

Dec 9 2022

tblah committed rG20cd3153f377: [flang] Skip fast_math linker test on powerpc (authored by tblah).
[flang] Skip fast_math linker test on powerpc
Dec 9 2022, 1:27 PM · Restricted Project, Restricted Project
tblah committed rGe7b6660243d1: [flang] Add -ffast-math and -Ofast (authored by tblah).
[flang] Add -ffast-math and -Ofast
Dec 9 2022, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
tblah closed D138675: [flang] Add -ffast-math and -Ofast.
Dec 9 2022, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D138675: [flang] Add -ffast-math and -Ofast.

Update with nitpicks to documentation (mostly to re-run Windows CI)

Dec 9 2022, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
tblah added a comment to D138675: [flang] Add -ffast-math and -Ofast.

Failed Tests (5):

Flang :: Fir/boxproc.fir
Flang :: Fir/target-rewrite-arg-position.fir
Flang :: Fir/target-rewrite-boxchar.fir
Flang :: Fir/target-rewrite-char-proc.fir
Flang :: Fir/target.fir
Dec 9 2022, 6:24 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D138675: [flang] Add -ffast-math and -Ofast.

Update patch to skip the test for linking to crtfastmath.o on Windows as there doesn't seem to be a Windows equivalent of crtfastmath.o.

Dec 9 2022, 5:34 AM · Restricted Project, Restricted Project, Restricted Project
tblah added inline comments to D139617: [flang] RFC: -fstack-arrays implementation.
Dec 9 2022, 3:50 AM · Restricted Project, Restricted Project

Dec 8 2022

tblah added inline comments to D139617: [flang] RFC: -fstack-arrays implementation.
Dec 8 2022, 10:34 AM · Restricted Project, Restricted Project
tblah added a comment to D139617: [flang] RFC: -fstack-arrays implementation.

Could you also comment on why a general pass like MemoryAllocationOpt that converts Stack Allocation to Heap Allocation is not suitable here? Please include this in the RFC as an alternative option that was considered.

That would be good to know. Modifying the behavior in all the mentioned places sounds a bit hacky and error prone in the future. How are you going to ensure future code will follow what you propose here. I think a centralized pass is preferred even if it requires extra attributes or smth similar.

Dec 8 2022, 10:32 AM · Restricted Project, Restricted Project
tblah updated the diff for D139617: [flang] RFC: -fstack-arrays implementation.
  • Organize document according to the format recommended in DesignGuideline.md
    • Explain why a piecemeal approach was chosen instead of a single pass performing this conversion
    • Mention that most of the referenced code will be replaced by HLFIR
    • Include an example of the changes to array value copy
    • Provide a more detailed explanation of ConvertVariable.cpp
    • Add a testing plan
Dec 8 2022, 10:27 AM · Restricted Project, Restricted Project
tblah requested review of D139617: [flang] RFC: -fstack-arrays implementation.
Dec 8 2022, 3:10 AM · Restricted Project, Restricted Project
tblah updated the diff for D138675: [flang] Add -ffast-math and -Ofast.

Updating patch add documentation of the meaning of -Ofast, -ffast-math, and comparison with gfortran and nvfortran.

Dec 8 2022, 2:00 AM · Restricted Project, Restricted Project, Restricted Project

Dec 6 2022

tblah accepted D139401: [flang] Set correct box type when emboxing temporary in array value copy pass.

Thanks for this! LGTM

Dec 6 2022, 2:19 AM · Restricted Project, Restricted Project

Dec 5 2022

tblah added a comment to D139322: [mlir] Fix -Wstrict-prototypes warnings.

commit message seems hosed

Dec 5 2022, 6:00 AM · Restricted Project, Restricted Project
tblah added a reviewer for D139322: [mlir] Fix -Wstrict-prototypes warnings: kiranchandramohan.
Dec 5 2022, 5:46 AM · Restricted Project, Restricted Project
tblah retitled D139322: [mlir] Fix -Wstrict-prototypes warnings from [mlir to [mlir] Fix -Wstrict-prototypes warnings.
Dec 5 2022, 5:45 AM · Restricted Project, Restricted Project
tblah requested review of D139322: [mlir] Fix -Wstrict-prototypes warnings.
Dec 5 2022, 5:45 AM · Restricted Project, Restricted Project

Nov 30 2022

tblah updated the summary of D138675: [flang] Add -ffast-math and -Ofast.
Nov 30 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project
tblah updated the diff for D138675: [flang] Add -ffast-math and -Ofast.

Updated comment, updated patch context, fixed unused variable

Nov 30 2022, 3:04 AM · Restricted Project, Restricted Project, Restricted Project
tblah added a comment to D138907: [flang] Remove warnings that fast-math options are unimplemented.

Sorry about this, it should be fixed by https://github.com/llvm/llvm-project/commit/3a1b40925486c1eea80e2a0e636b208435487daf

Nov 30 2022, 2:38 AM · Restricted Project, Restricted Project
tblah committed rG3a1b40925486: [flang] fix unused variables (authored by tblah).
[flang] fix unused variables
Nov 30 2022, 2:38 AM · Restricted Project, Restricted Project

Nov 29 2022

tblah committed rG6841c43f36ee: [flang] Remove warnings that fast-math options are unimplemented (authored by tblah).
[flang] Remove warnings that fast-math options are unimplemented
Nov 29 2022, 9:17 AM · Restricted Project, Restricted Project
tblah closed D138907: [flang] Remove warnings that fast-math options are unimplemented.
Nov 29 2022, 9:17 AM · Restricted Project, Restricted Project
tblah updated the diff for D138675: [flang] Add -ffast-math and -Ofast.

Add test for -fstack-arrays usage warning

Nov 29 2022, 7:19 AM · Restricted Project, Restricted Project, Restricted Project