Page MenuHomePhabricator

[clang][modules][deps] Transitive module maps are not affecting
ClosedPublic

Authored by jansvoboda11 on Nov 1 2022, 2:46 PM.

Details

Summary

Currently, the algorithm for gathering affecting module maps includes those defining transitive dependencies. This seems like an over-approximation, since those don't change the semantics of current module build.

(With this patch, ModulesToProcess only ever holds modules whose headers will be serialized into the current PCM.)

Diff Detail

Event Timeline

jansvoboda11 created this revision.Nov 1 2022, 2:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 2:46 PM
Herald added a subscriber: ributzka. · View Herald Transcript
jansvoboda11 requested review of this revision.Nov 1 2022, 2:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 2:46 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Extract lambda, replace while with for

Bigcheese accepted this revision.Nov 8 2022, 11:12 AM

Yeah, I agree with this. lgtm.

This revision is now accepted and ready to land.Nov 8 2022, 11:12 AM